clayborg added a comment.

In D63240#1562527 <https://reviews.llvm.org/D63240#1562527>, @jingham wrote:

> This looks good to me.  I wonder if the SymbolContextScope -> Language 
> calculation that you do in IsRuntimeSupportValue should really be done in 
> SymbolContextScope?  If that's going to be the policy for going from 
> SymbolContextScope, maybe centralize it there?


I agree, centralize this in SymbolContextScope and this should be good to go. 
Thanks for sticking with this Alex.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63240/new/

https://reviews.llvm.org/D63240



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to