jingham marked 8 inline comments as done.
jingham added inline comments.
================
Comment at: include/lldb/Symbol/Symbol.h:258
+ m_is_weak : 1,
m_type : 7;
Mangled m_mangled; // uniqued symbol name/mangled name pair
----------------
clayborg wrote:
> change to:
> ```
> m_type : 6;
> ```
> See above comment.
>
>
Yup, apparently I can't count... Anyway, swift did add a few but we're still
well under 6 bits. I added a comment here saying where m_type gets its values
from and in the enum saying it needs to stay under 6 bits.
================
Comment at:
packages/Python/lldbsuite/test/expression_command/weak_symbols/TestWeakSymbols.py:24
+
+ @decorators.skipUnlessDarwin
+ def test_weak_symbol_in_expr(self):
----------------
clayborg wrote:
> We should get ELF support for this as well once this is in.
I don't know how this works in ELF, but if somebody else wants to try their
hand at it, that would be great.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63914/new/
https://reviews.llvm.org/D63914
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
