[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added a comment. This looks fine to me. I don't know much about frameworks, but I think it makes things cleaner by grouping all the framework-related code together. It's not introduced in this patch, but the part that struck me as a hack has the force-overwriting of LLVM_CODESIGNING_IDEN

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

labath added a comment. I am afraid I know know much about windows, or ds2. The thing I noticed is that this only seems to set the address of the main executable. Don't you also need to set the load address of loaded shared libraries (if any)? Repository: rLLDB LLDB CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov marked 6 inline comments as done. aleksandr.urakov added inline comments. Comment at: include/lldb/Expression/UserExpression.h:296 + lldb::ModuleSP *jit_module_sp_ptr = nullptr, + const lldb::ValueObjectSP &ctx_obj = lldb::ValueObjectSP());

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 177139. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Thanks for the comments, I've updated the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 Files:

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz updated this revision to Diff 177142. sgraenitz added a comment. Add short comment for NO_INSTALL_RPATH parameter to function description Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55316/new/ https://reviews.llvm.org/D55316 Files: cmake/modules/Add

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz marked 2 inline comments as done. sgraenitz added inline comments. Comment at: cmake/modules/AddLLVM.cmake:458 + if(NOT ARG_NO_INSTALL_RPATH) +if(ARG_MODULE OR ARG_SHARED) aprantl wrote: > Any kind of comment that we could add here that explains

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

This revision was automatically updated to reflect the committed changes. Closed by commit rL348573: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library() (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

labath added a comment. In D55384#1321970 , @zturner wrote: > Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and > `S_REGISTER` symbols. So, to get more test coverage, I added an MSVC test as > well. I don't want to block this patch, b

[Lldb-commits] [PATCH] D55422: Rename ObjectFile::GetHeaderAddress to GetBaseAddress

labath created this revision. labath added reviewers: clayborg, jasonmolenda, amccarth, lemo, stella.stamenova. This function was named such because in the case of MachO files, the mach header is located at this address. However all (most?) usages of this function were not interested in that fact

[Lldb-commits] [PATCH] D55422: Rename ObjectFile::GetHeaderAddress to GetBaseAddress

labath marked an inline comment as done. labath added a comment. Adding a bunch of people to make sure this makes sense for all object formats (I am particularly oblivious to how COFF works). If this makes sense, I'll implement this function in ObjectFilePECOFF and ELF to return the "image base"

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

labath planned changes to this revision. labath added a comment. In D55356#1321863 , @clayborg wrote: > This is already available with: > > virtual lldb_private::Address ObjectFile::GetHeaderAddress(); > > > It return a lldb_private::Address which is se

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz updated this revision to Diff 177193. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Remove LLDB_VERSION as it's not currently used by debugserver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55320/new/ https://reviews.llvm.org/D55320 Files: cmake/m

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz updated this revision to Diff 177194. sgraenitz added a comment. Revert accidental change utils/lldb-dotest/CMakeLists.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55320/new/ https://reviews.llvm.org/D55320 Files: cmake/modules/debugserverConfig.cmake tools/debugserv

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: cmake/modules/debugserverConfig.cmake:2 +# Duplicate options from LLDBConfig that are relevant for debugserver Standalone builds. + +option(LLDB_USE_ENTITLEMENTS "When code signing, use enti

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

labath created this revision. labath added a reviewer: zturner. Herald added subscribers: dexonsmith, mehdi_amini. This implements the gcc builder in build.py script to allow it to compile host executables when running on a non-windows host. Where it made sense, I tried to share code with the msvc

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL348592: Introduce ObjectFileBreakpad (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

Author: labath Date: Fri Dec 7 06:20:27 2018 New Revision: 348592 URL: http://llvm.org/viewvc/llvm-project?rev=348592&view=rev Log: Introduce ObjectFileBreakpad Summary: This patch adds the scaffolding necessary for lldb to recognise symbol files generated by breakpad. These (textual) files cont

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. Thanks for taking a look! > It's not introduced in this patch, but the part that struck me as a hack has > the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that > could be removed? I agree, this is unfortunate. The problem is that we only have a s

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. >> It's not introduced in this patch, but the part that struck me as a hack has >> the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that >> could be removed? > > I agree, this is unfortunate. The problem is that we only have a single > global sett

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath created this revision. labath added reviewers: clayborg, zturner, lemo, markmentovai, amccarth. This patch allows ObjectFileBreakpad to parse the contents of Breakpad files into sections. This sounds slightly odd at first, but in essence its not too different from how other object files han

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

labath updated this revision to Diff 177212. labath marked 3 inline comments as done. labath added a comment. Thanks for the review. Yes the changes were done by clang-format, which even in the diff-only mode doesn't know the difference between a moved file and a newly created one. I hope this ve

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added a comment. Printing the warning would definitely be nice. Making the identity overridable via llvm_codesign arguments also sounds reasonable if we want to have the flexibility of signing things with different identities. If we don't need that flexibility, can't we just have the us

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz added a comment. Thanks for taking a look! > It would be good to make sure that this works on mac, linux and windows all > before you commit. Shortly tested an in-tree lldb with clang, compiler-rt and lld on Windows using the below config and successfully built the `BUILD_ALL` projec

[Lldb-commits] [PATCH] D55422: Rename ObjectFile::GetHeaderAddress to GetBaseAddress

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Just one clarification in the header documentation and this is good to go. Comment at: include/lldb/Symbol/ObjectFile.h:561 + /// will have this section set

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. Working on it.. > .. if we want to have the flexibility of signing things with different > identities. Not sure if it's a good idea to sign with different identities within one build. Could become confusing? > If we don't need that flexibility, can't we just have th

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So sections should correspond to different kinds of sections, like .text, .data, etc. If we have the following breakpad file: MODULE Linux x86_64 24B5D199F0F766FF5D

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177229. sgraenitz added a comment. Improve handling of LLDB_CODESIGN_IDENTITY vs. LLVM_CODESIGNING_IDENTITY CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.c

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

JDevlieghere added a comment. This LGTM if it works on Windows. Comment at: CMakeLists.txt:134 --srcRoot=${LLDB_SOURCE_DIR} - --targetDir=${LLDB_PYTHON_TARGET_DIR} - --cfgBldDir=${LLDB_PYTHON_TARGET_DIR} + --targetDir=$

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177231. sgraenitz added a comment. Finally fix that typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake cmake/modul

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the question answered/addressed. Thanks Stefan, these patches are really great work! Comment at: tools/driver/CMakeLists.txt:27 +if(LLDB_BUILD_FRAMEWOR

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + @labath Could this be a way to phase out LLDB_CODESIGN_IDEN

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. Another point of clarification is that sections exist in order to lookup addresses and resolve addresses to a section within a file. The section should be something that can easily be slid around when loaded by LLDB when we are debugging or symbolicating. So any sectio

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + sgraenitz wrote: > @labath Could this be a way to phase out

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177243. zturner added a comment. Add some comments regarding fixing `DeclContext` reconstruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 Files: lldb/lit/SymbolFile/NativePDB/Inputs/ast-functions.l

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner marked 2 inline comments as done. zturner added a comment. In D55384#1322702 , @labath wrote: > In D55384#1321970 , @zturner wrote: > > > Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and >

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177244. zturner marked an inline comment as done. zturner added a comment. Removed accidentally added function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 Files: lldb/lit/SymbolFile/NativePDB/Inputs/a

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. I guess I should elaborate more on the direction where I am going with this. I am trying to model these breakpad files as a debug-info-only object file, like something you would get by running say `strip --only-keep-debug`. This object file will contain a bunch of sectio

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. Now it looks more clear, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

xiaobai accepted this revision. xiaobai added a comment. Definitely much easier to read. Thanks for taking care of this! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55317/new/ https://reviews.llvm.org/D55317 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + sgraenitz wrote: > sgraenitz wrote: > > @labath Could this be a way to phase out LLDB_CODESIGN_IDENTITY an

Re: [Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

Pavel, this broke the MacOS lldb cmake bot. In particular, this test started failing. lldb-Suite.macosx/function-starts.TestFunctionStarts.py http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ May I ask you to take a look? -- Davide On Fri, Dec 7, 2018 at 6:23 AM Pavel Labath via lldb-comm

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

xiaobai added a comment. Looks good to me overall. You also probably probably also invoke `lldb_setup_rpaths_framework` for the tools included in the framework (argdumper, darwin-debug, debugserver, lldb-server). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews

Re: [Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

On 07/12/2018 19:39, Davide Italiano wrote: Pavel, this broke the MacOS lldb cmake bot. In particular, this test started failing. lldb-Suite.macosx/function-starts.TestFunctionStarts.py http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ May I ask you to take a look? That's interesting.

[Lldb-commits] [lldb] r348629 - Revert "Introduce ObjectFileBreakpad"

Author: shafik Date: Fri Dec 7 10:59:00 2018 New Revision: 348629 URL: http://llvm.org/viewvc/llvm-project?rev=348629&view=rev Log: Revert "Introduce ObjectFileBreakpad" This reverts commit 5e056e624cc57bb22a4c29a70b522783c6242293. Reverting because this lldb cmake bot: http://lab.llvm.org:808

Re: [Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

Pavel, I just reverted it. -Shafik > On Dec 7, 2018, at 10:46 AM, Pavel Labath via lldb-commits > wrote: > > On 07/12/2018 19:39, Davide Italiano wrote: >> Pavel, this broke the MacOS lldb cmake bot. >> In particular, this test started failing. >> lldb-Suite.macosx/function-starts.TestFunctio

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL348631: [NativePDB] Reconstruct function declarations from debug info. (authored by zturner, committed by ). Herald added subscribers: llvm-commits, kristina. Changed prior to commit: https://reviews.ll

[Lldb-commits] [lldb] r348631 - [NativePDB] Reconstruct function declarations from debug info.

Author: zturner Date: Fri Dec 7 11:34:02 2018 New Revision: 348631 URL: http://llvm.org/viewvc/llvm-project?rev=348631&view=rev Log: [NativePDB] Reconstruct function declarations from debug info. Previously we would create an lldb::Function object for each function parsed, but we would not add t

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

stella.stamenova created this revision. stella.stamenova added reviewers: labath, asmith. Herald added a subscriber: lldb-commits. Instead use a more reasonable value to start and rely on the fact that SmallString will resize if necessary. Repository: rLLDB LLDB https://reviews.llvm.org/D554

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. So we do something like you describe with the DYSM files. The object file is "a.out" and it has a dSYM file "a.out.dSYM/Context/Resources/DWARF/a.out" and the dSYM file will share sections with the "a.out" object file. So if you plan on loading the breakpad file as a s

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. If you plan on not making the breakpad file ever stand alone, then you will need to take any addresses and look them up in the module section list and use the other sections. I don't see why the breakpad file can't be stand alone though. It won't be as accurate, but it

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo updated this revision to Diff 177329. lemo marked 3 inline comments as done. lemo added a comment. Incorporating feedback + adding a test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 Files: lit/Minidump/Windows/Sigsegv/Inputs/sigs

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:171-174 + // TODO: we need to compare the age, in addition to the GUID if (expected_info->getGuid() != guid) return nullptr; + labath wrote: > Mainly out

[Lldb-commits] [lldb] r348664 - [lit] Fix case-insensitive test

Author: stella.stamenova Date: Fri Dec 7 15:30:38 2018 New Revision: 348664 URL: http://llvm.org/viewvc/llvm-project?rev=348664&view=rev Log: [lit] Fix case-insensitive test The test still only passes when not run from VS because the previous patch did not remove the original build commands

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

lanza added a comment. @zturner and I spoke about it before landing @labath - correct. Dll loading needs handled. This was to upstream hello world functionality without DLLs. I need to figure out where and when to synchronize between ds2 and lldb for the `LOAD_DLL_DEBUG_EVENT`. I'll probably ge

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. - replace unnecessary shared pointers with unique pointers - reserve space before filling a vector with 'push_back' in a lo