JDevlieghere added a comment.

This LGTM if it works on Windows.


================
Comment at: CMakeLists.txt:134
                --srcRoot=${LLDB_SOURCE_DIR}
-               --targetDir=${LLDB_PYTHON_TARGET_DIR}
-               --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+               --targetDir=$<TARGET_PROPERTY:liblldb,LIBRARY_OUTPUT_DIRECTORY>
+               --cfgBldDir=$<TARGET_PROPERTY:swig_wrapper,BINARY_DIR>
----------------
stella.stamenova wrote:
> I have a vague recollection that using TARGET_PROPERTY didn't work for some 
> changes I was working on a few months ago, but I don't remember the details. 
> It would be good to make sure that this works on mac, linux and windows all 
> before you commit.
IIRC and if we’re talking about the same thing, the generator expressions 
didn’t work because we were using them in a configured file (the lldb-dotest 
wrapper). Anyway, still worth double checking here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55332/new/

https://reviews.llvm.org/D55332



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to