JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGTM with the question answered/addressed. Thanks Stefan, these patches are really great work! ================ Comment at: tools/driver/CMakeLists.txt:27 +if(LLDB_BUILD_FRAMEWORK) + lldb_setup_rpaths_framework(lldb) +endif() ---------------- Would it make sense/work to do the check inside this function? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits