Woops, my bad. I was hoping that "resume" was to "StepInstruction",
which does have an immediate action, but i did not check what it
actually does.
In this case, we could probably just use "StepOut" for the test case,
as it should have the same effect - advance the thread until it
reaches the next
Author: abidh
Date: Thu Jun 1 05:33:13 2017
New Revision: 304400
URL: http://llvm.org/viewvc/llvm-project?rev=304400&view=rev
Log:
Fix a small issue with -var-update.
If the variable was a pointer, code was ignoring the change in the
pointee.
Discussed in
http://lists.llvm.org/pipermail/lldb-de
Author: labath
Date: Thu Jun 1 06:20:17 2017
New Revision: 304405
URL: http://llvm.org/viewvc/llvm-project?rev=304405&view=rev
Log:
cmake: Enable process_vm_readv detection on android
Only android and linux can have this function as far as I am aware, but
it seems cleaner to enable this code for
labath created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D33771
Files:
cmake/modules/LLDBConfig.cmake
cmake/modules/LLDBGenerateConfig.cmake
include/lldb/Host/Config.h.cmake
include/lldb/Host/linux/Uio.h
source/Host/linux/LibcGlue.cpp
Index: source/Host
labath created this revision.
Herald added subscribers: mgorny, srhines.
This replaces the static functions used for creating
NativeProcessProtocol instances with a factory pattern, and modernizes
the interface of the new class in the process -- I use llvm::Expected
instead of the Status+value com
labath updated this revision to Diff 101023.
labath added a comment.
forgot to reformat the code
https://reviews.llvm.org/D33778
Files:
include/lldb/Host/common/NativeProcessProtocol.h
source/Host/common/NativeProcessProtocol.cpp
source/Plugins/Process/Linux/NativeProcessLinux.cpp
sourc
zturner added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148
- ::pid_t Attach(lldb::pid_t pid, Status &error);
+ static llvm::Expected> Attach(::pid_t pid);
Before it was only returning 1, now it's returning a vector. An
labath added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148
- ::pid_t Attach(lldb::pid_t pid, Status &error);
+ static llvm::Expected> Attach(::pid_t pid);
zturner wrote:
> Before it was only returning 1, now it's returni
krytarowski added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:112
+ if (wpid != pid || !WIFSTOPPED(wstatus)) {
+std::error_code EC(errno, std::generic_category());
+LLDB_LOG(
I can imagine that in some cases there m
eugene added inline comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148
- ::pid_t Attach(lldb::pid_t pid, Status &error);
+ static llvm::Expected> Attach(::pid_t pid);
labath wrote:
> zturner wrote:
> > Before it was only returning 1
spyffe created this revision.
When parsing types originating in modules, it is possible to encounter
`AttributedType`s (such as the type generated for `NSString *_Nonnull`). Some
of LLDB's `ClangASTContext` methods deal with them; others do not. In
particular, one function that did not was `G
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That seems correct since we aren't recording the attributes in the type flags.
The only question I have is that you're assuming something that has a TypeClass
of Attributed will always conve
spyffe added a comment.
`ModifiedType` gets assigned during construction and `getModifiedType()` is
just an accessor, so if that is `nullptr` something very bad is happening. We
should not expect that except in case of a parser bug of some sort.
`AttributedType` checks that a `Type*` is an `At
jingham added a comment.
Okay. If the attributed types were hand-built types from DWARF, I would still
worry a bit about the getModifiedType() call. But these only come from
modules, and those are built by orthodox methods so they should be
self-consistent.
Repository:
rL LLVM
https://re
Author: spyffe
Date: Thu Jun 1 20:24:18 2017
New Revision: 304510
URL: http://llvm.org/viewvc/llvm-project?rev=304510&view=rev
Log:
[TypeSystem] Handle Clang AttributedTypes
When parsing types originating in modules, it is possible to encounter
AttributedTypes
(such as the type generated for N
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304510: [TypeSystem] Handle Clang AttributedTypes (authored
by spyffe).
Changed prior to commit:
https://reviews.llvm.org/D33812?vs=101140&id=101158#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: jmolenda
Date: Fri Jun 2 00:17:19 2017
New Revision: 304520
URL: http://llvm.org/viewvc/llvm-project?rev=304520&view=rev
Log:
Move the code to find a binary in a bundle in the target.exec-search-paths
from PlatformRemoteDarwinDevice into PlatformDarwin, and have both
PlatformRemoteDarwinD
17 matches
Mail list logo
