eugene added inline comments.
================ Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148 - ::pid_t Attach(lldb::pid_t pid, Status &error); + static llvm::Expected<std::vector<::pid_t>> Attach(::pid_t pid); ---------------- labath wrote: > zturner wrote: > > Before it was only returning 1, now it's returning a vector. Any reason? > I've refactored the function a bit. It now returns a list of threads that it > has attached to. Previously it stored them in the object itself, but now it > can't as I don't construct a process object until I know that the attach has > succeeded. > > I should probably document the return value though. This method would certainly benefit from a comment that explains the nature of its return value. https://reviews.llvm.org/D33778 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
