zturner added inline comments.
================ Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148 - ::pid_t Attach(lldb::pid_t pid, Status &error); + static llvm::Expected<std::vector<::pid_t>> Attach(::pid_t pid); ---------------- Before it was only returning 1, now it's returning a vector. Any reason? ================ Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:152 - static void *MonitorThread(void *baton); + void InitializeThreads(llvm::ArrayRef<::pid_t> tids); ---------------- Shouldn't this be `tid_t`? https://reviews.llvm.org/D33778 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
