labath added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:10
+
+#include
+#include
jmajors wrote:
> labath wrote:
> > This still looks wrong. Did you run clang-format on the full patch (`git
> > clang-format origin/master` sh
tberghammer added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:22
+
+ bool delay = true;
+ std::vector threads;
You have to make this variable atomic (or add a mutex) to make it work. In the
current implementation there
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/tests/TestClient.cpp:115
+
+ if (thread_id == 0) thread_id = process_info->GetPid();
+
labath wrote:
> jmajors wrote:
> > labath wrote:
> > > This is a linux-ism. Other targets don't have
emaste added a comment.
Two small nits noted inline, but now the test does not pass without
https://reviews.llvm.org/D32271 and does with it. Note that in the "without"
case it returned error rather than failing, perhaps related to the path issue I
noted?
Other than that issue I think this is
dim added a comment.
As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME`
has one drawback: if an executable file has multiple hard links, you will get
just one of its filenames as the result. Since that filename is more or less
randomly chosen, it does *not* have to c
krytarowski added a comment.
If we end up with hard links I think we should change them to symbolic ones.
This is a common policy in some open source distributions.
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.ll
emaste added a comment.
In https://reviews.llvm.org/D32271#759361, @dim wrote:
> As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME`
> has one drawback: if an executable file has multiple hard links, you will get
> just one of its filenames as the result. Since that f
Author: jmolenda
Date: Fri May 19 18:00:42 2017
New Revision: 303465
URL: http://llvm.org/viewvc/llvm-project?rev=303465&view=rev
Log:
Don't override the SDKs and force the use of /System/Library/Frameworks to
find the python headers when buiding crashinfo.c
Modified:
lldb/trunk/packages/Py
jmajors marked 12 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:52
+
+ unsigned long ReadRegister(unsigned long register_id) const;
+
labath wrote:
> tberghammer wrote:
> > "unsigned long"
jmajors updated this revision to Diff 99644.
jmajors marked an inline comment as done.
jmajors added a comment.
More feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tool
Hello everyone,
Below are some buildbot numbers for the week of 04/30/2017 - 05/06/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 05/07/2017 -
05/13/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
12 matches
Mail list logo
