emaste added a comment. Two small nits noted inline, but now the test does not pass without https://reviews.llvm.org/D32271 and does with it. Note that in the "without" case it returned error rather than failing, perhaps related to the path issue I noted?
Other than that issue I think this is good to go. So hopefully that can be addressed, then one of the Linux folks can confirm it's good to go. IMO it's fine for this to go in first demonstrating the bug on FreeBSD followed by a commit of https://reviews.llvm.org/D32271. ================ Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:42 + def test_attach_to_process_frm_different_dir_by_id(self): + """Test attach by process id""" ---------------- s/frm/from/ perhaps? ================ Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:47 + exe = os.path.join('.','newdir','proc_attach') + self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.getcwd()))) + ---------------- shouldn't this be ... `rmtree(os.path.join(os.getcwd(), 'newdir'))` instead? Repository: rL LLVM https://reviews.llvm.org/D32522 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
