labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This makes all sorts of tests fail. Regardless of your platform you should at
least be able to reproduce the following failures:
FAIL: test_FPR_SSE (functionalities/postmortem/elf-
labath added a comment.
When I created the `MainLoop` class, i was hoping it would become the central
place for all select-like functionality. Currently it uses pselect, but i don't
see a reason we couldn't switch it to ppoll (but we actually don't have to, as
the current implementation should
Author: labath
Date: Tue Apr 11 07:26:25 2017
New Revision: 299933
URL: http://llvm.org/viewvc/llvm-project?rev=299933&view=rev
Log:
Remove Plugins/Process/POSIX from include_directories
Summary:
The files there can always be referred to using their full path, which
is what most of the code has b
Author: labath
Date: Tue Apr 11 07:26:33 2017
New Revision: 299934
URL: http://llvm.org/viewvc/llvm-project?rev=299934&view=rev
Log:
Add missing annotation to TestDataFormatterUnordered
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299933: Remove Plugins/Process/POSIX from
include_directories (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D31877?vs=94656&id=94805#toc
Repository:
rL LLVM
https://reviews
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is fine, as far as i am concerned.
Comment at: tools/debugserver/source/CMakeLists.txt:117
+POST_BUILD
+# Note: --entitlements option removed (see comment above)
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibCxxVector.cpp:301-304
+ TypeImpl type = valobj_sp->GetTypeImpl();
+ if (!type.IsValid())
+return nullptr;
+ CompilerType compiler_type = type.GetCompiler
labath updated this revision to Diff 94807.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D31880
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/TestDataFormatterLibcxxVBool.py
source/Plugins/Language/CPlusPlu
krytarowski added a comment.
I might need some guidance to address the asserts appropriately in finite time.
In general we set osabi to generic unix (value 0), and NetBSD core(5) files are
distinguished only (or mostly) with "NetBSD-CORE*" notes.
Repository:
rL LLVM
https://reviews.llvm.org
Just to be clear, this patch was only intended to be a starting point. I
didn't run the test suite or do anything other than verify that the core
loaded. ArchSpec is a pretty core class so touching it in this manner is
likely to have many side effects that you'll need to work out.
Most likely so m
zturner added a comment.
Networking isn't my area of domain expertise, so these are mostly just general
comments.
Comment at: include/lldb/Host/common/TCPSocket.h:55
+
+ std::map m_listen_sockets;
};
Any particular reason you're using a `std::map` instead of
zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
Comment at: include/lldb/Host/SocketAddress.h:44-45
+
//
+ static std::vector GetAddressI
Right,
This patch happened to does not fully work for me (NetBSD-CORE@ switches
were skipped), I will be back to it once I will get my current efforts
done on watchpoints and fpr.
Thank you for the initial scratch!
On 11.04.2017 17:14, Zachary Turner wrote:
> Just to be clear, this patch was onl
beanz added a comment.
@labath, I could adapt this into the `MainLoop` class, but I would actually
want to change how that class hierarchy is implemented. Regardless of the event
handling/polling model you use much of the code is identical between the
classes. I'd rather get rid of `MainLoopPos
jasonmolenda added a comment.
Looks good. I'd recommend adding clayborg as a reviewer and giving him a
couple days to comment on this if he has time. He wrote all of this code
originally.
Comment at: include/lldb/Host/common/TCPSocket.h:55
+
+ std::map m_listen_sockets;
}
Author: jingham
Date: Tue Apr 11 19:19:54 2017
New Revision: 300012
URL: http://llvm.org/viewvc/llvm-project?rev=300012&view=rev
Log:
Teach SBFrame how to guess its language.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-language/
lldb/trunk/packages/Python/lld
I noticed that the llvm.org sources crash when you do filename completion with
a file in the current working directory:
% build/Debug/lldb
(lldb) file aaa[TAB]Assertion failed: (!SearchDir.empty()), function
DiskFilesOrDirectories, file
/Volumes/newwork/svn/lldb/source/Commands/CommandComplet
Thanks for the heads up, I'll try to look at this tomorrow.
On Tue, Apr 11, 2017 at 5:55 PM Jason Molenda wrote:
> I noticed that the llvm.org sources crash when you do filename completion
> with a file in the current working directory:
>
> % build/Debug/lldb
> (lldb) file aaa[TAB]Assertion fa
beanz created this revision.
Herald added subscribers: mgorny, srhines, emaste.
This patch removes the hand maintained config files in favor of auto-generating
the config file. We will still need to maintain the defines for the Xcode
builds on Mac, but all CMake builds use the generated header i
krytarowski added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:433
+set(LLDB_CONFIG_TERMIOS_SUPPORTED ${HAVE_TERMIOS_H})
+set(LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED ${HAVE_FCNTL_H})
+if(NOT UNIX)
Can we just use `#ifdef F_GETPATH` in the source code?
krytarowski added a comment.
While there there are candidates like `pipe2`(2) in
`source/Host/posix/PipePosix.cpp`.
https://reviews.llvm.org/D31969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
beanz updated this revision to Diff 94924.
beanz added a comment.
- Fixing installation to make sure CMake always installs the generated Config.h
- Removing LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED becasue we really don't need it
https://reviews.llvm.org/D31969
Files:
cmake/modules/LLDBConfig.cmak
beanz updated this revision to Diff 94925.
beanz added a comment.
Actually uploading the updates this time...
https://reviews.llvm.org/D31969
Files:
cmake/modules/LLDBConfig.cmake
include/lldb/Host/Config.h
include/lldb/Host/Config.h.cmake
include/lldb/Host/android/Config.h
include/ll
beanz updated this revision to Diff 94928.
beanz added a comment.
Updating the hard coded Config.h
https://reviews.llvm.org/D31969
Files:
cmake/modules/LLDBConfig.cmake
include/lldb/Host/Config.h
include/lldb/Host/Config.h.cmake
include/lldb/Host/android/Config.h
include/lldb/Host/fre
zturner added a comment.
How much would it complicate things to move the hand maintained files out of
tree? If the Xcode build isn't really a thing we're officially supporting,
perhaps we can take that aggressive approach in-tree as well?
Comment at: cmake/modules/LLDBConfig
jasonmolenda added a comment.
This all looks good to me, thanks for doing this Pavel. Tamas asked in an
earlier comment, "The previous version of the data formatter was triggering for
std::vector> as well. Jason, do you know why was it the
case? Do we need that functionality because of a broke
zturner added inline comments.
Comment at: include/lldb/Host/common/TCPSocket.h:55
+
+ std::map m_listen_sockets;
};
jasonmolenda wrote:
> zturner wrote:
> > Any particular reason you're using a `std::map` instead of a `DenseMap` or
> > other similar LLVM stru
27 matches
Mail list logo
