zturner added a comment.
How much would it complicate things to move the hand maintained files out of
tree? If the Xcode build isn't really a thing we're officially supporting,
perhaps we can take that aggressive approach in-tree as well?
================
Comment at: cmake/modules/LLDBConfig.cmake:287-293
+ install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/
+ COMPONENT lldb_headers
+ DESTINATION include
+ FILES_MATCHING
+ PATTERN "*.h"
+ PATTERN ".svn" EXCLUDE
+ PATTERN ".cmake" EXCLUDE
----------------
Is this necessary?
================
Comment at: include/lldb/Host/Config.h.cmake:10-11
+
+#ifndef liblldb_Config_h_
+#define liblldb_Config_h_
+
----------------
Since we're in here anyway, can you use a fully qualified include guard here?
Like `#ifndef LLDB_HOST_CONFIG_H`?
https://reviews.llvm.org/D31969
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
