zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
================
Comment at: include/lldb/Host/SocketAddress.h:44-45
+
//----------------------------------------------------------------------------
+ static std::vector<SocketAddress> GetAddressInfo(const char *hostname,
+ const char *servname);
+
----------------
What about using `Twine` here instead of `const char *` literals?
================
Comment at: source/Host/common/SocketAddress.cpp:260
+ service_ptr = service_ptr->ai_next) {
+ addr_list.push_back(SocketAddress(service_ptr));
+ }
----------------
How about `emplace_back(service_ptr)`
https://reviews.llvm.org/D31822
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
