krytarowski added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74
+ printf("%" PRIx64, static_cast(syscall(__NR_gettid)));
#else
+ printf("{no-tid-support}");
Note to self -
```
#elif defined(__NetBSD__)
printf("%" PR
labath added a comment.
clang-format did not pick up the correct formatting because we have a
`.clang-format` file in `packages/Python/lldbsuite`. This was necessary because
a lot of the tests would get broken, as the formatting would break our `//
place breakpoint here` annotations (also, step
labath added a comment.
In https://reviews.llvm.org/D30172#682789, @amccarth wrote:
> Maybe we have too many categories.
Thanks. I was thinking about that as well. Currently there is about 110 log
statements in the windows log and 8 log categories. Things wouldn't get too
noisy even if we sh
Author: labath
Date: Wed Feb 22 04:38:02 2017
New Revision: 295822
URL: http://llvm.org/viewvc/llvm-project?rev=295822&view=rev
Log:
Replace WINLOG_*** macros with LLDB_LOG
Summary:
The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you hav
Author: labath
Date: Wed Feb 22 04:37:57 2017
New Revision: 295821
URL: http://llvm.org/viewvc/llvm-project?rev=295821&view=rev
Log:
Add format_provider for the MemoryRegionInfo::OptionalBool enum
Added:
lldb/trunk/unittests/Target/MemoryRegionInfoTest.cpp
Modified:
lldb/trunk/include/lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295822: Replace WINLOG_*** macros with LLDB_LOG (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30172?vs=89130&id=89342#toc
Repository:
rL LLVM
https://reviews.llvm.org/D301
labath created this revision.
The compiled expression is not needed once the location goes away. Also,
it holds a reference to the module, which prevents cleanup of the module
if somebody holds a reference to the breakpoint object.
This fixes the StepOverBreakpoint test on windows, but I am unsur
Author: labath
Date: Wed Feb 22 05:51:12 2017
New Revision: 295823
URL: http://llvm.org/viewvc/llvm-project?rev=295823&view=rev
Log:
Switch "lldb" log channel to the new registration mechanism
Modified:
lldb/trunk/include/lldb/Core/Log.h
lldb/trunk/include/lldb/Core/Logging.h
lldb/tru
labath created this revision.
This also removes magic rename code, which caused the channel to be
called "linux" when built on a linux machine, and "freebsd" when built
on a freebsd one, which seems unnecessary - registering a new channel is
sufficiently simple now that if we wish to log something
tberghammer created this revision.
Map ELF files as writable so we can update the relocations in them
After this change ELF files will be mapped as private writable pages so
we can cheaply update the relocations inside them without have to read
them into memory and any modification we do in the m
labath added a reviewer: zturner.
labath added a comment.
Adding Zachary as he was about to remove this code.
The timing of this patch is a bit unfortunate, as it would complicate the
removal of the code in question. If I am not mistaken, llvm's version currently
does not support copy-on-write
labath added a comment.
I think you are still waiting to get the llvm changes sorted out, but this side
of it looks fine to me (modulo a couple of nits).
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:414
+
+data_sp = std::make_shared(std::move(*Buffer));
Yea if this isn't urgent, can we wait for my other changes to go in?
Llvm does support mapping writable, but not through the same interface. So
it should still work
On Wed, Feb 22, 2017 at 6:43 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a reviewer: zturner.
Sure, it isn't urgent at all. I created this as a resolution for the crash
reported by Ramana (
http://lists.llvm.org/pipermail/lldb-dev/2017-February/012001.html) but I
don't fully understand the use case he/she is working on when wanting to
open a ".o" file yet (but I still wanted to get rid of a
Note that the breakpoint location's site gets cleared when you disable the
breakpoint or its location, as well as when you delete it. So if you have a
workflow that does: "hit a breakpoint, disable it, hit another, reenable the
first, hit the second" you'll end up re-evaluating the condition ex
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
I had locally code registering NetBSD specific log channel and this patch is
removing this needless code. Thank you for this work!
https://reviews.llvm.org/D30250
___
eugene updated this revision to Diff 89404.
eugene added a comment.
I have added local .clang-format file. But it didn't change the way main.cpp
was formated.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/.clang-format
packages/Python/lldbsuite/tes
labath added a comment.
> Note that the breakpoint location's site gets cleared when you disable the
> breakpoint or its location, as well as when you delete it. So if you have a
> workflow that does: "hit a breakpoint, disable it, hit another, reenable the
> first, hit the second" you'll end
Author: gclayton
Date: Wed Feb 22 15:32:16 2017
New Revision: 295881
URL: http://llvm.org/viewvc/llvm-project?rev=295881&view=rev
Log:
Fix header documentation.
Modified:
lldb/trunk/include/lldb/API/SBTarget.h
Modified: lldb/trunk/include/lldb/API/SBTarget.h
URL:
http://llvm.org/viewvc/llvm
Author: gclayton
Date: Wed Feb 22 15:32:48 2017
New Revision: 295882
URL: http://llvm.org/viewvc/llvm-project?rev=295882&view=rev
Log:
Fix header documentation.
Modified:
lldb/trunk/include/lldb/API/SBAttachInfo.h
Modified: lldb/trunk/include/lldb/API/SBAttachInfo.h
URL:
http://llvm.org/vie
tberghammer created this revision.
Improve data formatter for libstdcpp unique_ptr
- Fix infinite loop when there is a reference loop created from smart pointers
- Respect pointer depth argument in frame variable command
- Support dereferencing unique_ptr in the frame variable command
- Support o
In some classes we have a Clear method that we use to release resources from an
object when we are done with it but it might not get destroyed right away. I
pretty sure Greg thought that you would be adding your change to such a method;
and in fact it would be fine to add a Clear method to Brea
Author: spyffe
Date: Wed Feb 22 16:57:59 2017
New Revision: 295897
URL: http://llvm.org/viewvc/llvm-project?rev=295897&view=rev
Log:
Changed builld-llvm.py to use .json files
LLDB has many branches in a variety of repositories.
The build-script.py file is subtly different for each set.
This is un
Author: gclayton
Date: Wed Feb 22 17:42:55 2017
New Revision: 295907
URL: http://llvm.org/viewvc/llvm-project?rev=295907&view=rev
Log:
Fixed errors in AllocatedBlock:
- Allow zero byte size request for memory and ensure it gets a unique address
- Exit the free block loop when we find an appropriat
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
It seems a little wrong to me to hook "IsPointerLikeObject" up to the
ValueObject, and not to the Synthetic Child Provider for the type. After all,
you are using the Synthetic Chi
kubamracek added a comment.
@jingham ping
https://reviews.llvm.org/D30007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Aargh, sorry. My queue is overflowing... I had one tiny comment about the
tests. If you do that, then it will be fine to go in.
Comment at:
packages/Python/l
Hi Sean,
Looks like this is breaking builds in Green Dragon (and locally for me from
master branch). Can you take a look at the failures here?
http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console
Thanks!
-Tim
On Wed, Feb 22, 2017 at 2:57 PM, Sean Callanan via lldb-commits
I'll roll it back pending some fixes on my end.
Sorry for the break.
Sean
> On Feb 22, 2017, at 4:40 PM, Tim Hammerquist wrote:
>
> Hi Sean,
>
> Looks like this is breaking builds in Green Dragon (and locally for me from
> master branch). Can you take a look at the failures here?
>
> http://
Author: spyffe
Date: Wed Feb 22 18:46:30 2017
New Revision: 295915
URL: http://llvm.org/viewvc/llvm-project?rev=295915&view=rev
Log:
Reverted 295897 pending refinements and fixes for green-dragon.
Removed:
lldb/trunk/scripts/Xcode/repo.py
lldb/trunk/scripts/Xcode/repos/
Modified:
lldb
zturner updated this revision to Diff 89453.
zturner added a comment.
Updated with suggestions from labath@
https://reviews.llvm.org/D30054
Files:
lldb/include/lldb/Core/DataBufferHeap.h
lldb/include/lldb/Core/DataBufferLLVM.h
lldb/include/lldb/Core/DataBufferMemoryMap.h
lldb/include/ll
Author: spyffe
Date: Wed Feb 22 20:21:34 2017
New Revision: 295922
URL: http://llvm.org/viewvc/llvm-project?rev=295922&view=rev
Log:
Changed builld-llvm.py to use .json files
LLDB has many branches in a variety of repositories.
The build-script.py file is subtly different for each set.
This is un
I've recommitted with a bunch of fixes:
SendingINSTALL.txt
Sendingscripts/Xcode/build-llvm.py
Adding scripts/Xcode/repo.py
Adding scripts/Xcode/repos
Adding scripts/Xcode/repos/FALLBACK
Adding scripts/Xcode/repos/svn-trunk.json
Transmitting file data
omjavaid added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py:78
+
+while count < 4 :
+
labath wrote:
> This is quite
eugene created this revision.
eugene added a project: LLDB.
Herald added a subscriber: emaste.
https://reviews.llvm.org/D30286
Files:
include/lldb/Host/common/NativeProcessProtocol.h
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/test/tools/
36 matches
Mail list logo
