Sure, it isn't urgent at all. I created this as a resolution for the crash reported by Ramana ( http://lists.llvm.org/pipermail/lldb-dev/2017-February/012001.html) but I don't fully understand the use case he/she is working on when wanting to open a ".o" file yet (but I still wanted to get rid of an LLDB crash).
Tamas On Wed, Feb 22, 2017 at 3:03 PM Zachary Turner <ztur...@google.com> wrote: Yea if this isn't urgent, can we wait for my other changes to go in? Llvm does support mapping writable, but not through the same interface. So it should still work On Wed, Feb 22, 2017 at 6:43 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: labath added a reviewer: zturner. labath added a comment. Adding Zachary as he was about to remove this code. The timing of this patch is a bit unfortunate, as it would complicate the removal of the code in question. If I am not mistaken, llvm's version currently does not support copy-on-write mappings, which is what we are trying to do here. The c-o-w could certainly be added there, and we will probably need to do it in the future, but I am not sure whether this is the right time for it. I don't want to impede Zachary's cleanup effort due to a "feature" that noone has serious commitment of supporting. https://reviews.llvm.org/D30251
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
