jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed.
Aargh, sorry. My queue is overflowing... I had one tiny comment about the tests. If you do that, then it will be fine to go in. ================ Comment at: packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py:126-132 + self.assertEqual( + process.GetSelectedThread().GetStopReason(), + lldb.eStopReasonInstrumentation) + self.assertEqual( + process.GetSelectedThread().GetStopReasonDataAtIndex(0), + lldb.eInstrumentationRuntimeTypeAddressSanitizer) + ---------------- Can you add a check that GetStopReasonDataCount and only do the check for GetStopReasonDataAtIndex if this is 1? We have the ability to run the testsuite against older lldb's and it's good not to add failures if it can be avoided. Plus it's good to check that that call is returning a reasonable value. ================ Comment at: packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py:65-67 + self.assertEqual(process. + GetSelectedThread().GetStopReasonDataAtIndex(0), + lldb.eInstrumentationRuntimeTypeAddressSanitizer) ---------------- Same comment as above. ================ Comment at: packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:57-59 + self.assertEqual( + process.GetSelectedThread().GetStopReasonDataAtIndex(0), + lldb.eInstrumentationRuntimeTypeThreadSanitizer) ---------------- Same comment as above. https://reviews.llvm.org/D30007 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
