labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I am sorry about the delay - I was busy last week and then this kinda fell off
my radar.
The change looks good, but I want to make the test more stable - we are running
these in CI
Author: labath
Date: Tue Feb 21 03:58:23 2017
New Revision: 295712
URL: http://llvm.org/viewvc/llvm-project?rev=295712&view=rev
Log:
Log: Fix race in accessing the stream variable
Summary:
The code was attempting to copy the shared pointer member in order to
guarantee atomicity, but this is not e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295712: Log: Fix race in accessing the stream variable
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30168?vs=89120&id=89178#toc
Repository:
rL LLVM
https://reviews.llvm.o
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
Maybe we have too many categories.
Comment at: source/Plugins/Process/Windows/Common/DebuggerThread.cpp:207
if (m_active_exception.get()) {
-WINLOG_IFANY(WI
eugene created this revision.
eugene added a project: LLDB.
main.cpp is complete mess of tabs and spaces. This change brings it to
compliance with LLVM coding style.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbs
jmajors accepted this revision.
jmajors added a comment.
This revision is now accepted and ready to land.
Do we have any plans to put something like cpplint into effect?
https://reviews.llvm.org/D30234
___
lldb-commits mailing list
lldb-commits@list
eugene added a comment.
In https://reviews.llvm.org/D30234#682990, @jmajors wrote:
> Do we have any plans to put something like cpplint into effect?
First step would be to have warning free build.
Then we can turn "warnings as errors" on.
https://reviews.llvm.org/D30234
___
jingham added a comment.
It looks like clang-format wasn't run over this file as it was over all the
main lldb sources in the infamous universal code reformatting. That seems odd.
Anyway, it might be better just to do that to this file using the top level
.clang-format. Note that you are maki
jingham added a comment.
Actually, we didn't run the clang-format over the test case source files, since
we didn't want to have to deal with the possible failures resulting. So just
clang-formatting this file is probably the right way to go.
https://reviews.llvm.org/D30234
Hello everyone,
Below are some buildbot numbers for the last week of 02/12/2017 -
02/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the week of 02/05/2017 - 02/11/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
eugene updated this revision to Diff 89311.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
--- packages/Python/
eugene updated this revision to Diff 89312.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
--- packages/Python/
eugene added a comment.
In https://reviews.llvm.org/D30234#683018, @jingham wrote:
> Anyway, it might be better just to do that to this file using the top level
> .clang-format. Note that you are making several choices which were not the
> choices made by clang-format using the .clang-format f
Author: jmolenda
Date: Tue Feb 21 20:10:00 2017
New Revision: 295804
URL: http://llvm.org/viewvc/llvm-project?rev=295804&view=rev
Log:
Mark TestDarwinLogBasic.py as an xfail because the logging is
not being picked up; filed to track
the work to investigate this.
Modified:
lldb/trunk/package
eugene marked an inline comment as done.
eugene added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:32-42
+static const char *const RETVAL_PREFIX = "retval:";
+static const char *const SLEEP_PREFIX = "sleep:";
+static const char *const STD
16 matches
Mail list logo
