amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
Maybe we have too many categories.
================
Comment at: source/Plugins/Process/Windows/Common/DebuggerThread.cpp:207
if (m_active_exception.get()) {
- WINLOG_IFANY(WINDOWS_LOG_PROCESS | WINDOWS_LOG_EXCEPTION,
- "StopDebugging masking active exception");
-
+ LLDB_LOG(log, "masking active exception");
ContinueAsyncException(ExceptionResult::MaskException);
----------------
This looks like the only possibly controversial change in this file. This log
message will no longer happen for those logging just exception-related events.
I guess that's acceptable as it's unlikely.
================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:873
+ log,
+ "Hit loader breakpoint at address {0:x}, setting initial stop
event.",
+ record.GetExceptionAddress());
----------------
This one and the next one seem unfortunate, as the messages are indeed
something you'd expect to see when logging breakpoints.
It makes me wonder if all these categories are worth the effort.
https://reviews.llvm.org/D30172
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
