brucem created this revision.
brucem added reviewers: tfiala, granata.enrico, clayborg.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D13125
Files:
source/Host/macosx/Host.mm
Index: source/Host/macosx/Host.mm
==
Author: brucem
Date: Thu Sep 24 02:08:29 2015
New Revision: 248466
URL: http://llvm.org/viewvc/llvm-project?rev=248466&view=rev
Log:
Improve error reporting for failing to find argdumper.
Reviewers: tfiala, granata.enrico, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248466: Improve error reporting for failing to find
argdumper. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13125?vs=35590&id=35591#toc
Repository:
rL LLVM
http://reviews.
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MIUtilString.cpp:41
@@ -40,3 +40,3 @@
CMIUtilString::CMIUtilString(const char *vpData)
-: std::string(vpData)
+: std::string(vpData != nullptr ? vpData : "")
{
ki.stfu wrote:
> Not sure about use
labath added a comment.
I don't want to stand in the way of progress (and I do think that getting rid
of the timeout dependency is progress), but this implementation regresses in a
couple of features compared to using timeout:
- timeout tries (with moderate success) to cleanup children spawned
evgeny777 updated this revision to Diff 35607.
evgeny777 added a comment.
Revised according to suggestions from granta.enrico and ki.stfu
http://reviews.llvm.org/D13058
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.p
brucem added a subscriber: brucem.
brucem added a comment.
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a comment.
It doesn't seem right to have a strong construction and copy just to determine
the length or if it is empty or not as in your examples. That would be
appropriate for a helper function.
http://reviews.llvm.org/D13094
___
lld
evgeny777 updated this revision to Diff 35618.
evgeny777 added a comment.
Revised, removed dependencies from http://reviews.llvm.org/D13094
http://reviews.llvm.org/D13058
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
test/tools/lldb-mi/variable/TestMiGdbSetShowPrint
On 23 September 2015 at 13:47, Siva Chandra via lldb-commits
wrote:
> Author: sivachandra
> Date: Wed Sep 23 12:47:08 2015
> New Revision: 248401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248401&view=rev
> Log:
> DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or
>
On Thu, Sep 24, 2015 at 6:40 AM, Ed Maste wrote:
> The test case fails on FreeBSD right now because there's no error on
> "limit" and "nolimit":
>
> (lldb) expr f
> (Foo) $0 = (s = "qwerty")
> (lldb) expr s
> (MyString) $1 = (std::__1::string = "qwerty")
>
Does -flimit-debug-info have any effect
On Thu, Sep 24, 2015 at 6:47 AM, Siva Chandra
wrote:
>
>
> On Thu, Sep 24, 2015 at 6:40 AM, Ed Maste wrote:
>
>> The test case fails on FreeBSD right now because there's no error on
>> "limit" and "nolimit":
>>
>> (lldb) expr f
>> (Foo) $0 = (s = "qwerty")
>> (lldb) expr s
>> (MyString) $1 = (st
I don't have access to a FreeBSD or a mac at the moment. Can you, or
someone else, check how -fstandalone-debug and -fno-standalone-debug behave?
On Thu, Sep 24, 2015 at 6:57 AM, Siva Chandra
wrote:
> On Thu, Sep 24, 2015 at 6:47 AM, Siva Chandra
> wrote:
>
>>
>>
>> On Thu, Sep 24, 2015 at 6:40
evgeny777 updated this revision to Diff 35620.
evgeny777 added a comment.
Revised, now contains fix for just assignment operation
The "if(vpRhs != nullptr)" was removed to provide the same behaviour for
a) CMIUtilString s = (char*)nullptr;
b) s = (char*)nullptr;
http://reviews.llvm.org/D13094
If I understand correctly, the process hierarchy used to look like this:
python - dotest.py
|__ python - multiprocessing fork
|__ python - lldbtest
|__ inferior executable
And now looks like this:
python - dotest.py
|__ python - lldbtest
|__ inferior executable
In
tfiala added a comment.
In http://reviews.llvm.org/D13124#252564, @labath wrote:
> I don't want to stand in the way of progress (and I do think that getting rid
> of the timeout dependency is progress), but this implementation regresses in
> a couple of features compared to using timeout:
>
> -
labath added a comment.
I haven't followed the recent changes too closely, but at some point the
hierarchy was:
dosep.py
dosep.py fork
timeout
dotest.py (lldb client)
lldb-server
inferior
other executables which were sometimes spawned by the te
labath added a comment.
In http://reviews.llvm.org/D13124#252791, @tfiala wrote:
> In http://reviews.llvm.org/D13124#252564, @labath wrote:
>
> > I don't want to stand in the way of progress (and I do think that getting
> > rid of the timeout dependency is progress), but this implementation
> >
tfiala added a comment.
In http://reviews.llvm.org/D13124#252784, @zturner wrote:
> If I understand correctly, the process hierarchy used to look like this:
>
> python - dotest.py
> |__ python - multiprocessing fork
>
> |__ python - lldbtest
> |__ inferior executable
>
>
> And now l
tfiala added a comment.
> Thanks for working on this once again :)
Sure thing!
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I filed this:
https://llvm.org/bugs/show_bug.cgi?id=24926
And I'm starting to look at it now.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tfiala added a comment.
> What is happening is that it is looking for argdumper and not finding it.
> This happens because it is looking in the lib directory within the build
> directory, but argdumper is in the bin directory (where it should be).
I'm not sure I would say that is accurate. ar
Author: gclayton
Date: Thu Sep 24 11:37:41 2015
New Revision: 248513
URL: http://llvm.org/viewvc/llvm-project?rev=248513&view=rev
Log:
Don't enter interactive loop when finished running the test suite.
Modified:
lldb/trunk/test/curses_results.py
Modified: lldb/trunk/test/curses_results.py
U
I'm ok with leaving some straggling processes on Windows for now, because
it's obviously better than what we have currently, which is nothing. I can
implement some sort of helper module at some point that exposes a new
createProcess function that supports this for Windows and Unix with a
single in
tfiala added a comment.
> Which reminds me of another thing: Since you're working heavily on the tet
> suite, one thing I've always wanted is what I just mentioned: Something
> like an lldbxplat module which is essentially a helper module that exposes
> a single interface for doing things
KLapshin added a comment.
@clayborg, @labath,
After more deep investigation I think setting listener for hijacking also looks
like workaround. Setting additional listener just change code flow path and
buggy path not executed, thus no crash. At top level - crash appeared in
Process::m_listener
clayborg added a comment.
Each shared library is an object that can be shared between multiple targets.
We do not want to injecting types from another shared library into the static
notion of what a type is within a shared library. Why? What if one target in
lldb loads liba.so which has a forwa
sivachandra created this revision.
sivachandra added reviewers: dblaikie, clayborg.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13143
Files:
test/lang/cpp/incomplete-types/Makefile
test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py
test/lang/cpp/incomplete-t
I don't want compiler options in the test Makefiles. Please move the logic
to Makefile.rules, and create a variable and set that instead.
On Thu, Sep 24, 2015 at 11:43 AM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> clayborg added a comment.
>
> Each shared library is an
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
I know, I've seen them in a few places myself. But I think we should move
away from that, because it's a large source of portability problems
http://reviews.llvm.org/D13066
___
lldb-commits mailing list
lldb-commits@lists.l
dawn added a comment.
Is there a workaround for this? Ok to revert this commit until it is fixed?
It's blocker for me. Thanks.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
tfiala added a comment.
Hi Dawn,
See https://llvm.org/bugs/show_bug.cgi?id=24926 for a workaround. I'm
developing a fix for it. Still testing but what is there in that patch (in the
bug) works for your build scenario as long as you add '--executable
/path/to/your/just/build/lldb' when callin
dawn added a comment.
Hi Todd, yes, I read the bug report and updated my comment while you were
writing yours :)
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
tfiala added a comment.
> Hi Todd, yes, I read the bug report and updated my comment while you were
> writing yours :)
Great! Once I validate that the standard OS X build isn't busted (in
progress), I'll get it checked in.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
tfiala added a comment.
I do intend to get back to this after resolving the cmake build issue on OS X.
Hopefully by tonight.
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
tfiala added inline comments.
Comment at: test/curses_results.py:223
@@ -223,1 +222,3 @@
+# Greg - not sure why this is here. It locks up on
exit.
+# self.main_window.key_event_loop()
lldbcurses.terminate_c
On 24 September 2015 at 10:04, Siva Chandra wrote:
> I don't have access to a FreeBSD or a mac at the moment. Can you, or someone
> else, check how -fstandalone-debug and -fno-standalone-debug behave?
Both OS X and FreeBSD default to full debug info, but the enable /
disable options should still
Author: sivachandra
Date: Thu Sep 24 16:29:54 2015
New Revision: 248541
URL: http://llvm.org/viewvc/llvm-project?rev=248541&view=rev
Log:
[TestCppIncompleteTypes] Remove the dependence on std::string.
Reviewers: dblaikie, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.
On Thu, Sep 24, 2015 at 2:15 PM, Ed Maste wrote:
> On 24 September 2015 at 10:04, Siva Chandra
> wrote:
> > I don't have access to a FreeBSD or a mac at the moment. Can you, or
> someone
> > else, check how -fstandalone-debug and -fno-standalone-debug behave?
>
> Both OS X and FreeBSD default to
Author: tfiala
Date: Thu Sep 24 16:59:48 2015
New Revision: 248545
URL: http://llvm.org/viewvc/llvm-project?rev=248545&view=rev
Log:
Fix tests on cmake-based OS X after rL248338
See:
https://llvm.org/bugs/show_bug.cgi?id=24926
for details. On OS X, when LLDB.framework is
not part of the lldb.dy
tfiala added a comment.
The cmake OS X fix went in here:
Sendingsource/Host/macosx/HostInfoMacOSX.mm
Transmitting file data .
Committed revision 248545.
Let me know if you still have trouble after that.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
sivachandra created this revision.
sivachandra added a reviewer: chying.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13147
Files:
test/lang/cpp/incomplete-types/Makefile
Index: test/lang/cpp/incomplete-types/Makefile
==
Author: sivachandra
Date: Thu Sep 24 17:13:36 2015
New Revision: 248547
URL: http://llvm.org/viewvc/llvm-project?rev=248547&view=rev
Log:
[TestCppIncompleteTypes] Handle different archs when building a.o.
Reviewers: chying
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248547: [TestCppIncompleteTypes] Handle different archs when
building a.o. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13147?vs=35678&id=35679#toc
Repository:
rL LLVM
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
GoLanguageRuntime supports finding the runtime type for Go interfaces.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
Files:
To be clear, I would like this Makefile to turn into the following:
LEVEL = ../../../make
CXX_SOURCES = main.cpp length.cpp
DEBUG_INFO_FULL = True
DEBUG_INFO_LIMITED = True
And that's it. You shouldn't need anything else. Whatever needs to happen
in Makefile.rules to make this work should be
Also,when you say the next iteration, is this something that is going to
happen at an unknown time in the future whenever you happen to touch it
again, or are you working on another iteration now?
On Thu, Sep 24, 2015 at 4:25 PM Zachary Turner wrote:
> To be clear, I would like this Makefile to
zturner added a comment.
Also,when you say the next iteration, is this something that is going to
happen at an unknown time in the future whenever you happen to touch it
again, or are you working on another iteration now?
http://reviews.llvm.org/D13066
zturner added a comment.
To be clear, I would like this Makefile to turn into the following:
LEVEL = ../../../make
CXX_SOURCES = main.cpp length.cpp
DEBUG_INFO_FULL = True
DEBUG_INFO_LIMITED = True
And that's it. You shouldn't need anything else. Whatever needs to happen
in Makefile.rules to
On 24 September 2015 at 17:35, Siva Chandra wrote:
>
> As blaikie pointed out on the review, it could be because libc++ (which is
> the default on FreeBSD and Darwin?) does not have an explicit declaration
> for std::basic_string<...>? I have now landed a change which removes the
> dependence on s
On Thu, Sep 24, 2015 at 4:57 PM, Ed Maste wrote:
> On 24 September 2015 at 17:35, Siva Chandra
> wrote:
> >
> > As blaikie pointed out on the review, it could be because libc++ (which
> is
> > the default on FreeBSD and Darwin?) does not have an explicit declaration
> > for std::basic_string<...
dawn accepted this commit.
dawn added a comment.
Fixed by Todd in r248545. Todd rocks!!! :)
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
dawn added a comment.
The LaunchWithShellExpandTestCase tests are now fixed, but I'm still seeing a
failure in the LaunchInTerminalTestCase test.
Users:
spyffe (Author)
dawn (Auditor)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing l
Author: dperchik
Date: Thu Sep 24 21:16:52 2015
New Revision: 248555
URL: http://llvm.org/viewvc/llvm-project?rev=248555&view=rev
Log:
Fix evaluation of unicode character arrays (char16_t[] and char32_t[])
Suppose we have the UTF-16 string:
char16_t[] s = u"hello";
Before this patch, evaluati
tfiala added a comment.
> Fixed by Todd in r248545.
Oh good!
> Todd rocks!!! :)
You are far too kind :-)
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
bhushan created this revision.
bhushan added a reviewer: clayborg.
bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, sagar,
jaydeep.
bhushan set the repository for this revision to rL LLVM.
In MIPS, an application elf can contain mixed code (mips + micromips) i.e some
function
tfiala added a comment.
> That's a good idea. I'm (somewhat slowly) attempting to work in some clean up
> each time I touch it. I'll hit that at some point. I'll start winding down on
> changes to the test infrastructure soon-ish. If I don't hit that by the time
> I stop heavy changes, definite
ki.stfu created this revision.
ki.stfu added reviewers: abidh, brucem.
ki.stfu added subscribers: abidh, brucem, lldb-commits.
Allow to construct CMIUtilString using std::string directly (MI)
This patch cleans up lldb-mi code, and serves to simplify
the following case:
```
std::string strGoodby
brucem added inline comments.
Comment at: tools/lldb-mi/MICmdInterpreter.cpp:166
@@ -165,3 +165,3 @@
m_miCmdData.strMiCmdToken = strNum.c_str();
}
Can this one be changed too?
http://reviews.llvm.org/D13158
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdInterpreter.cpp:166
@@ -165,3 +165,3 @@
m_miCmdData.strMiCmdToken = strNum.c_str();
}
brucem wrote:
> Can this one be changed too?
Sure.
http://reviews.llvm.org/D13158
_
ki.stfu updated this revision to Diff 35703.
ki.stfu added a comment.
A little fix as @brucem requested; Remove CMIUtilString(const char *const
*vpData) and CMIUtilString(const char *vpData, size_t nLen) ctors; Cleanup
CMIUtilString::operator=(const std::string &vrRhs)
http://reviews.llvm.org/
62 matches
Mail list logo
