Re: [Lldb-commits] [PATCH] D13125: Improve error reporting for failing to find argdumper.

[Bruce Mitchener via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL248466: Improve error reporting for failing to find 
argdumper. (authored by brucem).

Changed prior to commit:
  http://reviews.llvm.org/D13125?vs=35590&id=35591#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13125

Files:
  lldb/trunk/source/Host/macosx/Host.mm

Index: lldb/trunk/source/Host/macosx/Host.mm
===================================================================
--- lldb/trunk/source/Host/macosx/Host.mm
+++ lldb/trunk/source/Host/macosx/Host.mm
@@ -1345,13 +1345,13 @@
         FileSpec expand_tool_spec;
         if (!HostInfo::GetLLDBPath(lldb::ePathTypeSupportExecutableDir, 
expand_tool_spec))
         {
-            error.SetErrorString("could not find argdumper tool");
+            error.SetErrorString("could not get support executable directory 
for argdumper tool");
             return error;
         }
         expand_tool_spec.AppendPathComponent("argdumper");
         if (!expand_tool_spec.Exists())
         {
-            error.SetErrorString("could not find argdumper tool");
+            error.SetErrorStringWithFormat("could not find argdumper tool: 
%s", expand_tool_spec.GetPath().c_str());
             return error;
         }
 



Index: lldb/trunk/source/Host/macosx/Host.mm
===================================================================
--- lldb/trunk/source/Host/macosx/Host.mm
+++ lldb/trunk/source/Host/macosx/Host.mm
@@ -1345,13 +1345,13 @@
         FileSpec expand_tool_spec;
         if (!HostInfo::GetLLDBPath(lldb::ePathTypeSupportExecutableDir, expand_tool_spec))
         {
-            error.SetErrorString("could not find argdumper tool");
+            error.SetErrorString("could not get support executable directory for argdumper tool");
             return error;
         }
         expand_tool_spec.AppendPathComponent("argdumper");
         if (!expand_tool_spec.Exists())
         {
-            error.SetErrorString("could not find argdumper tool");
+            error.SetErrorStringWithFormat("could not find argdumper tool: %s", expand_tool_spec.GetPath().c_str());
             return error;
         }
 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits