[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:859 +p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) +

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ef51b5f979: [lldb][dotest] Improve libc++ detection (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71319/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems ok. The reason these checks are written this way is because we used to have the xcode build which bypassed cmake and lit, so this was the only place to implement that centrally. Now

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

merge_guards_bot added a comment. Build result: pass - 60689 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. The test logic for running libc++ tests only looks to see if `/usr/include/c++/v1` exists. This adds a fallback for