rupprecht marked an inline comment as done.
rupprecht added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:859
+ p = subprocess.Popen(cmd, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
+ _, stderr = p.communicate("int main() {}")
+ if not p.returncode:
----------------
FYI, the check didn't work because this isn't exercising anything in libc++, it
really only checks that `-stdlib=libc++` is a valid compiler flag.
786b6db8e6fd87fb82f2ad3e94e20c5c9cf9c4e4 fixes this by adding a libc++ include,
which fails the command if libc++ is not installed where clang can find it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71319/new/
https://reviews.llvm.org/D71319
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
