labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
This seems ok. The reason these checks are written this way is because we used to have the xcode build which bypassed cmake and lit, so this was the only place to implement that centrally. Nowadays, we could probably come up with a simpler way to do these things, but I don't have a clear idea on how to do that yet... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71319/new/ https://reviews.llvm.org/D71319 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits