[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar closed this revision. grimar added a comment. Committed as https://reviews.llvm.org/rLLDB346848. The commit message has a wrong review link by mistake. https://reviews.llvm.org/D52403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for the review! It still depends on -gsingle-file-split-dwarf (https://reviews.llvm.org/D52403), I'll wait for it some time. It should be possible to rewrite the comment in the test case to avoid mentioning the flag, but I would prefer to use it. https://reviews.

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! https://reviews.llvm.org/D52403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167440. grimar marked an inline comment as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/single-file-split-dwarf.o.yaml lit/Breakpoint/Inputs/sin

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added inline comments. Comment at: include/lldb/lldb-enumerations.h:643-660 + eSectionTypeDWARFDebugAbbrevDwo, eSectionTypeDWARFDebugAddr, eSectionTypeDWARFDebugAranges, eSectionTypeDWARFDebugCuIndex, eSectionTypeDWARFDebugFrame, eSectionTypeDWARFDebugInfo,

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few fixes. Looking good. Comment at: include/lldb/lldb-enumerations.h:643-660 + eSectionTypeDWARFDebugAbbrevDwo, eSectionTypeDWARFDebugAddr, eSect

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167287. grimar added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/single-file-spli

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for all the comments! In https://reviews.llvm.org/D52403#1243127, @clayborg wrote: > So the main questions is: do we need a new section enum called > eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I > would prefer adding a new enum. Yeah

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

clayborg added a comment. So the main questions is: do we need a new section enum called eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I would prefer adding a new enum. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:68 -if (aut

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

labath added a comment. I believe you should be able to use `lldb-test` to write this kind of a test. I am thinking of a sequence like: yaml2obj %p/Inputs/test.yaml > %t/test.yaml yaml2obj %p/Inputs/test.o.yaml > %t/test.o.yaml lldb-test breakpoint %t/test.yaml %s | FileCheck %s b main

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar created this revision. grimar added reviewers: LLDB, clayborg, aprantl, dblaikie, probinson. Herald added a subscriber: JDevlieghere. DWARF5 spec describes single file split dwarf case (when .dwo sections are in the .o files). Problem is that LLDB does not work correctly in that case. The