grimar added inline comments.
================
Comment at: include/lldb/lldb-enumerations.h:643-660
+ eSectionTypeDWARFDebugAbbrevDwo,
eSectionTypeDWARFDebugAddr,
eSectionTypeDWARFDebugAranges,
eSectionTypeDWARFDebugCuIndex,
eSectionTypeDWARFDebugFrame,
eSectionTypeDWARFDebugInfo,
+ eSectionTypeDWARFDebugInfoDwo,
----------------
clayborg wrote:
> Add all of these to the end of this enum for API stability since this is a
> public header used in the API. If an older binary runs against a newer
> liblldb.so, all of these enums will be off.
Done.
================
Comment at: source/Symbol/ObjectFile.cpp:347
case eSectionTypeDWARFDebugAbbrev:
+ case eSectionTypeDWARFDebugAbbrevDwo:
case eSectionTypeDWARFDebugAddr:
----------------
clayborg wrote:
> Check for other ObjectFile subclasses that override this function. I believe
> ObjectFileMachO does.
Yes, and my patch already has the change for ObjectFileMachO :)
All other classes are fine too I think.
https://reviews.llvm.org/D52403
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
