JDevlieghere abandoned this revision.
JDevlieghere added a comment.
Herald added a reviewer: serge-sans-paille.
Herald added a subscriber: jdoerfert.
Abandoning this until we can replace the dotest driver with lit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D47062/new/
https://reviews
labath added a comment.
In https://reviews.llvm.org/D47062#1109399, @JDevlieghere wrote:
> I'm going to hold off on this until we have decided what to do for
> https://reviews.llvm.org/D46005. If we run the test cases as separate lit
> invocations, then the test format is in a better position t
JDevlieghere added a comment.
I'm going to hold off on this until we have decided what to do for
https://reviews.llvm.org/D46005. If we run the test cases as separate lit
invocations, then the test format is in a better position to report this
information.
https://reviews.llvm.org/D47062
_
JDevlieghere updated this revision to Diff 147787.
JDevlieghere added a comment.
Herald added a subscriber: mgorny.
Make this work for Windows
https://reviews.llvm.org/D47062
Files:
packages/Python/lldbsuite/test/dosep.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/
labath added a comment.
Looks fine to me, just make the path computation windows-compatible.
Comment at: packages/Python/lldbsuite/test/dotest.py:386
+if is_exe(lldbtest_config.lldbExec):
+lldbtest_config.dotestWrapper = "{}-dotest".format(
+ os
JDevlieghere updated this revision to Diff 147711.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
- Use absolute path to `lldb-dotest` when `--executable` is passed.
https://reviews.llvm.org/D47062
Files:
packages/Python/lldbsuite/test/dosep.py
packages/Python/
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr)
-print("Command invoked: %s" % ' '.join(command), file=sys.stderr)
+print("Reproduce with: lld
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
In https://reviews.llvm.org/D47062#1104558, @davide wrote:
> Can you commit the whitespace fixes separately?
Sure.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAI
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr)
-print("Command invoked: %s" % ' '.join(command), file=sys.stderr)
+print("Reproduce with: lld
davide added a comment.
Can you commit the whitespace fixes separately?
Repository:
rL LLVM
https://reviews.llvm.org/D47062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, davide, aprantl.
Rather than trying to figure out what arguments to pass to `dotest.py`, suggest
using `lldb-dotest`. Athough this obviously won't work for all invocations
(i.e. when you're passing custom arguments to `lld
11 matches
Mail list logo
