krytarowski added a comment.
Thanks! I noted that I introduced some bugs.. but I will fix them in future
revisions. I will move on to threads now. FPR/watchpoints will be done later,
on the cost on adding some code for cores and helping out with base system work.
LLDB/NetBSD is now out of the b
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you. Keep up the good work.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
krytarowski added a comment.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31450
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham resigned from this revision.
jingham added a comment.
Kyril, I haven't been involved in the lldb-server parts of lldb. Greg sketched
out those interfaces and mostly folks working on Windows & Linux have fleshed
them out. I haven't been following the design discussions for lldb-server,
krytarowski updated this revision to Diff 93524.
krytarowski added a comment.
Herald added a subscriber: srhines.
Apply changes from review. No visible regressions in "check-lldb".
Repository:
rL LLVM
https://reviews.llvm.org/D31450
Files:
source/Host/common/Host.cpp
source/Plugins/Dynam
krytarowski added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+ // Initialize new thread
+ struct ptrace_lwpinfo info = {};
+ Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
labath wrote
labath added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+ // Initialize new thread
+ struct ptrace_lwpinfo info = {};
+ Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
krytarowski wrote
krytarowski added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383
// On Linux the executable is indicated by an empty path in the entry. On
// FreeBSD and on Android it is the full path to the executable.
ketten
kettenis added a comment.
The core file reading bits look ok to me.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383
// On Linux the executable is indicated by an empty path in the entry. On
// FreeBSD and on Android it is the full path to the ex
krytarowski added a comment.
I think I will start the threading segment with proper handling of core(5)
files. It looks like the simplest start point.
OpenBSD uses very similar format and can catch up quickly.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
__
krytarowski added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+ // Initialize new thread
+ struct ptrace_lwpinfo info = {};
+ Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
labath wrote
labath added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+ // Initialize new thread
+ struct ptrace_lwpinfo info = {};
+ Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
This is the third
krytarowski added a reviewer: jingham.
krytarowski added a comment.
Adding Jim as a reviewer, since Pavel is mostly out of the keyboard for longer
time.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
___
lldb-commits mailing list
lldb-commi
krytarowski added a comment.
Next: watchpoints, FPR.
Current core(5) file format is a subject to change (AUXV can be shortened)...
I'm working on the final nits for the NetBSD-8 interfaces.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
__
krytarowski created this revision.
krytarowski added a project: LLDB.
Include initial support for:
- single step mode (PT_STEP)
- single step trap handling (TRAP_TRACE)
- exec() trap (TRAP_EXEC)
- add placeholder interfaces for FPR
- initial code for NetBSD core(5) files
- minor tweaks
While the
15 matches
Mail list logo
