krytarowski added inline comments.
================ Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249 + // Initialize new thread + struct ptrace_lwpinfo info = {}; + Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info)); ---------------- labath wrote: > krytarowski wrote: > > labath wrote: > > > This is the third place i'm seeing this code. Any chance of turning it > > > into a function? > > Everything that touches threads will be refactored in future. > > > > I suspect that at the end this code will lost its capability to iterate > > threads after exec() as all of them are terminated. > > > > Here is a code that handles it in an expanded way and fore 1 thread only. > That's fine, but if they're identical right now, you could still merge them > together, right? (A lot of the temporary things have a tendency to become > permanent). I will merge this. Even if this is temporary solution. Repository: rL LLVM https://reviews.llvm.org/D31450 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits