labath added inline comments.
================
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+ // Initialize new thread
+ struct ptrace_lwpinfo info = {};
+ Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
----------------
This is the third place i'm seeing this code. Any chance of turning it into a
function?
================
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:447
+ for (const auto &thread_sp : m_threads) {
+ static_pointer_cast<NativeThreadNetBSD>(thread_sp)->SetStepping();
+ }
----------------
I guess you should be playing with the pt_suspend/resume here to step only the
requested thread(s). Is that something you plan to do as a follow up?
Repository:
rL LLVM
https://reviews.llvm.org/D31450
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
