[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8b811bf800: [lldb/Core] Fix finite progress event reporting (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.l

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 442397. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1840-1841 return; -if (data->GetCompleted()) - m_current_event_id.reset(); } else { We should still reset the `m_current_event_id` here, otherwise we can get out of

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441195. mib marked an inline comment as done. mib added a comment. Refactor logging code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugge

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " +

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " + "(m_current_event_id

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441110. mib added a comment. Log only when verbose mode is enabled CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib added a comment. In D128768#3619349 , @JDevlieghere wrote: > The fix looks good but I'm torn about the added logging. On the one hand > it'll make finding issues like this easier in the future, but on the other > hand, while this code isn't "hot",

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added a comment. The fix looks good but I'm torn about the added logging. On the one hand it'll make finding issues like this easier in the future, but on the other hand, while this code isn't "hot", it is something where performance matters. My concern is that this will potentiall

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix event handling for finite progress reports. Previously, the event handler wo