mib marked an inline comment as done.
mib added inline comments.
================
Comment at: lldb/source/Core/Debugger.cpp:1839-1855
+ if (log && log->GetVerbose()) {
+ if (data->IsFinite())
+ LLDB_LOGF(log,
+ "%p Debugger('%llu')::HandleProgressEvent "
+ "(m_current_event_id = {%llu}, data = {id = %llu, message = "
+ "%s, completed = %llu, total = %llu})",
+ static_cast<void *>(this), m_uid, *m_current_event_id, id,
----------------
JDevlieghere wrote:
> What's `m_uid`?
>
> I would either fold these two log statements into one, and use
> `LLDB_LOGV(GetLog(LLDBLog::Events), ...` or I would use the event's dump
> method:
>
> ```
> if (log && log->GetVerbose()) {
> StreamString log_stream;
> log_stream << "Debugger::HandleProgressEvent" ...
> data->dump(log_stream);
> log->PutString(log_stream.GetString());
> }
> ```
Since some progress events can be broadcasted to a specific debugger instance,
`m_uid` tells use which debugger id is handling this
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128768/new/
https://reviews.llvm.org/D128768
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
