JDevlieghere added a comment. The fix looks good but I'm torn about the added logging. On the one hand it'll make finding issues like this easier in the future, but on the other hand, while this code isn't "hot", it is something where performance matters. My concern is that this will potentially cause progress events to get queued. If the progress updates aren't real time they are pretty much useless.
If it were up to me I'd probably remove the logging altogether, but maybe there's a middle ground where we have one log message that we only print in verbose mode? Then the (default) penalty is just checking if the log is enabled and verbose. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
