[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d35092cd258: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the… (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

Higuoxing updated this revision to Diff 292719. Higuoxing added a comment. In D87878#2281189 , @jhenderson wrote: > I might be missing it, but do you have direct testing showing that the > default for `IncludeDirs`\`Files`\`Opcodes` is an empty output, wh

[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, arphaman, hiraditya, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald adde

[Lldb-commits] [PATCH] D86857: [Test] Simplify DWARF test cases. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d01fc100bb5: [Test] Simplify DWARF test cases. NFC. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D86857: [Test] Simplify DWARF test cases. NFC.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added subscribers: llvm-commits, lldb-commits, cmtice, danielkiss. Herald added projects: LLDB, LLVM. Higuoxing requested review of

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5643dc3dce2: Recommit: [DWARFYAML] Add support for referencing different abbrev tables. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing requested review of this revision. Higuoxing added a comment. Hi @jhenderson This change is causing build failure on armv7 platform and I've fixed it. See: http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/10400 and http://lab.llvm.org:8011/builders/clang-cmake-a

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286987. Higuoxing added a comment. Add missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/include/llvm/ObjectYAML/DWARFYAML.h llvm/lib/Obje

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286985. Higuoxing added a comment. Fix incorrect format string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/include/llvm/ObjectYAML/DWARFYAML.h ll

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing reopened this revision. Higuoxing added a comment. This revision is now accepted and ready to land. This change is causing build failure, I'm going to revise this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://re

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ff0ace96db: [DWARFYAML] Add support for referencing different abbrev tables. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286945. Higuoxing added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/include/llvm/ObjectYAML/DWARFYAML.h llvm/lib/ObjectYAML/DWA

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:306-313 + Optional AbbrevTableIndex = + DS.getAbbrevTableIndexByID(AbbrevTableID); + if (!AbbrevTableIndex) +return createStringError(errc::invalid_argument, +

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286780. Higuoxing marked 11 inline comments as done. Higuoxing added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/includ

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing added inline comments. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml:426 #CHECK: Form:DW_FORM_ref4 + + I will remove this blank line later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing added inline comments. Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34 +private: + Data &DWARF; + std::map AbbrevID2Index; jhenderson wrote: > Higuoxing wrote: > > labath wrote: > > > jhenderson wrote: > > > > Would it make any sense to mer

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286755. Higuoxing marked 10 inline comments as done. Higuoxing added a comment. Merge `DWARFYAML::Data` and `DWARFYAML::DWARFState`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.ll

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing added a comment. Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34 +private: + Data &DWARF; + std::map AbbrevID2Index; labath wrote: > jhenderson wrote: > > Would it make any sense to merge the `DWARFYAML::Data` class and > > `DWARFYAML::

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added inline comments. Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:26-43 + DWARFYAML::AbbrevTable AbbrevTable; for (auto AbbrvDecl : AbbrvDeclSet.second) { DWARFYAML::Abbrev Abbrv; Abbrv.Code = AbbrvDecl.getCode(); Abbrv.Tag = A

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:259-265 + if (AbbrevTable.empty()) +return createStringError( +errc::invalid_argument, +"non-empty compilation unit should have an associated abbrev table"); + + ArrayRef Abbre

[Lldb-commits] [PATCH] D86194: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added a comment. Modified tests: test/tools/yaml2obj/ELF/debug-abbrev.yaml: Add one more abbrev table in test case (a). test/tools/yaml2obj/ELF/debug-info.yaml: Add test case (n). Test that yaml2obj emits an error message when a compilation unit has values but there is no associated

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a subscriber: jankratochvil. Higuoxing added a comment. CC @jankratochvil who might also have thoughts on this topic :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85289/new/ https://reviews.llvm.org/D85289 _

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a comment. In D85289#2196062 , @jhenderson wrote: > I see the point, but we don't do it for all fields in other contexts, and I > have some mild concerns that `DebugAbbrevOffset` is unnecessarily verbose > (I'd think `AbbrevOffset` would

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a comment. In D85289#2195954 , @jhenderson wrote: > What's the motivation for doing this? We should make these mapping keys' name consistent with the spec. The spec uses 'address_size', 'debug_abbrev_offset', 'abbreviation code' to refer

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, hiraditya, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added projects:

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92874d286695: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D840

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing marked an inline comment as done. Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:380-382 + cantFail(writeVariableSizedInteger(Unit.AbbrOffset, + Unit.Format == dwarf::DWARF64 ? 8 : 4, +

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:207-215 +static unsigned getOffsetSize(const DWARFYAML::Unit &Unit) { + return Unit.Format == dwarf::DWARF64 ? 8 : 4; +} - void onValue(const uint16_t U) override { -writeInteger(U, OS, Debu

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 280116. Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added inline comments. Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:743 +# RUN: llvm-readelf --hex-dump=.debug_info %t13.o | \ +# RUN: FileCheck %s --check-prefix=LENGTH + jhenderson wrote: > Should this be INFER-LENGTH? (The test is

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 280020. Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008 Files: lldb/unittes

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 279756. Higuoxing added a comment. Herald added subscribers: sstefan1, ormris, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jdoerfert. Address comments & Rebase & Add one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added a comment. In D84008#2161461 , @labath wrote: > In D84008#2161243 , @Higuoxing wrote: > > > In D84008#2160426 , @MaskRay wrote: > > > > > The number of change

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added a comment. In D84008#2160426 , @MaskRay wrote: > The number of changed tests is large. Is it worth moving the > `IO.mapOptional("Length", Unit.Length);` change to a separate patch to make > the refactoring more focused? Thanks This patc

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added a comment. I'll add some tests later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, hiraditya, mgorny. Herald added projects: LLDB, LLVM. This patch refactors `emitDebugInfo()` to make the length field be inferred from its content. Besides

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked an inline comment as done. Higuoxing added inline comments. Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:19 #include +#include jhenderson wrote: > I'm slightly surprised you needed to add this. Did this not compile without > it? I guess i

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added a comment. In D83116#2130019 , @labath wrote: > What would you say if, instead of `AbbrevTableIndex`, we had a field like > `AbbrevTableID`. The main difference would be that this "ID" field can be > explicitly specified on the Abbrev tab

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Newly added tests are marked by inline comments since too many tests are updated 😂. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:685 + +## c) Test that yaml2obj emits correct DWARF sections

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing added a comment. In D82622#2122562 , @uweigand wrote: > This commit causes test case failures on s390x (unfortunately hidden as the > build bot was already red due to an unrelated issue): > http://lab.llvm.org:8011/builders/clang-s390x-linux/bu

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe08ab542bd6: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing updated this revision to Diff 273632. Higuoxing marked 2 inline comments as done. Higuoxing added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82622/new/ https://reviews.llvm.org/D82622 Files: lldb/test/AP

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing marked an inline comment as done. Higuoxing added a comment. Thanks for reviewing! Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515 -#CHECK: DWARF: -#CHECK: debug_info: -#CHECK: - Length: -#CHECK: TotalLength:

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing updated this revision to Diff 273584. Higuoxing added a comment. Prettify test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82622/new/ https://reviews.llvm.org/D82622 Files: lldb/test/API/functionalities/source-map/a.yaml lld

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, hiraditya, aprantl, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added