Higuoxing added inline comments.
================ Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:259-265 + if (AbbrevTable.empty()) + return createStringError( + errc::invalid_argument, + "non-empty compilation unit should have an associated abbrev table"); + + ArrayRef<DWARFYAML::Abbrev> AbbrevDecls(AbbrevTable[0].Table); + ---------------- >>! Comments from [D83116](https://reviews.llvm.org/D83116#inline-795444) > @jhenderson : It might make more sense to do this work in the caller of this > function, and to maintain this function's interface. Some DIEs only have abbrev codes and do not have values. If we do this work in the caller of this function, yaml2obj will reject empty DIEs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86194/new/ https://reviews.llvm.org/D86194 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
