[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 Do we have bots which uses last supported compiler versions? GCC 7.1, Clang 5.0 and MSVC 16.7. It is bad to promise something and then breakages here and t

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

xbolva00 added a comment. Can you please add link to RFC to commit message? Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#3404624 , @xbolva00 wrote: > @mbenfield found false positive > > void test(void) { > static int counter = 0; > counter += 5; > } posted https://reviews.llvm.org/D122374 Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. Herald added subscribers: pcwang-thead, luke957. Herald added a project: All. @mbenfield found false positive void test(void) { static int counter = 0; counter += 5; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

xbolva00 added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/";, This url should redirect to github

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2798079 , @raj.khem wrote: > http://sprunge.us/FJzZXL is a file from harfbuzz and it warns > > a.cc:28670:32: error: variable 'supp_size' set but not used > [-Werror,-Wunused-but-set-variable] > unsigned int s

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2792854 , @Abpostelnicu wrote: > I think there is a false positive with this @george.burgess.iv: > In this >

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. >> Also fix a few places where this warning is correctly triggered. Create new patch please - dont mix fixes with new warning within one patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llv

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

xbolva00 added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.llvm.org/D84126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D71857: Fixes -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" NFC patch? Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

xbolva00 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:19 #endif +#ifdef __MINGW32__ +// usleep Maybe drop usleep and use C++’s https://en.cppreference.com/w/cpp/thread/sleep_for ? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

xbolva00 added inline comments. Comment at: Common/CMakeLists.txt:25 # TODO add support for ARM (NT) and ARM64 -# TODO build these unconditionally as we cannot do cross-debugging or WoW -if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64") - target_sources(lldbPluginProcessWindows

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

xbolva00 added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:163 + uint64_t length = data.GetU32(&offset); + bool isDwarf64 = false; + if (length == 0x) { variable is not used anywhere Repository: rL L

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. assert fix looks fine Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

xbolva00 added a comment. In our case (yes, we have some "additional dwarf", we are gonna fix it on our side), it crashed with "process launch -s". Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

xbolva00 added a comment. reproducer archive - 404 not found Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O"

xbolva00 added a comment. In https://reviews.llvm.org/D53010#1260956, @aprantl wrote: > Currently `v` is an alias for `version`. I'd wager that — compared to > printing a variable — LLDB user's almost never want to print LLDB's version. > Would it make sense to re-purpose the single-letter `v`

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

xbolva00 added inline comments. Comment at: source/Symbol/SymbolFile.cpp:160 + // guarantee correctness. + assert(std::async( + std::launch::async, lldbassert? https://reviews.llvm.org/D52543 ___ lldb

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. looks fine, thanks :) Repository: rLLDB LLDB https://reviews.llvm.org/D52561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

xbolva00 added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); xbolva00 wrote: >

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

xbolva00 added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); @jankratochvil is

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows with --no-stdio

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB342075: Do not create new terminals when launching process on Windows with --no-stdio (authored by xbolva00, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D51966 Files: source/H

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows with --no-stdio

xbolva00 updated this revision to Diff 165103. xbolva00 retitled this revision from "Do not create new terminals when launching process on Windows by default" to "Do not create new terminals when launching process on Windows with --no-stdio". xbolva00 edited the summary of this revision. https:/

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows by default

xbolva00 added a comment. So basically the hardest problem is to "find a way to get stdio from a process and feed to to LLDB so it shows up when neither --tty nor --no-stdio is set" .. Repository: rLLDB LLDB https://reviews.llvm.org/D51966 ___ l

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows by default

xbolva00 added a comment. In https://reviews.llvm.org/D51966#1231943, @clayborg wrote: > We should obey the --tty option here and set CREATE_NEW_CONSOLE if it is set > no? I also thought about it. @zturner, @labath ? Repository: rLLDB LLDB https://reviews.llvm.org/D51966 _

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows by default

xbolva00 abandoned this revision. xbolva00 added a comment. In https://reviews.llvm.org/D51966#1231533, @labath wrote: > I think the issue here is that on windows we don't have the ability(*) to > pipe stdio through lldb, so if you create a process without a console, you > will not be able to u

[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows by default

xbolva00 created this revision. xbolva00 added reviewers: teemperor, zturner. Herald added subscribers: lldb-commits, abidh. Unify behaviour across platforms. (We create new terminals only on Windows). process launch offers explicit option: -t ( --tty ) Start the process in a terminal (

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

This revision was automatically updated to reflect the committed changes. Closed by commit rL341746: Check if a terminal supports colors on Windows properly (authored by xbolva00, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51772?v

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB341746: Check if a terminal supports colors on Windows properly (authored by xbolva00, committed by ). Repository: rL LLVM https://reviews.llvm.org/D51772 Files: source/Core/Debugger.cpp source

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

xbolva00 created this revision. xbolva00 added reviewers: stella.stamenova, zturner. Herald added subscribers: lldb-commits, abidh. Previously we SetUseColor(true) wrongly when output was not a terminal so it broken some (not public) bots. Thanks for issue report, @stella.stamenova Repository:

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added a comment. In https://reviews.llvm.org/D51615#1226500, @stella.stamenova wrote: > In https://reviews.llvm.org/D51615#1226494, @xbolva00 wrote: > > > In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote: > > > > > In https://reviews.llvm.org/D51615#1226396, @xbolva00

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added a comment. In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote: > In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote: > > > Bot sure how to fix tests since this is somehow hard to problematic. > > > I think the fix for this is simply to not make the call to

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added a comment. Bot sure how to fix tests since this is somehow hard to problematic. Repository: rL LLVM https://reviews.llvm.org/D51615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL341497: Set Windows console mode to enable support for ansi escape codes (authored by xbolva00, committed by ). Herald add

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 updated this revision to Diff 164058. xbolva00 added a comment. - Check for _WIN32 https://reviews.llvm.org/D51615 Files: source/Core/Debugger.cpp Index: source/Core/Debugger.cpp === --- source/Core/Debugger.cpp +++ so

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 updated this revision to Diff 164057. https://reviews.llvm.org/D51615 Files: source/Core/Debugger.cpp Index: source/Core/Debugger.cpp === --- source/Core/Debugger.cpp +++ source/Core/Debugger.cpp @@ -50,14 +50,16 @@ #

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 updated this revision to Diff 164053. xbolva00 added a comment. - use llvm::sys::Process::UseANSIEscapeCodes https://reviews.llvm.org/D51615 Files: source/Core/Debugger.cpp Index: source/Core/Debugger.cpp === --- sourc

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added a comment. @teemperor please take a look again :) https://reviews.llvm.org/D51615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 updated this revision to Diff 163882. xbolva00 added a comment. - Updated https://reviews.llvm.org/D51615 Files: source/Core/Debugger.cpp Index: source/Core/Debugger.cpp === --- source/Core/Debugger.cpp +++ source/Core

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 planned changes to this revision. xbolva00 added a comment. I will reuse the accepted code which arrives with https://reviews.llvm.org/D51611 here also. https://reviews.llvm.org/D51615 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added a comment. In https://reviews.llvm.org/D51604#1223455, @clayborg wrote: > In https://reviews.llvm.org/D51604#1223451, @xbolva00 wrote: > > > Thanks for review, commited as https://reviews.llvm.org/rL341387 > > > If you include the text: > > Differential Revision: https://reviews.

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added a comment. Thanks for review, commited as https://reviews.llvm.org/rL341387 https://reviews.llvm.org/D51604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 updated this revision to Diff 163852. xbolva00 added a comment. - Use abort https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp === --- source/Utility/LLDBAssert.cp

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

xbolva00 added a comment. Ok, I messed up my LLDB svn a bit yesterday so probably I have found reason of that strange behavior. I will re-setup it locally. Thanks. Repository: rLLDB LLDB https://reviews.llvm.org/D51600 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

xbolva00 added a comment. In https://reviews.llvm.org/D51600#1223303, @clayborg wrote: > If you insert the text: > > Differential Revision: https://reviews.llvm.org/D51600 > > > Into your commit it will automatically show the SVN revision that was used > for the commit. Can you attach the SVN

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 updated this revision to Diff 163820. xbolva00 added a comment. - Addressed review comments https://reviews.llvm.org/D51615 Files: source/Core/Debugger.cpp Index: source/Core/Debugger.cpp === --- source/Core/Debugger.c

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 updated this revision to Diff 163818. xbolva00 added a comment. - Use early return https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp === --- source/Utility/LLDBAs

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added inline comments. Comment at: source/Core/Debugger.cpp:819 + consoleMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING; + SetUseColor(SetConsoleMode(hConsole, consoleMode)); +#endif Should I rewrite it to more clear version like bool ansi_supported = Set

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 added inline comments. Comment at: source/Utility/LLDBAssert.cpp:23 if (expression) ; else { JDevlieghere wrote: > I guess while we're at it we can turn this into an early return and use > LLVM_LIKELY? > > ``` > if (LLVM_LIKELY(expression))

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 added a comment. In https://reviews.llvm.org/D51615#1222730, @teemperor wrote: > Thanks! Didn't know we can activate this setting for the user. > > Some questions though: Should we restore this setting to the original value > after LLDB shuts down? Good question. I tried run lldb, qui

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

xbolva00 created this revision. xbolva00 added reviewers: JDevlieghere, teemperor. Herald added subscribers: lldb-commits, abidh. Windows console now supports supports ANSI escape codes, but we need to enable it using SetConsoleMode with ENABLE_VIRTUAL_TERMINAL_PROCESSING flag. https://docs.micr

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

xbolva00 created this revision. xbolva00 added reviewers: JDevlieghere, teemperor. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D51604 Files: source/Utility/LLDBAssert.cpp Index: source/Utility/LLDBAssert.cpp =

[Lldb-commits] [PATCH] D51601: [NFC] Use llvm_unreachable instead of lldb::assert

xbolva00 created this revision. xbolva00 added a reviewer: JDevlieghere. Herald added a subscriber: lldb-commits. Fixes implicit fall through warnings Repository: rLLDB LLDB https://reviews.llvm.org/D51601 Files: source/Host/common/Editline.cpp Index: source/Host/common/Editline.cpp

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

xbolva00 created this revision. xbolva00 added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh. /home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:656:59: warning: enum constant in boolean context [-Wint-in-bool-con

[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

xbolva00 updated this revision to Diff 163712. xbolva00 added a comment. - Added helper function https://reviews.llvm.org/D51591 Files: source/Host/common/PseudoTerminal.cpp Index: source/Host/common/PseudoTerminal.cpp === --- s

[Lldb-commits] [PATCH] D51591: [PseudoTerminal] Use llvm errno helpers

xbolva00 updated this revision to Diff 163706. xbolva00 added a comment. - Removed include errno.h https://reviews.llvm.org/D51591 Files: source/Host/common/PseudoTerminal.cpp Index: source/Host/common/PseudoTerminal.cpp === ---

[Lldb-commits] [PATCH] D51591: [PseudoTerminal] Use llvm errno helpers

xbolva00 updated this revision to Diff 163705. xbolva00 added a comment. - Moved variable into #if block https://reviews.llvm.org/D51591 Files: source/Host/common/PseudoTerminal.cpp Index: source/Host/common/PseudoTerminal.cpp =

[Lldb-commits] [PATCH] D51591: [PseudoTerminal] Use llvm errno helpers

xbolva00 created this revision. xbolva00 added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh. LLVM provide (str)errno helpers, so convert code to use it. Also fixes warning: /home/xbolva00/LLVM/llvm/tools/lldb/source/Host/common/PseudoTerminal.cpp:248:25: warning: ignor

[Lldb-commits] [PATCH] D51587: [Symtab][NFC] Added llvm_unreachable to supress compiler warning

xbolva00 added a comment. In https://reviews.llvm.org/D51587#1222009, @JDevlieghere wrote: > Looks reasonable. Did you run into this or is it just an improvement as you > came across the code? I just saw it as one of many GCC warnings when building lldb trunk. Repository: rLLDB LLDB https

[Lldb-commits] [PATCH] D51587: [Symtab][NFC] Added llvm_unreachable to supress compiler warning

xbolva00 created this revision. xbolva00 added a reviewer: JDevlieghere. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D51587 Files: source/Symbol/Symtab.cpp Index: source/Symbol/Symtab.cpp =