xbolva00 added a comment. In https://reviews.llvm.org/D51615#1226500, @stella.stamenova wrote:
> In https://reviews.llvm.org/D51615#1226494, @xbolva00 wrote: > > > In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote: > > > > > In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote: > > > > > > > Bot sure how to fix tests since this is somehow hard to problematic. > > > > > > > > > I think the fix for this is simply to not make the call to SetUseColor > > > here. Is there a reason for the call? It looks like the check for "dumb" > > > terminal and "GetIsTerminalWithColors" might have to come after setting > > > the ANSI escape codes if setting the codes impacts those two cases. > > > > > > We may disable "use color" setting thanks to GetIsTerminalWithColors but > > then we realize that we can "enable it" via SetConsoleMode for newer Win > > 10, so we need to call it I think. The reverse order does not help us > > either.. I think. > > > Sounds like GetIsTerminalWithColors might have to be updated to include the > new logic as well. Would you rather commit a fix or revert the change and > then commit a new one? I can try to fix tomorrow with a new patch :) Repository: rL LLVM https://reviews.llvm.org/D51615 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
