Author: Bruce Mitchener
Date: 2021-06-05T15:50:49+07:00
New Revision: 2606918f467519f1634a67ee386211e99665fd23
URL:
https://github.com/llvm/llvm-project/commit/2606918f467519f1634a67ee386211e99665fd23
DIFF:
https://github.com/llvm/llvm-project/commit/2606918f467519f1634a67ee386211e99665fd23.dif
Author: Bruce Mitchener
Date: 2021-06-05T13:42:18+07:00
New Revision: 8d33437d030af27fff21dd3fd0e66893b0148217
URL:
https://github.com/llvm/llvm-project/commit/8d33437d030af27fff21dd3fd0e66893b0148217
DIFF:
https://github.com/llvm/llvm-project/commit/8d33437d030af27fff21dd3fd0e66893b0148217.dif
Author: Bruce Mitchener
Date: 2021-06-02T11:35:11+07:00
New Revision: 251a5d9d5239c0402e0ab68718aa194c2b4f04bb
URL:
https://github.com/llvm/llvm-project/commit/251a5d9d5239c0402e0ab68718aa194c2b4f04bb
DIFF:
https://github.com/llvm/llvm-project/commit/251a5d9d5239c0402e0ab68718aa194c2b4f04bb.dif
Author: Bruce Mitchener
Date: 2021-05-31T06:48:57+07:00
New Revision: 36597e4719e9de6d374f7953aad83234d42ca181
URL:
https://github.com/llvm/llvm-project/commit/36597e4719e9de6d374f7953aad83234d42ca181
DIFF:
https://github.com/llvm/llvm-project/commit/36597e4719e9de6d374f7953aad83234d42ca181.dif
Author: brucem
Date: Mon Nov 26 21:37:27 2018
New Revision: 347637
URL: http://llvm.org/viewvc/llvm-project?rev=347637&view=rev
Log:
Add support for the Dylan language to ClangASTContext
Summary:
This change adds eLanguageTypeDylan to the set of languages supported
by ClangASTContext. Debug info
Author: brucem
Date: Thu Oct 4 15:33:39 2018
New Revision: 343825
URL: http://llvm.org/viewvc/llvm-project?rev=343825&view=rev
Log:
Fix typos.
Reviewers: lldb-commits
Subscribers: srhines, ki.stfu
Differential Revision: https://reviews.llvm.org/D52884
Modified:
lldb/trunk/include/lldb/Uti
Author: brucem
Date: Tue May 29 02:14:40 2018
New Revision: 333400
URL: http://llvm.org/viewvc/llvm-project?rev=333400&view=rev
Log:
Remove Linux-specific includes for posix/FileSystem.cpp
Summary:
This improves the process of cross-compiling from macOS to Linux
since these files aren't used / ne
Author: brucem
Date: Tue May 29 02:10:46 2018
New Revision: 99
URL: http://llvm.org/viewvc/llvm-project?rev=99&view=rev
Log:
Typo fixes.
Reviewers: javed.absar
Subscribers: ki.stfu, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D47421
Modified:
lldb/tru
Author: brucem
Date: Mon Aug 21 15:54:49 2017
New Revision: 311399
URL: http://llvm.org/viewvc/llvm-project?rev=311399&view=rev
Log:
lldb-argdumper doesn't need lldbCore.
Summary: lldb-argdumper only needs lldbUtility to successfully build and link.
Reviewers: beanz, zturner, labath
Subscribers
Author: brucem
Date: Fri Jul 21 00:08:20 2017
New Revision: 308716
URL: http://llvm.org/viewvc/llvm-project?rev=308716&view=rev
Log:
Fix typo in error message in 'platform status'.
Modified:
lldb/trunk/source/Commands/CommandObjectPlatform.cpp
Modified: lldb/trunk/source/Commands/CommandObje
Author: brucem
Date: Wed Jul 19 07:31:19 2017
New Revision: 308480
URL: http://llvm.org/viewvc/llvm-project?rev=308480&view=rev
Log:
Expose hit count via SBBreakpointLocation.
Summary:
SBBreakpointLocation exposed the ignore count, but didn't expose
the hit count. Both values were exposed by SBBr
Author: brucem
Date: Wed Jul 19 02:35:58 2017
New Revision: 308426
URL: http://llvm.org/viewvc/llvm-project?rev=308426&view=rev
Log:
Fix typos in documentation.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31282
Modified:
lldb/trunk/scr
Author: brucem
Date: Wed Jul 19 02:30:04 2017
New Revision: 308425
URL: http://llvm.org/viewvc/llvm-project?rev=308425&view=rev
Log:
Update API headers.
Summary:
* Provide API doc for SBProcess::SaveCore.
* Fix typo in SBAttachInfo doc comments.
* SBBreakpointList: Name some variables same as C++
Author: brucem
Date: Thu Mar 23 04:52:26 2017
New Revision: 298585
URL: http://llvm.org/viewvc/llvm-project?rev=298585&view=rev
Log:
Fix warnings from clang build on macOS.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31279
Modified:
ll
brucem added a subscriber: brucem.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHE
Stepping one step back further in the thread ...
On Wed, Nov 18, 2015 at 8:35 AM, Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Moving this back over to the list since I'm sure others have some input
> here. Also +lldb-dev since it has more visibility than lldb-commits.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253153: Add more autotools/gmake NetBSD glue (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D14531?vs=39789&id=40222#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14531
F
Author: brucem
Date: Sat Nov 14 20:00:09 2015
New Revision: 253153
URL: http://llvm.org/viewvc/llvm-project?rev=253153&view=rev
Log:
Add more autotools/gmake NetBSD glue
Summary: This diff approaches building the project natively on NetBSD with the
autoconf/gmake framework.
Patch by Kamil Rytar
Author: brucem
Date: Sat Nov 14 19:56:21 2015
New Revision: 253152
URL: http://llvm.org/viewvc/llvm-project?rev=253152&view=rev
Log:
Allow to override python-config executable name from command line
Summary: pkgsrc (on NetBSD) ships with python2.7-config.
Patch by Kamil Rytarowski. Thanks!
Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253152: Allow to override python-config executable name from
command line (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14528?vs=39786&id=40221#toc
Repository:
rL LLVM
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253151: Use library discovery for curses and panel (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14529?vs=39787&id=40220#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14
Author: brucem
Date: Sat Nov 14 19:53:23 2015
New Revision: 253151
URL: http://llvm.org/viewvc/llvm-project?rev=253151&view=rev
Log:
Use library discovery for curses and panel
Summary:
This approach is tunable with custom paths for curses library.
It also detects whether there are requirements m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252403: Add more NetBSD platform glue for lldb (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D14042?vs=39639&id=39640#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14042
Author: brucem
Date: Sat Nov 7 09:31:54 2015
New Revision: 252403
URL: http://llvm.org/viewvc/llvm-project?rev=252403&view=rev
Log:
Add more NetBSD platform glue for lldb
Summary:
These changes are still incomplete, but we are almost there.
Changes:
- CMake and gmake code
- SWIG code
- minor c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252396: Make lldb::endian::InlHostByteOrder() private.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14417?vs=39473&id=39630#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: brucem
Date: Fri Nov 6 22:40:13 2015
New Revision: 252396
URL: http://llvm.org/viewvc/llvm-project?rev=252396&view=rev
Log:
Make lldb::endian::InlHostByteOrder() private.
Summary:
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since
brucem added a comment.
Kamil, please rebase forward and I'll land it.
The semicolons in Python are gone now. And so is the need for that block of
Python at all.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252330: [swig] Remove
check_lldb_swig_executable_file_exists. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14415?vs=39558&id=39562#toc
Repository:
rL LLVM
http://reviews.l
Author: brucem
Date: Fri Nov 6 12:53:29 2015
New Revision: 252330
URL: http://llvm.org/viewvc/llvm-project?rev=252330&view=rev
Log:
[swig] Remove check_lldb_swig_executable_file_exists.
Summary:
Code that tried to find swig and then split the path into
a separate path and filename is being remov
brucem updated this revision to Diff 39558.
brucem added a comment.
Instead of simplifying, just remove. Expand scope of removal as well.
http://reviews.llvm.org/D14415
Files:
scripts/Python/buildSwigPython.py
scripts/buildSwigWrapperClasses.py
Index: scripts/buildSwigWrapperClasses.py
===
brucem added a comment.
Well, I'm pretty sure ... but I don't know if someone in some configuration or
set of build arrangements might use it. It might also be used if we ever make
the Makefiles or xcode projects use these scripts.
http://reviews.llvm.org/D14415
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this resu
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
pla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252250: Reuse native curses(8) library on NetBSD (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14037?vs=39440&id=39444#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1403
Author: brucem
Date: Thu Nov 5 18:21:18 2015
New Revision: 252250
URL: http://llvm.org/viewvc/llvm-project?rev=252250&view=rev
Log:
Reuse native curses(8) library on NetBSD
Summary:
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with and linkage fr
Author: brucem
Date: Thu Nov 5 17:48:41 2015
New Revision: 252238
URL: http://llvm.org/viewvc/llvm-project?rev=252238&view=rev
Log:
Fix cmake build on Mac OS X.
PlatformDarwin uses Host/XML.h which needs to find libxml2, and
so it needs to be told how to find the headers.
Modified:
lldb/tru
brucem added inline comments.
Comment at: scripts/Python/buildSwigPython.py:293
@@ +292,3 @@
+# LLDBWrapPython.cpp file.
+# Args:vDictArg - (R) Program input parameters.
+# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file.
I shouldn't hav
brucem added a comment.
Even if it were, in some of the files, almost every line would change anyway
due to semicolons and then due to incorrect whitespace.
http://reviews.llvm.org/D14375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
brucem added a reviewer: emaste.
brucem added a comment.
emaste, are you okay with this and willing to approve it?
It looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a reviewer: clayborg.
brucem added a comment.
I'd like to land this given approval.
Repository:
rL LLVM
http://reviews.llvm.org/D14037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
brucem added a comment.
This looks reasonable to me as well, but I also have never built standalone.
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33
@@ -32,3 +32,3 @@
{
-#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__)
+#if (defin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251171: Add initial gmake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13715?vs=37957&id=38289#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: brucem
Date: Fri Oct 23 20:28:24 2015
New Revision: 251171
URL: http://llvm.org/viewvc/llvm-project?rev=251171&view=rev
Log:
Add initial gmake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the autotools target, but
it's significantly approaching
Author: brucem
Date: Fri Oct 23 19:30:18 2015
New Revision: 251166
URL: http://llvm.org/viewvc/llvm-project?rev=251166&view=rev
Log:
[lldb-mi] Fix unused variable warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251164: Add initial CMake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13711?vs=37300&id=38286#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: brucem
Date: Fri Oct 23 19:27:04 2015
New Revision: 251164
URL: http://llvm.org/viewvc/llvm-project?rev=251164&view=rev
Log:
Add initial CMake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the CMake target, but it's
significantly approaching it.
brucem added a comment.
+1 to what @labath said.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a comment.
It might be worthwhile to have a "janitor" where we can not enable things like
this so that it is more clear that this is something we'd like to clean up over
time.
It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND
CXX_SUPPORTS_NO_STRICT_ALIASING)` c
brucem added a subscriber: brucem.
brucem added a comment.
You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.)
I think the minimum supported cmake is actually older then 3.0 (2.8.something)
...
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
brucem added a comment.
I think this looks good to me if no one disagrees.
Repository:
rL LLVM
http://reviews.llvm.org/D13715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: lib/Makefile:146
@@ -144,1 +145,3 @@
+ifneq ($(HOST_OS),NetBSD)
+ USEDLIBS += lldbPluginProcessPOSIX.a
-
brucem added a subscriber: brucem.
brucem accepted this revision.
brucem added a reviewer: brucem.
brucem added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13667
___
lldb-commits mailing list
lldb-commit
brucem added a subscriber: brucem.
brucem added a comment.
Hopefully some helpful comments that will help keep this code in line with
changes that we're making to other parts of the codebase in bulk ...
Comment at: include/lldb/Symbol/GoASTContext.h:394
@@ +393,3 @@
+}
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250249: Remove definition of ~PlatformNetBSD(), since its
declaration is marked as '=… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13707?vs=37284&id=37298#toc
Repository:
Author: brucem
Date: Tue Oct 13 18:22:40 2015
New Revision: 250249
URL: http://llvm.org/viewvc/llvm-project?rev=250249&view=rev
Log:
Remove definition of ~PlatformNetBSD(), since its declaration is marked as '=
default'
Summary: Local definition of ~PlatformNetBSD() results with a compiler error
brucem added a subscriber: brucem.
brucem accepted this revision.
brucem added a reviewer: brucem.
brucem added a comment.
This revision is now accepted and ready to land.
lgtm.
will land shortly for you.
Repository:
rL LLVM
http://reviews.llvm.org/D13707
_
brucem added a subscriber: brucem.
brucem added a comment.
I don't know much about this, but would it make sense for this to be using any
of the Value / SBValue and data formatter infrastructure?
Repository:
rL LLVM
http://reviews.llvm.org/D13699
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250146: Preliminary NetBSD support (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13334?vs=37077&id=37214#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13334
Files:
lld
Author: brucem
Date: Tue Oct 13 00:04:13 2015
New Revision: 250146
URL: http://llvm.org/viewvc/llvm-project?rev=250146&view=rev
Log:
Preliminary NetBSD support
Summary:
This adds platform code without the cmake/gmake glue to the existing
infrastructure.
The missing and incompatibility ptrace(2)
brucem added a comment.
My plan is to land this in about 16 hours unless I hear otherwise. (@labath,
@tfiala, @emaste)
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249928: [LLDB] Fix Clang-tidy misc-use-override warnings in
some files in… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13574?vs=36894&id=37014#toc
Repository:
rL LLVM
ht
Author: brucem
Date: Fri Oct 9 20:11:45 2015
New Revision: 249928
URL: http://llvm.org/viewvc/llvm-project?rev=249928&view=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in some files in
include/lldb/Core; other minor fixes.
Summary:
This is second attempt based on current code.
I
Author: brucem
Date: Fri Oct 9 19:45:34 2015
New Revision: 249924
URL: http://llvm.org/viewvc/llvm-project?rev=249924&view=rev
Log:
Fix namespace closing comment.
This is closing namespace lldb_utility, not lldb.
Modified:
lldb/trunk/include/lldb/Utility/PseudoTerminal.h
Modified: lldb/tru
Author: brucem
Date: Fri Oct 9 12:51:19 2015
New Revision: 249860
URL: http://llvm.org/viewvc/llvm-project?rev=249860&view=rev
Log:
[debugserver,cmake] Add DEPENDS to custom commands.
Summary:
Add dependencies to the custom commands so that they get
re-executed as needed.
Reviewers: clayborg
S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249860: [debugserver,cmake] Add DEPENDS to custom commands.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13580?vs=36925&id=36965#toc
Repository:
rL LLVM
http://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249840: Remove long-forgotten plugin virtuals. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D13581?vs=36926&id=36954#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13581
Author: brucem
Date: Fri Oct 9 10:37:10 2015
New Revision: 249840
URL: http://llvm.org/viewvc/llvm-project?rev=249840&view=rev
Log:
Remove long-forgotten plugin virtuals.
Summary:
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove th
brucem added a subscriber: brucem.
brucem added a comment.
Unless someone else (@emaste?) objects, I think this looks fine to land and
iterate on trunk as discussed in the mailing list thread. Just one minor
comment based on cleanups that are on-going on trunk now.
Comment at
brucem created this revision.
brucem added reviewers: clayborg, labath, emaste.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and PO
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Add dependencies to the custom commands so that they get
re-executed as needed.
http://reviews.llvm.org/D13580
Files:
tools/debugserver/source/MacOSX/CMakeLists.txt
Index: tools/debugserv
brucem added a subscriber: brucem.
brucem added a comment.
Getting rid of a lot of the `#ifndef LLDB_DISABLE_PYTHON` checks had been on my
list of things I wanted to clean up. Since you regularly build with this
configuration (and I never do), I suspect that a lot more of those checks could
go
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249806: Fix handling of LLDB_VERS_GENERATED_FILE. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13552?vs=36851&id=36923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D135
Author: brucem
Date: Thu Oct 8 22:40:55 2015
New Revision: 249806
URL: http://llvm.org/viewvc/llvm-project?rev=249806&view=rev
Log:
Fix handling of LLDB_VERS_GENERATED_FILE.
Summary:
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything t
brucem added a comment.
I'd like to hear from @clayborg about the whitespace changes here.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
brucem added a comment.
Both builds from clean and incremental have now succeeded for me with this
patch.
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
brucem added a comment.
I have a full build from clean going with this. I'm pretty sure that it will be
fine.
I'll check this into SVN after I wake up if someone agrees that it looks good.
http://reviews.llvm.org/D13552
___
lldb-commits mailing li
brucem added a comment.
I did NOT test this with a full rebuild as it is nearly my bedtime. I did test
it with an incremental build as well as rm'ing the generated file and touching
the (new) dependencies to make sure that the vers file got regenerated.
http://reviews.llvm.org/D13552
__
brucem created this revision.
brucem added reviewers: dawn, sas, clayborg, zturner.
brucem added a subscriber: lldb-commits.
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have th
brucem added a comment.
I don't know what's broken for you. My build hasn't had any issues on Mac OS X
using cmake.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
brucem added a comment.
The way to do this correctly is something like
ADD_CUSTOM_COMMAND(
OUTPUT whatever.output.file.c
COMMAND ... whatever ...
DEPENDS ... whatever ...
)
ADD_CUSTOM_TARGET(whatever-target-name
ALL
DEPENDS whatever.output
brucem added a comment.
I think what needs to happen is that you take the `add_custom_command` and then
create a target that will execute the command and only do it once ... I'll
provide an example from something else shortly.
(I was about to request changes here when you committed it and close
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2108
@@ -2107,1 +2107,3 @@
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Same issue here with whitespace and needing to be rebased forward.
Repository:
rL LLVM
http://reviews.llvm.org/D12257
___
lldb-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249671: Make CMake display more readable paths to Python
binaries on Windows (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13520?vs=36764&id=36832#toc
Repository:
rL LLVM
h
Author: brucem
Date: Thu Oct 8 03:50:20 2015
New Revision: 249671
URL: http://llvm.org/viewvc/llvm-project?rev=249671&view=rev
Log:
Make CMake display more readable paths to Python binaries on Windows
Summary:
Previously CMake would display messages like these:
```
-- LLDB Found PythonExecutabl
brucem added a subscriber: brucem.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
Why is this needed?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This also has the whitespace changes and needs rebasing forward. (And a
question for someone about the nature of one of the changes.)
Comment at: source/Plugins/ABI
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
There are a number of places where you've changed spaces to tabs ... Also the
GetShortPluginName has already been removed. Please rebase forward and correct
the whitespace issues.
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This doesn't currently apply. (Probably true of your others as well.) Please
update.
Repository:
rL LLVM
http://reviews.llvm.org/D12606
___
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Could you rebase this forward so that it applies cleanly?
Repository:
rL LLVM
http://reviews.llvm.org/D12611
___
lldb-commits mailin
brucem accepted this revision.
brucem added a comment.
This revision is now accepted and ready to land.
I can land this for you. I'd like it to go in as I have another patch myself
that addresses almost all of the Plugins directory, so if I land this, I'll
rebase on top of it and submit mine for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249570: Reduce header inclusion in Expression. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D1?vs=36760&id=36762#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: brucem
Date: Wed Oct 7 12:22:54 2015
New Revision: 249570
URL: http://llvm.org/viewvc/llvm-project?rev=249570&view=rev
Log:
Reduce header inclusion in Expression.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D1
Modified:
lldb/trunk
brucem updated this revision to Diff 36760.
brucem added a comment.
Rebase forward.
http://reviews.llvm.org/D1
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/ExpressionVariable.h
include/lldb/Expression/FunctionCaller.h
include/lldb/Expression/IRInterprete
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249563: Remove unused virtuals from ABISysV_ppc* (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13506?vs=36726&id=36753#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1350
Author: brucem
Date: Wed Oct 7 11:48:33 2015
New Revision: 249563
URL: http://llvm.org/viewvc/llvm-project?rev=249563&view=rev
Log:
Remove unused virtuals from ABISysV_ppc*
Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by any
brucem added a comment.
There's nothing to test here short of "Does it compile?" as these functions
aren't actually used anywhere. I'm cleaning out dead virtuals in various
patches.
http://reviews.llvm.org/D13506
___
lldb-commits mailing list
lldb
brucem marked 2 inline comments as done.
brucem added a comment.
http://reviews.llvm.org/D13503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem created this revision.
brucem added reviewers: clayborg, jingham, jhibbits, emaste.
brucem added a subscriber: lldb-commits.
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* c
1 - 100 of 265 matches
Mail list logo
