brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed.
This also has the whitespace changes and needs rebasing forward. (And a question for someone about the nature of one of the changes.) ================ Comment at: source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h:25 @@ -24,3 +24,3 @@ public: - ~ABIMacOSX_arm64() { } + ~ABIMacOSX_arm64() override = default; ---------------- @clayborg et al: Is this sort of change desired? (I lost track of whether or not these 2 constructs are the same in modern C++.) Repository: rL LLVM http://reviews.llvm.org/D12220 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits