Author: brucem Date: Wed Oct 7 11:48:33 2015 New Revision: 249563 URL: http://llvm.org/viewvc/llvm-project?rev=249563&view=rev Log: Remove unused virtuals from ABISysV_ppc*
Summary: The StackUsesFrames and FunctionCallsChangeCFA virtual functions aren't used anywhere and aren't overridden by anything. They were introduced when the ABISysV_ppc* code was added and weren't used at the time. The review for the commit that added them can be found at http://reviews.llvm.org/D5988 The commit comment notes that backtraces don't yet work: Backtraces don't work. This is due to PowerPC ABI using a backchain pointer in memory, instead of a dedicated frame pointer register for the backchain. So there is a possibility these were added with the intent of using them in the future. Reviewers: clayborg, jingham, jhibbits, emaste Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D13506 Modified: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h Modified: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h?rev=249563&r1=249562&r2=249563&view=diff ============================================================================== --- lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h (original) +++ lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h Wed Oct 7 11:48:33 2015 @@ -62,12 +62,6 @@ public: virtual bool RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); - virtual bool - StackUsesFrames () - { - return true; - } - // The SysV ppc ABI requires that stack frames be 16 byte aligned. // When there is a trap handler on the stack, e.g. _sigtramp in userland // code, we've seen that the stack pointer is often not aligned properly @@ -97,12 +91,6 @@ public: return true; } - virtual bool - FunctionCallsChangeCFA () - { - return true; - } - virtual const lldb_private::RegisterInfo * GetRegisterInfoArray (uint32_t &count); //------------------------------------------------------------------ Modified: lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h?rev=249563&r1=249562&r2=249563&view=diff ============================================================================== --- lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h (original) +++ lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h Wed Oct 7 11:48:33 2015 @@ -62,12 +62,6 @@ public: virtual bool RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); - virtual bool - StackUsesFrames () - { - return true; - } - // The SysV ppc64 ABI requires that stack frames be 16 byte aligned. // When there is a trap handler on the stack, e.g. _sigtramp in userland // code, we've seen that the stack pointer is often not aligned properly @@ -97,12 +91,6 @@ public: return true; } - virtual bool - FunctionCallsChangeCFA () - { - return true; - } - virtual const lldb_private::RegisterInfo * GetRegisterInfoArray (uint32_t &count); //------------------------------------------------------------------ _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
