[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

This revision was automatically updated to reflect the committed changes. Closed by commit rGd557384b43d3: [LLDB] Fix for D139955 Summary: (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507855. ayermolo added a comment. fixed up refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp l

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added a comment. In D146659#4217557 , @clayborg wrote: > Must be relocations causing the stuff to not match up to the llvm-dwarfdump > output. Looked through llvm-dwarfdump code. Yep. since relocation exists, it just returns an addend which is

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CHECK-SAME: which has a base that is less than the function's low PC 0x0021. +# CHE

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507812. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ll

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507528. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ll

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507526. ayermolo added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing a small typo. Repository: rG LLVM Github Monorepo https://revie

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4145804 , @mib wrote: > In D138618#4145644 , @ayermolo > wrote: > >> https://green.lab.llvm.org/green/job/lldb-cmake/51484/ passed. >> There were other built bots failures, bu

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. https://green.lab.llvm.org/green/job/lldb-cmake/51484/ passed. There were other built bots failures, but looks like it was built failure related to other diff that was part of testing. Since I only changed things on mac side, and previously other built bots passed, fing

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

This revision was automatically updated to reflect the committed changes. Closed by commit rG34a8e6eee666: [LLDB] Enable 64 bit debug/type offset (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 499601. ayermolo added a comment. removed two more asserts. It made one of the tests fail as "Unresolved". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: l

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 499365. ayermolo added a comment. Fixed logic for DwarfMap, also removed an assert in AppleDWARFIndex::GetGlobalVariables. Before when it would invoke GetDwoNum it will go to a virtual API that alays returned nullopt. The ID was handled through GetOSOIndexF

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4133717 , @mib wrote: > Hi @ayermolo! > > This patch is causing some failure on the macOS lldb bot: > https://green.lab.llvm.org/green/job/lldb-cmake/51257/ > > Could you take a look ? If you don't have the time, we c

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4133717 , @mib wrote: > Hi @ayermolo! > > This patch is causing some failure on the macOS lldb bot: > https://green.lab.llvm.org/green/job/lldb-cmake/51257/ > > Could you take a look ? If you don't have the time, we c

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

This revision was automatically updated to reflect the committed changes. Closed by commit rG2062e90aa531: [LLDB] Enable 64 bit debug/type offset (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. OK, managed to setup windows VM, and couldn't repro. After reverting my fix for cross-projects tests locally, I saw test failures. Will try to push again and see if it triggers bot build failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497468. ayermolo added a comment. small clenaup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/include/lldb/Symbol/DW

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497467. ayermolo added a comment. fixed cross-project tests, and also normal test that I somehow missed. Need to get access to windows machine to figure out why that fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo reopened this revision. ayermolo added a comment. This revision is now accepted and ready to land. Had to revert, broke some build bots. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

This revision was automatically updated to reflect the committed changes. Closed by commit rGf36fe009c0fc: [LLDB] Enable 64 bit debug/type offset (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:402 DWARFUnit &unit, llvm::function_ref callback) { - lldbassert(!unit.GetSymbolFileDWARF().GetDwoNum()); + lldbassert(!unit.GetSymbolFileDWARF().GetFileIndex()); Index

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497064. ayermolo marked an inline comment as done. ayermolo added a comment. Added asserts back in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/incl

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 495952. ayermolo marked 2 inline comments as done. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo marked 16 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 enum Section : uint8_t { DebugInfo, DebugTypes }; - - DIERef(std::optional dwo_num, Section section, + // Making constructors protected to

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 495582. ayermolo added a comment. Implemented Gregs suggestion. Also consolidated three diffs back into one. To make it clear the scope of changes, and for ease of testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4102275 , @labath wrote: > In D138618#4094933 , @clayborg > wrote: > >>> - My main source of frustration was that my concern is getting >>> overlooked/ignored (not necessaril

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4086789 , @labath wrote: > I'm sorry, but that patch does not fix the problem I am trying to point out. > In fact, I think it makes things a lot worse. > > We clearly have some kind of a communication problem, but I a

[Lldb-commits] [PATCH] D142779: [LLDB][DRAFT] Add 64bit support to LLDB

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[Lldb-commits] [PATCH] D142775: [LLDB] Remove GetUID API

ayermolo updated this revision to Diff 492848. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142775/new/ https://reviews.llvm.org/D142775 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. Created commit that removes getUID(...) https://reviews.llvm.org/D142775 Seems like it's isolated to SymbolFile and DWARF code. So now userid goes through DIERef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ h

[Lldb-commits] [PATCH] D142775: [LLDB] Remove GetUID API

ayermolo created this revision. Herald added a reviewer: shafik. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Removed the GetUID API to make it explicit

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo updated this revision to Diff 492842. ayermolo marked an inline comment as done. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files: lldb/source/

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 492841. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/include/lldb/Symb

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo marked an inline comment as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4073329 , @labath wrote: > In D138618#4060565 , @clayborg > wrote: > >> ... >> Since the user IDs of SymbolFileDWARF plug-ins mean nothing to anyone else, >> we can make them

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo updated this revision to Diff 491009. ayermolo added a comment. Updated based on Gregs suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files: lldb/source/Plugins/SymbolFile/DWARF/DI

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 491008. ayermolo added a comment. updated based on Gregs suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/in

[Lldb-commits] [PATCH] D141624: [fix] Change formatting to use llvm::formatv Summary:

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7da8000e27: [fix] Change formatting to use llvm::formatv Summary: (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141624/new/ https:

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. Found another instance: https://reviews.llvm.org/D141624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D141624: [fix] Change formatting to use llvm::formatv Summary:

ayermolo created this revision. Herald added a reviewer: shafik. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Missed one formating that was reversed.

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#4047011 , @Michael137 wrote: > Ah it's just a typoed format (and lack of curly braces around one of the > format specifiers) > > Fixed in https://reviews.llvm.org/rGade3f1ccd807 Thanks, for a fix. Sorry missed it.

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7fc79340234f: [llvm][dwwarf] Change CU/TU index to 64-bit (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 488393. ayermolo added a comment. Trying a fix for arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARF

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. https://reviews.llvm.org/D141504 TBH not 100% sure on the fix, but looking where it's failing, maybe it's some kind of interaction with APIs returning 64bit number, and 32bit format macros on ARM? I don't have access to ARM machine. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. In D139379#4043492 , @RKSimon wrote: > @ayermolo This has broken some buildbots - please can you take a look? > https://lab.llvm.org/buildbot/#/builders/245/builds/3279 ok Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3fa4d0d423: [llvm][dwwarf] Change CU/TU index to 64-bit (authored by ayermolo). Changed prior to commit: https://reviews.llvm.org/D139379?vs=485160&id=487881#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Awesome, thank you for reviewing, I appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. Thanks for reviewing, really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe262b8f48af9: [LLDB] Change formatting to use llvm::formatv (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 487512. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Utility/Status.

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie If getter/setter APIs are a blocker, I can remove them and do casts (uint32_t) instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 486719. ayermolo added a comment. removed + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Utility/Stat

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie Happy New Year! Penny for your thoughts on this patch? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits m

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. @labath ping. Is there anything else I need to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 485160. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. In D139379#4015569 , @dblaikie wrote: > In D139379#3972876 , @ayermolo > wrote: > >> In D139379#3972871 , @dblaikie >> wrote: >> >>> Perhaps th

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 485156. ayermolo added a comment. Removed generic setters for Index, and changed back to variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added inline comments. Comment at: lldb/include/lldb/Utility/Status.h:65 + template + explicit Status(const char *format, Args &&...args) { +SetErrorToGenericError(); labath wrote: > I don't think you've converted all the callers of this one. Give

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484920. ayermolo marked 11 inline comments as done. ayermolo added a comment. addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/inclu

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484382. ayermolo added a comment. missed couple of Status uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h lldb/inclu

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4004866 , @labath wrote: > You, if I understand correctly, see the ID of a symbol file as a special case > of an all-encompassing user id -- essentially a user_id (or a DIERef) > pointing to the first byte of the sym

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484261. ayermolo added a comment. removed include that snuck in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h lldb/incl

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484259. ayermolo added a comment. Herald added subscribers: MaskRay, emaste. pulled a trigger and changed all the call sites. I think less confusing then having two sets of APIs. One with printf symantics another with formatv. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:11-58 +#include "AppleDWARFIndex.h" +#include "DWARFASTParser.h" +#include "DWARFASTParserClang.h" +#include "DWARFCompileUnit.h" +#incl

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3999154 , @labath wrote: > Thanks for splitting this up. We still need to figure out what to do with the > first patch, but these two are looking very good now. > > At least, in the sense that one can clearly see what

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#3999521 , @labath wrote: > In D139955#3999381 , @ayermolo > wrote: > >> I tried to modify all the places wehre getOffset() is used. Which will later >> return 64bit instead o

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. I tried to modify all the places wehre getOffset() is used. Which will later return 64bit instead of 32 bit. Sorry I guess there was miss communication. I am not quite clear in what you are suggesting. The way I did it we now have two distinct interfaces. One for old wa

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#3992766 , @JDevlieghere wrote: > I don't really understand the motivation. Can you elaborate on why "enabling > 64 bit support" requires this change? I definitely prefer the `formatv` > approach, but wouldn't the PR

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following example of DWO changing it to use DIERef. Depends on D138618

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 482550. ayermolo added a comment. Herald added a subscriber: Michael137. Separated format patch, and oso patch. Although without OSO changes a lot of tests fail on mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei, arphaman. Herald added a reviewer: shafik. Herald added a project: All. ayermolo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a pro

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie ping? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo abandoned this revision. ayermolo added a comment. Redid in D139577 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 481047. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Re-did D139379 after pushing it by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 ___ lld

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo created this revision. Herald added subscribers: mstorsjo, hoy, modimo, wenlei, arphaman, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. ayermolo requested review of this revision. Herald added subs

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Accidentally pushed when pushing bolt changes. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480994. ayermolo added a comment. rebase, clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFR

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480619. ayermolo added a comment. fixed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:115 +private: + uint64_t Fields[2]; + dblaikie wrote: > How come this became an array? Rather than keeping it as two named fields? So I can provide a generic s

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. In D139379#3972871 , @dblaikie wrote: > Perhaps the change to use accessors could be removed, now that you've used it > to find all the places that needed to be fixed up? (like just using it for > cleanup/temporary purposes, wi

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480299. ayermolo added a comment. update s/getLength()/getLength32() in DWP.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480283. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo created this revision. Herald added subscribers: mstorsjo, hoy, modimo, wenlei, arphaman, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. ayermolo requested review of this revision. Herald added subs

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3966539 , @labath wrote: > I don't believe there's no way to split this patch up. I mean, just half of > it is dedicated to changing PRIx32 into PRIx64. Surely that can be a patch of > it's own, even if it meant that

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 479769. ayermolo added a comment. Addressed inlined comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/include/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3963767 , @labath wrote: > The explanation makes sense, and I *think* the patch is ok, but it's hard to > review it with all the noise. I still believe the DIERef change would be > better off as a separate patch, so

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3948707 , @labath wrote: > I am puzzled by the OSO changes in the DIERef class. How do they tie in with > the increase in the offset size? It seems like it should at best be a > separate patch... That part was more

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei, arphaman. Herald added a reviewer: shafik. Herald added a project: All. ayermolo published this revision for review. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a pr

[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

ayermolo added a comment. Is there an a RFC for this or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5

ayermolo added a comment. In D121876#3542766 , @Amir wrote: > Hi, > The test started to fail on Ubuntu buildbot: > https://lab.llvm.org/buildbot/#/builders/215/builds/6376 > > # PRECHECK: include_directories[ 0] = .debug_line_str[0x] >

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > ayermolo wrote: > > ayermolo wrote: > > > dblaikie wrote: > > >

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); ayermolo wrote: > dblaikie wrote: > > That seems like a somewhat problematic API

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > That seems like a somewhat problematic API - returning two very

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

ayermolo added a comment. In D127889#3604421 , @DavidSpickett wrote: > I've reverted this due to failures on our bots: > https://lab.llvm.org/buildbot/#/builders/96/builds/25032/steps/6/logs/stdio > > /usr/bin/ld: > /home/tcwg-buildbot/worker/lldb-aa

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG130167ed1eff: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127889/new/ https:/

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. The case comes out of how BOLT

  1   2   >