ayermolo added a comment.
I tried to modify all the places wehre getOffset() is used. Which will later
return 64bit instead of 32 bit.
Sorry I guess there was miss communication.
I am not quite clear in what you are suggesting.
The way I did it we now have two distinct interfaces. One for old way that
takes in char* and args and applies formatting internally, and a new one which
takes in std::string. So all formatting is done on caller side with
std::string(llvm::formatv(..)).
Are you suggesting to change implementation of
void ReportError(const char *format, ...)
__attribute__((format(printf, 2, 3)));
and others to use llvm::formatv under the hood instead?
So caller side will remain mostly the same. Except instead of using printf
formating it will be formatvv.
In that case all of call sites will need to change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139955/new/
https://reviews.llvm.org/D139955
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
