ayermolo added a comment.
In D139955#3992766 <https://reviews.llvm.org/D139955#3992766>, @JDevlieghere
wrote:
> I don't really understand the motivation. Can you elaborate on why "enabling
> 64 bit support" requires this change? I definitely prefer the `formatv`
> approach, but wouldn't the PRIx64 should do what you want here?
>
> Also, at a higher level, can we do the same thing as the `Log::Format`
> function that takes varargs and uses `formavt` under the hood?
>
> template <typename... Args>
> void Format(llvm::StringRef file, llvm::StringRef function,
> const char *format, Args &&... args) {
> Format(file, function, llvm::formatv(format,
> std::forward<Args>(args)...));
> }
This was suggested in https://reviews.llvm.org/D138618 by @labath
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139955/new/
https://reviews.llvm.org/D139955
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
