[Lldb-commits] [lldb] [lldb][test] Fix unordered-map test (PR #156033)

2025-09-18 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > The "frame var" expression would be more similar to script > lldb.frame.FindVariable("ptr1").Dereference().GetChildAtIndex(0) This works in this case. ```sh >>> lldb.frame.FindVariable("ptr1").Dereference().GetChildAtIndex(0) (std::pair, std::basic_string >) [0] = (first =

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-18 Thread via lldb-commits
tgs-sc wrote: I think I can add this change into a separate commit in this PR, so that changes we already made will still be relevant. https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f1a02c6 - [lldb] Fix unordered-map data formatter for const types (#156033)

2025-09-18 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-09-15T15:19:55+01:00 New Revision: f1a02c681f0d092bb28ac3ff2e79eff11ecb95dc URL: https://github.com/llvm/llvm-project/commit/f1a02c681f0d092bb28ac3ff2e79eff11ecb95dc DIFF: https://github.com/llvm/llvm-project/commit/f1a02c681f0d092bb28ac3ff2e79eff11ecb95dc.diff L

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 auto_merge_enabled https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread John Harrison via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { ashgti wrote: Added comments to this and a bunch of other classes in this file. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread John Harrison via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 6 "test-build-unified-tree-check-cross-project". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/274

[Lldb-commits] [lldb] [lldb][NFC] Fix style issues with StackID.h (PR #157483)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/157483 >From 668e90948beabe437ea283b84ae0ffc9ea7c4a78 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 8 Sep 2025 07:43:38 -0700 Subject: [PATCH] [lldb][NFC] Fix style issues with StackID.h

[Lldb-commits] [lldb] 082d1d9 - [lldb-dap] Bump form-data from 4.0.1 to 4.0.4

2025-09-18 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-09-18T14:40:18-07:00 New Revision: 082d1d911c1cd79849f74ac203fbcbfbb6737cef URL: https://github.com/llvm/llvm-project/commit/082d1d911c1cd79849f74ac203fbcbfbb6737cef DIFF: https://github.com/llvm/llvm-project/commit/082d1d911c1cd79849f74ac203fbcbfbb6737cef.d

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 15 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/14788 Here is the relevant piec

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/159612 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a666286 - [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (#159612)

2025-09-18 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-09-18T13:49:56-07:00 New Revision: a6662866e88a887ab125c4d533659d27c4134108 URL: https://github.com/llvm/llvm-project/commit/a6662866e88a887ab125c4d533659d27c4134108 DIFF: https://github.com/llvm/llvm-project/commit/a6662866e88a887ab125c4d533659d27c

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-18 Thread satyanarayana reddy janga via lldb-commits
https://github.com/satyajanga closed https://github.com/llvm/llvm-project/pull/158161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1c95d80 - RISCV enable assembly unwinding (#158161)

2025-09-18 Thread via lldb-commits
Author: barsolo2000 Date: 2025-09-18T15:41:16-05:00 New Revision: 1c95d80ba68efd2ca9a0336529ea5fb7dc871417 URL: https://github.com/llvm/llvm-project/commit/1c95d80ba68efd2ca9a0336529ea5fb7dc871417 DIFF: https://github.com/llvm/llvm-project/commit/1c95d80ba68efd2ca9a0336529ea5fb7dc871417.diff L

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-18 Thread satyanarayana reddy janga via lldb-commits
satyajanga wrote: looks good to me. https://github.com/llvm/llvm-project/pull/158161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/159452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (PR #159523)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/159523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Implement `AddSymbols` (PR #154121)

2025-09-18 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/154121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread John Harrison via lldb-commits
@@ -100,22 +175,301 @@ template class Transport { virtual llvm::Expected RegisterMessageHandler(MainLoop &loop, MessageHandler &handler) = 0; - // FIXME: Refactor mcp::Server to not directly access log on the transport. - // protected: +protected: template inline a

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread John Harrison via lldb-commits
@@ -100,22 +175,301 @@ template class Transport { virtual llvm::Expected RegisterMessageHandler(MainLoop &loop, MessageHandler &handler) = 0; - // FIXME: Refactor mcp::Server to not directly access log on the transport. - // protected: +protected: template inline a

[Lldb-commits] [lldb] Fix a bug where an error was emitted for GCC union types. (PR #159401)

2025-09-18 Thread Raphael Isemann via lldb-commits
Teemperor wrote: LGTM, but maybe wait a few days for one of the actually active contributors before merging https://github.com/llvm/llvm-project/pull/159401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
royitaqi wrote: Reverted the unintended changes in the "modification time" approach by 4b989d8536bdee440d434f05ccc76c1c4bdc5647. cc @walter-erquinigo, in case you think the "modification time" approach is okay to go after reading [my last comment](https://github.com/llvm/llvm-project/pull/159

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/159481 >From bb9541a27f618326abb1968c0d89313cd38dbbde Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 17 Sep 2025 16:26:06 -0700 Subject: [PATCH 1/2] [vscode-lldb] Restart server when lldb-dap's modification time h

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/159612 >From 9214bba07c1e0e0795d2a963d4161b208f96ed85 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 15 Sep 2025 15:53:39 -0700 Subject: [PATCH 1/3] [lldb][NFC] Simplify logic in ABIMacOSX

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -100,22 +175,301 @@ template class Transport { virtual llvm::Expected RegisterMessageHandler(MainLoop &loop, MessageHandler &handler) = 0; - // FIXME: Refactor mcp::Server to not directly access log on the transport. - // protected: +protected: template inline a

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I did a first pass but I definitely need to do another pass with everything I learned during the first round, but don't want to hold back initial comment on that. https://github.com/llvm/llvm-project/pull/159160 ___

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { JDevlieghere wrote: This is the first file in the diff, so maybe its purpose will become clear later, but at this

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change directory creation logic in framework-header-fix (PR #158355)

2025-09-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/158355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > This looks fine, although we're not using `tbi_mask` anywhere now? We should > probably remove it if it's not being used. It is! ``` if (mask == LLDB_INVALID_ADDRESS_MASK) mask = tbi_mask; ``` https://github.com/llvm/llvm-project/pull/159612 _

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks fine, although we're not using `tbi_mask` anywhere now? We should probably remove it if it's not being used. https://github.com/llvm/llvm-project/pull/159612 ___ lldb-commits mail

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-18 Thread Roy Shi via lldb-commits
@@ -149,27 +149,40 @@ Restarting the server will interrupt any existing debug sessions and start a new this.cleanUp(this.serverProcess); } - cleanUp(process: child_process.ChildProcessWithoutNullStreams) { + private cleanUp(process: child_process.ChildProcessWithoutNu

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/159588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Track CFA pointer metadata in StackID (PR #157498)

2025-09-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: I agree with the ultimate goal of being able to control the handling of non-address bits, but help me understand this part: > However, the CFA inside StackIDs is also used in other contexts through the > method StackID::GetCallFrameAddress. One notable case is DWARFExpressi

[Lldb-commits] [lldb] 88b5c74 - [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (#159523)

2025-09-18 Thread via lldb-commits
Author: David Spickett Date: 2025-09-18T09:59:02+01:00 New Revision: 88b5c7435e70702d54772c1ec3864013099edc6c URL: https://github.com/llvm/llvm-project/commit/88b5c7435e70702d54772c1ec3864013099edc6c DIFF: https://github.com/llvm/llvm-project/commit/88b5c7435e70702d54772c1ec3864013099edc6c.diff

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-18 Thread via lldb-commits
https://github.com/tgs-sc updated https://github.com/llvm/llvm-project/pull/154123 >From a2390655ad8a77ef9f1087e24089e36d8925e604 Mon Sep 17 00:00:00 2001 From: Timur Golubovich Date: Mon, 18 Aug 2025 17:29:01 +0300 Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Added a check for the special

[Lldb-commits] [lldb] [lldb] Fixed UB in CPlusPlusLanguage plug-in (PR #158304)

2025-09-18 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/158304 C++11 allows the use of Universal Character Names (UCNs) in identifiers, including function names. According to the spec the behavior of std::isalpha(ch) and std::isalnum(ch) is undefined if the argument's va

[Lldb-commits] [lldb] [lldb-dap] Add memory event (PR #158437)

2025-09-18 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/158437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-18 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/158161 >From 827f68dcc9b6e207ff324f1be353561ee10892d1 Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Thu, 11 Sep 2025 14:06:05 -0700 Subject: [PATCH 1/5] RISCV unwinding enable --- lldb/include/lldb/Core/Op

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes I've intentionally split this into two commits to make it easier that this is an NFC patch; don't think we need to preserve them separately though upon merging. --- Full diff: https://gi

[Lldb-commits] [lldb] [lldb][NFC] Simplify logic in ABIMacOSX_arm64::FixDataAddress (PR #159612)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/159612 I've intentionally split this into two commits to make it easier that this is an NFC patch; don't think we need to preserve them separately though upon merging. >From 9214bba07c1e0e0795d2a963d4161b208f9

[Lldb-commits] [lldb] 4f72abd - [LLDB] Add support for the structured data plugins in lldb-server (#159457)

2025-09-18 Thread via lldb-commits
Author: Walter Erquinigo Date: 2025-09-18T10:40:55-04:00 New Revision: 4f72abd8404efa3de32188429d5f079ad12264e3 URL: https://github.com/llvm/llvm-project/commit/4f72abd8404efa3de32188429d5f079ad12264e3 DIFF: https://github.com/llvm/llvm-project/commit/4f72abd8404efa3de32188429d5f079ad12264e3.di

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/159586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 113357f - [lldb][nfc] Remove no-op calls to Fix*Address (#159586)

2025-09-18 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-09-18T10:33:51-07:00 New Revision: 113357f1a8feb0bfa337bb8a0b9d1d6eaa2d4f0f URL: https://github.com/llvm/llvm-project/commit/113357f1a8feb0bfa337bb8a0b9d1d6eaa2d4f0f DIFF: https://github.com/llvm/llvm-project/commit/113357f1a8feb0bfa337bb8a0b9d1d6ea

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. The early Fixing of the register value before doing a memory read is from early in our adoption of AArch64 PAC where the bits would not be cleared at use-time when we read/write memory. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (PR #159606)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes Based on testing on processors that use pointer metadata, and with all the work done to delay calls to FixDataAddress, this is no longer necessary. Note that, with debugserver in particul

[Lldb-commits] [lldb] [lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (PR #159606)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/159606 Based on testing on processors that use pointer metadata, and with all the work done to delay calls to FixDataAddress, this is no longer necessary. Note that, with debugserver in particular, this is an N

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-18 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/159457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1dc6bf3 - [lldb][lldb-dap] Disable all lldb-dap tests on Windows on Arm (#159542)

2025-09-18 Thread via lldb-commits
Author: David Spickett Date: 2025-09-18T11:01:19+01:00 New Revision: 1dc6bf3ff98c25dd29c6db3407c81d2064bc6977 URL: https://github.com/llvm/llvm-project/commit/1dc6bf3ff98c25dd29c6db3407c81d2064bc6977 DIFF: https://github.com/llvm/llvm-project/commit/1dc6bf3ff98c25dd29c6db3407c81d2064bc6977.diff

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/159586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Architecture plugins should report the vector element order (PR #157198)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. If this is required for the parent PR and that PR is eventually approved, this LGTM. Please add System Z to the listed systems in the PR description. That detail may come in handy one day. https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-18 Thread Justin Stitt via lldb-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -foverflow-behavior-types -std=c++11 -ast-print %s -o - | FileCheck %s + +extern int __attribute__((overflow_behavior(no_wrap))) a; +extern int __attribute__((overflow_behavior(wrap))) b; + +// CHECK: extern __no_wrap int a; +// CHECK: extern _

[Lldb-commits] [lldb] [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (PR #159523)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/159523 uintptr_t is usually a good idea when handling pointers, but lldb has to handle 64-bit addresses that might be from a remote system, on a 32-bit system. So I've changed a few instances here to use addr_t

[Lldb-commits] [lldb] [lldb][lldb-dap] Disable all lldb-dap tests on Windows on Arm (PR #159542)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This reverts the following commits: a0a82ee19d6f2ff1013407ba4c973bfe5428423f 757bb36a58c7d7151a28c6a5fc7caa2e1f44de87 83b48b13f3a70bf56053e92593270c519859cfd7 b45f1fb377636a34c01e34b89341c97d19975554 d2

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread Vy Nguyen via lldb-commits
oontvoo wrote: > Thanks for the fix. The new variable `m_executable_name` is used to save the > name so that we can find the NT_FILE entries for the main executable, which > is handled in a different part of the code. > > There is the same fix in #159375. Oops, my bad - hadn't noticed the exi

[Lldb-commits] [lldb] [lldb] Fix unsafe map mutation in ProcessElfCore::FindModuleUUID (PR #159444)

2025-09-18 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/159444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 44a1f7e - [lldb] Fix unsafe map mutation in ProcessElfCore::FindModuleUUID (#159444)

2025-09-18 Thread via lldb-commits
Author: David Peixotto Date: 2025-09-18T08:20:09-07:00 New Revision: 44a1f7e7cabebff853ccfbbb669f79673a2ec335 URL: https://github.com/llvm/llvm-project/commit/44a1f7e7cabebff853ccfbbb669f79673a2ec335 DIFF: https://github.com/llvm/llvm-project/commit/44a1f7e7cabebff853ccfbbb669f79673a2ec335.diff

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread David Peixotto via lldb-commits
https://github.com/dmpots commented: Thanks for the fix. The new variable `m_executable_name` is used to save the name so that we can find the NT_FILE entries for the main executable, which is handled in a different part of the code. There is the same fix in #159375. https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Could you use `kNum_Cores` so we don't have to remember to update this when > new ones are added? > > Also the `eCore_wasm32` one has an empty body, so does that mean it does not > get checked? Good catch, that's an unintentional off-by-one. Using `kNum_Cores` addresses

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/159452 >From 57198d217f9e5df387c8e35452c82577756f2bb0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 17 Sep 2025 13:56:13 -0700 Subject: [PATCH] [lldb] Add a static_assert that g_core_definitions matc

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/159586 The first call, in InitializeNonZerothFrame, is inside a logging branch. For that, it's better to log the real value instead of the fixed one. The second call, inside RegisterContextUnwind::ReadFrameAddr

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/159586 >From f7f958aa2cb9c0354852921f07a88639c3b049a8 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 18 Sep 2025 07:25:03 -0700 Subject: [PATCH] [lldb][nfc] Remove no-op calls to Fix*Addres

[Lldb-commits] [lldb] 09e0f1e - [LLDB]Fix buffer-over-flow bug introduced in 157170 (#159588)

2025-09-18 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-09-18T10:43:42-04:00 New Revision: 09e0f1e035b348e2cd694e5f4b943a78cb6ad639 URL: https://github.com/llvm/llvm-project/commit/09e0f1e035b348e2cd694e5f4b943a78cb6ad639 DIFF: https://github.com/llvm/llvm-project/commit/09e0f1e035b348e2cd694e5f4b943a78cb6ad639.diff LOG

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/159588 already fixed this. https://github.com/llvm/llvm-project/pull/159375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/24402 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/159375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/159588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes If `pr_name` is longer than 16, it would be a non-null terminated string. Assigning it to `std::string m_executable_name` would cause an overflow read. Instead, just copy the name from thread_data.name. (Questi

[Lldb-commits] [lldb] [LLDB]Fix buffer-over-flow bug introduced in 157170 (PR #159588)

2025-09-18 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/159588 If `pr_name` is longer than 16, it would be a non-null terminated string. Assigning it to `std::string m_executable_name` would cause an overflow read. Instead, just copy the name from thread_data.name. (Quest

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/159586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes The first call, in InitializeNonZerothFrame, is inside a logging branch. For that, it's better to log the real value instead of the fixed one. The second call, inside RegisterContextUnwin

[Lldb-commits] [lldb] [lldb][test] Disable a procfile test when threading is not enabled (PR #159559)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/159559 >From 959edbe1add44159d473602d4151cf533cac4050 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 18 Sep 2025 12:51:55 +0100 Subject: [PATCH 1/2] [lldb][test] Disable a procfile test when threading i

[Lldb-commits] [lldb] [lldb][test] Disable a procfile test when threading is not enabled (PR #159559)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/159559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1fc9b34 - [lldb][test] Disable a procfile test when threading is not enabled (#159559)

2025-09-18 Thread via lldb-commits
Author: David Spickett Date: 2025-09-18T13:01:55+01:00 New Revision: 1fc9b344889aeb1f83cfee29f61d844ec927a5cd URL: https://github.com/llvm/llvm-project/commit/1fc9b344889aeb1f83cfee29f61d844ec927a5cd DIFF: https://github.com/llvm/llvm-project/commit/1fc9b344889aeb1f83cfee29f61d844ec927a5cd.diff

[Lldb-commits] [lldb] [lldb][test] Disable a procfile test when threading is not enabled (PR #159559)

2025-09-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/unittests/Host/posix/SupportTest.cpp ``

[Lldb-commits] [lldb] [lldb][test] Disable a procfile test when threading is not enabled (PR #159559)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes As is done for other procfile tests. --- Full diff: https://github.com/llvm/llvm-project/pull/159559.diff 1 Files Affected: - (modified) lldb/unittests/Host/posix/SupportTest.cpp (+2-2) `

[Lldb-commits] [lldb] [lldb][lldb-dap] Disable all lldb-dap tests on Windows on Arm (PR #159542)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/159542 This reverts the following commits: a0a82ee19d6f2ff1013407ba4c973bfe5428423f 757bb36a58c7d7151a28c6a5fc7caa2e1f44de87 83b48b13f3a70bf56053e92593270c519859cfd7 b45f1fb377636a34c01e34b89341c97d19975554 d2e153

[Lldb-commits] [lldb] [LLDB][NativePDB] Add modifiers to modified type name (PR #159296)

2025-09-18 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/159296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4625c8f - [LLDB][NativePDB] Add modifiers to modified type name (#159296)

2025-09-18 Thread via lldb-commits
Author: nerix Date: 2025-09-18T11:55:15+02:00 New Revision: 4625c8f076a85a4b3799a71b9299424a426a9de3 URL: https://github.com/llvm/llvm-project/commit/4625c8f076a85a4b3799a71b9299424a426a9de3 DIFF: https://github.com/llvm/llvm-project/commit/4625c8f076a85a4b3799a71b9299424a426a9de3.diff LOG: [L

[Lldb-commits] [lldb] a868f28 - [LLDB][ProcessWindows] Set exit status on instance rather than going through all targets (#159308)

2025-09-18 Thread via lldb-commits
Author: nerix Date: 2025-09-18T11:27:25+02:00 New Revision: a868f28c6e9beecb2b3fbe8acfbe0d272fabd14d URL: https://github.com/llvm/llvm-project/commit/a868f28c6e9beecb2b3fbe8acfbe0d272fabd14d DIFF: https://github.com/llvm/llvm-project/commit/a868f28c6e9beecb2b3fbe8acfbe0d272fabd14d.diff LOG: [L

[Lldb-commits] [lldb] [LLDB][ProcessWindows] Set exit status on instance rather than going through all targets (PR #159308)

2025-09-18 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/159308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (PR #159523)

2025-09-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: Landing this to fix the build, but @JDevlieghere please do give it a look. https://github.com/llvm/llvm-project/pull/159523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (PR #159523)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/159523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct 32-bit build failure in StopInfoMachException.cpp (PR #159523)

2025-09-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes uintptr_t is usually a good idea when handling pointers, but lldb has to handle 64-bit addresses that might be from a remote system, on a 32-bit system. So I've changed a few instances here to use add

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: `ArchSpecValidator` starts instantiating a chain of `ArchSpecValidator` until it gets to `ArchSpecValidator` which does not inherit from anything so it stops there. `arm_generic` being the first core value and `wasm32` being the last. At least righ