https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/159606
Based on testing on processors that use pointer metadata, and with all the work
done to delay calls to FixDataAddress, this is no longer necessary.
Note that, with debugserver in particular, this is an NFC change: the code path
here is for frame zero, and debugserver will strip metadata when reading fp
from frame zero anyway.
>From b92a88b62f27cce3df63e4bdad2e919015a8f7fc Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan <fpiove...@apple.com>
Date: Thu, 18 Sep 2025 09:53:51 -0700
Subject: [PATCH] [lldb] Don't call FixDataAddress when reading fp in
ReadGPRValue
Based on testing on processors that use pointer metadata, and with all
the work done to delay calls to FixDataAddress, this is no longer
necessary.
Note that, with debugserver in particular, this is an NFC change: the
code path here is for frame zero, and debugserver will strip metadata
when reading fp from frame zero anyway.
---
lldb/source/Target/RegisterContextUnwind.cpp | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lldb/source/Target/RegisterContextUnwind.cpp
b/lldb/source/Target/RegisterContextUnwind.cpp
index 3b018c09b8b72..197e1dd090bac 100644
--- a/lldb/source/Target/RegisterContextUnwind.cpp
+++ b/lldb/source/Target/RegisterContextUnwind.cpp
@@ -2228,9 +2228,6 @@ bool
RegisterContextUnwind::ReadGPRValue(lldb::RegisterKind register_kind,
if (generic_regnum == LLDB_REGNUM_GENERIC_PC ||
generic_regnum == LLDB_REGNUM_GENERIC_RA)
value = abi_sp->FixCodeAddress(value);
- if (generic_regnum == LLDB_REGNUM_GENERIC_SP ||
- generic_regnum == LLDB_REGNUM_GENERIC_FP)
- value = abi_sp->FixDataAddress(value);
}
return true;
}
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
