llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) <details> <summary>Changes</summary> This reverts the following commits: a0a82ee19d6f2ff1013407ba4c973bfe5428423f 757bb36a58c7d7151a28c6a5fc7caa2e1f44de87 83b48b13f3a70bf56053e92593270c519859cfd7 b45f1fb377636a34c01e34b89341c97d19975554 d2e153981e62fb2ea781ef456ff744f9893e0733 e2d1bbebbb099c7010a31fad62a9128166ef14a0 71cae12442e7476e6397fd73db05e127bfe2d035 7dd879bdc01297a551196a60bb5a5a90ca4dd1ed f3b542e3148cfc244f63cb7c987ccf8ebc71942b Where I had disabled specific tests due to them being flakey on our Windows on Arm bot. Clearly this strategy isn't working because every day I see a new random test failing. Until something can be done about this, disable every lldb-dap test on Windows on Arm. The coverage we get is just not worth spamming contributors who have nothing to do with lldb-dap. See #<!-- -->137660 --- Full diff: https://github.com/llvm/llvm-project/pull/159542.diff 9 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py (+4) - (modified) lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py (-3) - (modified) lldb/test/API/tools/lldb-dap/cancel/TestDAP_cancel.py (-2) - (modified) lldb/test/API/tools/lldb-dap/console/TestDAP_console.py (-1) - (modified) lldb/test/API/tools/lldb-dap/io/TestDAP_io.py (-1) - (modified) lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py (-3) - (modified) lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py (-1) - (modified) lldb/test/API/tools/lldb-dap/step/TestDAP_step.py (-1) - (modified) lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py (-1) ``````````diff diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py index 882eec9971a73..f7b1ed80fceb5 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py @@ -5,12 +5,16 @@ import dap_server from dap_server import Source +from lldbsuite.test.decorators import skipIf from lldbsuite.test.lldbtest import * from lldbsuite.test import lldbplatformutil import lldbgdbserverutils import base64 +# DAP tests as a whole have been flakey on the Windows on Arm bot. See: +# https://github.com/llvm/llvm-project/issues/137660 +@skipIf(oslist=["windows"], archs=["aarch64"]) class DAPTestCaseBase(TestBase): # set timeout based on whether ASAN was enabled or not. Increase # timeout by a factor of 10 if ASAN is enabled. diff --git a/lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py b/lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py index d3952e150e125..c54e21c1b973a 100644 --- a/lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py +++ b/lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py @@ -40,7 +40,6 @@ def set_and_hit_breakpoint(self, continueToExit=True): self.continue_to_exit() @skipIfNetBSD # Hangs on NetBSD as well - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_by_pid(self): """ Tests attaching to a process by process ID. @@ -56,7 +55,6 @@ def test_by_pid(self): self.set_and_hit_breakpoint(continueToExit=True) @skipIfNetBSD # Hangs on NetBSD as well - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_by_name(self): """ Tests attaching to a process by process name. @@ -95,7 +93,6 @@ def test_by_name_waitFor(self): self.set_and_hit_breakpoint(continueToExit=True) @skipIfNetBSD # Hangs on NetBSD as well - @skipIfWindows def test_commands(self): """ Tests the "initCommands", "preRunCommands", "stopCommands", diff --git a/lldb/test/API/tools/lldb-dap/cancel/TestDAP_cancel.py b/lldb/test/API/tools/lldb-dap/cancel/TestDAP_cancel.py index 9dea325694f00..e722fcea9283a 100644 --- a/lldb/test/API/tools/lldb-dap/cancel/TestDAP_cancel.py +++ b/lldb/test/API/tools/lldb-dap/cancel/TestDAP_cancel.py @@ -37,7 +37,6 @@ def async_blocking_request(self, duration: float) -> int: def async_cancel(self, requestId: int) -> int: return self.send_async_req(command="cancel", arguments={"requestId": requestId}) - @skipIfWindows def test_pending_request(self): """ Tests cancelling a pending request. @@ -70,7 +69,6 @@ def test_pending_request(self): self.assertEqual(cancel_resp["success"], True) self.continue_to_exit() - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_inflight_request(self): """ Tests cancelling an inflight request. diff --git a/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py b/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py index 202b23abc1811..ceddaeb50cd3b 100644 --- a/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py +++ b/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py @@ -38,7 +38,6 @@ def check_lldb_command( ), ) - @skipIfWindows def test_scopes_variables_setVariable_evaluate(self): """ Tests that the "scopes" request causes the currently selected diff --git a/lldb/test/API/tools/lldb-dap/io/TestDAP_io.py b/lldb/test/API/tools/lldb-dap/io/TestDAP_io.py index 246ad3ae944cc..af5c62a8c4eb5 100644 --- a/lldb/test/API/tools/lldb-dap/io/TestDAP_io.py +++ b/lldb/test/API/tools/lldb-dap/io/TestDAP_io.py @@ -76,7 +76,6 @@ def test_incorrect_content_length(self): process.stdin.close() self.assertEqual(process.wait(timeout=5.0), EXIT_FAILURE) - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_partial_content_length(self): """ lldb-dap returns a failure exit code when the input stream is closed diff --git a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py index 096ce5e0236a2..ceef95dfcd0d5 100644 --- a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py +++ b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py @@ -96,8 +96,6 @@ def test_termination(self): # Check the return code self.assertEqual(self.dap_server.process.poll(), 0) - # Flakey on Windows, https://github.com/llvm/llvm-project/issues/137660. - @skipIfWindows def test_stopOnEntry(self): """ Tests the default launch of a simple program that stops at the @@ -144,7 +142,6 @@ def test_cwd(self): ) self.assertTrue(found, "verified program working directory") - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_debuggerRoot(self): """ Tests the "debuggerRoot" will change the working directory of diff --git a/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py b/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py index 1d13bcdd4837e..b487257b6414d 100644 --- a/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py +++ b/lldb/test/API/tools/lldb-dap/startDebugging/TestDAP_startDebugging.py @@ -8,7 +8,6 @@ class TestDAP_startDebugging(lldbdap_testcase.DAPTestCaseBase): - @skipIfWindows # https://github.com/llvm/llvm-project/issues/137660 def test_startDebugging(self): """ Tests the "startDebugging" reverse request. It makes sure that the IDE can diff --git a/lldb/test/API/tools/lldb-dap/step/TestDAP_step.py b/lldb/test/API/tools/lldb-dap/step/TestDAP_step.py index 3a747c3995665..5c055f679aedc 100644 --- a/lldb/test/API/tools/lldb-dap/step/TestDAP_step.py +++ b/lldb/test/API/tools/lldb-dap/step/TestDAP_step.py @@ -84,7 +84,6 @@ def test_step(self): # only step one thread that is at the breakpoint and stop break - @skipIfWindows def test_step_over_inlined_function(self): """ Test stepping over when the program counter is in another file. diff --git a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py index a386afee21eb1..03b79a805d341 100644 --- a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py +++ b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py @@ -102,7 +102,6 @@ def test_supported_capability_x86_arch(self): self.continue_to_exit() @skipIf(archs=["x86", "x86_64"]) - @skipIfWindows def test_supported_capability_other_archs(self): program = self.getBuildArtifact("a.out") self.build_and_launch(program) `````````` </details> https://github.com/llvm/llvm-project/pull/159542 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
