llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux`
running on `fuchsia-debian-64-us-central1-b-1` while building `lldb` at step 4
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/11/builds/15495
Here is the relevant p
labath wrote:
gmock doesn't let you do anything that wouldn't be possible without it. For
this to work, the code which interacts with the mock needs to be ready to
accept something other than the real object somehow. That usually means
making the mocked object polymorphic, but that is a no
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
JDevlieghere wrote:
Maybe add a comment saying that this is the _number_ of instructio
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -1668,6 +1668,26 @@ SBError SBTarget::SetLabel(const char *label) {
return Status::FromError(target_sp->SetLabel(label));
}
+uint32_t SBTarget::GetMinimumOpcodeByteSize() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ TargetSP target_sp(GetSP());
+ if (target_sp) {
+retur
https://github.com/JDevlieghere commented:
As a general comment, the code is becoming quite complicated and I think it
would help if we can break things up more. Looking at the protocol arguments we
have and offset in bytes, an offset in instructions, and then an instruction
count. If possible
Author: Jonas Devlieghere
Date: 2025-05-19T18:37:49-07:00
New Revision: df0358f36b69689b8d502efd08cb8422cf170600
URL:
https://github.com/llvm/llvm-project/commit/df0358f36b69689b8d502efd08cb8422cf170600
DIFF:
https://github.com/llvm/llvm-project/commit/df0358f36b69689b8d502efd08cb8422cf170600.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/140641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -948,13 +956,11 @@ def request_scopes(self, frameId):
command_dict = {"command": "scopes", "type": "request", "arguments":
args_dict}
return self.send_recv(command_dict)
-def request_setBreakpoints(self, file_path, line_array, data=None):
+def reque
@@ -35,29 +36,34 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const protocol::Source &source) {
+llvm::Error SourceBreakpoint::SetB
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
---
Patch is 21.90 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/140486.diff
9 Files Affected:
- (modified) lldb/include/lldb/API/SBTarget.h (+4)
- (modified)
https://github.com/eronnen ready_for_review
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/2] [lldb-dap] Fix disassemble request instruction offset
handling
@@ -787,7 +787,7 @@
{
"id": "lldb-dap.modules",
"name": "Modules",
- "when": "inDebugMode && debugType == 'lldb-dap'",
+ "when": "inDebugMode && debugType == 'lldb-dap' &&
lldb-dap.showModules",
ashgti wrote:
Can
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/140641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -70,9 +71,21 @@ export class DebugSessionTracker
/** Clear information from the active session. */
private onExit(session: vscode.DebugSession) {
this.modules.delete(session);
+// close when there is no more sessions
+if (this.modules.size <= 0) {
+ this
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/139826
>From 52c587ef84366a0c2a01256f71f1f2404467e3a8 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 May 2025 17:24:19 -0700
Subject: [PATCH 1/2] [lldb] Reduce max-children-count default to readable size
Cha
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/115408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-19T16:04:50-07:00
New Revision: dfabd61f7370cdd2ba76876b04993e991bb4e58b
URL:
https://github.com/llvm/llvm-project/commit/dfabd61f7370cdd2ba76876b04993e991bb4e58b
DIFF:
https://github.com/llvm/llvm-project/commit/dfabd61f7370cdd2ba76876b04993e991bb4e58b.d
@@ -35,29 +36,34 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const protocol::Source &source) {
+llvm::Error SourceBreakpoint::SetB
@@ -70,9 +71,21 @@ export class DebugSessionTracker
/** Clear information from the active session. */
private onExit(session: vscode.DebugSession) {
this.modules.delete(session);
+// close when there is no more sessions
JDevlieghere wrote:
```sugge
@@ -70,9 +71,21 @@ export class DebugSessionTracker
/** Clear information from the active session. */
private onExit(session: vscode.DebugSession) {
this.modules.delete(session);
+// close when there is no more sessions
+if (this.modules.size <= 0) {
---
https://github.com/JDevlieghere approved this pull request.
LGTM modulo comments.
https://github.com/llvm/llvm-project/pull/140603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
getArgumentsIfRequest is returning a local variable by value. Using std::move
is not needed and may inhibit copy elision. Also fixes the braces around a
single-line if.
---
Full diff: https://githu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140641
getArgumentsIfRequest is returning a local variable by value. Using std::move
is not needed and may inhibit copy elision. Also fixes the braces around a
single-line if.
>From 0e7412042fcf77f4d5cf65b2c4e23
@@ -102,6 +111,8 @@ export class DebugSessionTracker
console.error("unexpected module event reason");
break;
}
+
+ this.showModulesTreeView(modules.length > 0);
da-viper wrote:
I assumed if there is no modules the session has end
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/140603
>From 8ca0be7cdd49caa32db43097d9ff9c4060b1d87d Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Mon, 19 May 2025 20:44:31 +0100
Subject: [PATCH 1/3] [lldb][lldb-dap] show modules pane if supported by the
adapt
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/140603
>From 8ca0be7cdd49caa32db43097d9ff9c4060b1d87d Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Mon, 19 May 2025 20:44:31 +0100
Subject: [PATCH 1/2] [lldb][lldb-dap] show modules pane if supported by the
adapt
@@ -948,13 +956,11 @@ def request_scopes(self, frameId):
command_dict = {"command": "scopes", "type": "request", "arguments":
args_dict}
return self.send_recv(command_dict)
-def request_setBreakpoints(self, file_path, line_array, data=None):
+def reque
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -35,29 +36,34 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const protocol::Source &source) {
+llvm::Error SourceBreakpoint::SetB
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-05-19T23:25:33+01:00
New Revision: 2523a8358ab9526a46f825fd94cc8a5d018f5ff7
URL:
https://github.com/llvm/llvm-project/commit/2523a8358ab9526a46f825fd94cc8a5d018f5ff7
DIFF:
https://github.com/llvm/llvm-project/commit/2523a8358ab9526a46f825fd94cc8a5d018f5ff7.diff
L
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/140162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2025-05-19T15:19:55-07:00
New Revision: f27cfeae6a544775803a50b3ed4c87e9193889a2
URL:
https://github.com/llvm/llvm-project/commit/f27cfeae6a544775803a50b3ed4c87e9193889a2
DIFF:
https://github.com/llvm/llvm-project/commit/f27cfeae6a544775803a50b3ed4c87e9193889a2.diff
Author: Jonas Devlieghere
Date: 2025-05-19T15:15:07-07:00
New Revision: 2dd6a8c35a79710273bb98da8729ec6dea251998
URL:
https://github.com/llvm/llvm-project/commit/2dd6a8c35a79710273bb98da8729ec6dea251998
DIFF:
https://github.com/llvm/llvm-project/commit/2dd6a8c35a79710273bb98da8729ec6dea251998.d
@@ -0,0 +1,16 @@
+#include
da-viper wrote:
Maybe the file was not saved, as it it is not empty, if not make you could make
it a cpp file.
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
https://github.com/ashgti approved this pull request.
Looks good to me!
https://github.com/llvm/llvm-project/pull/140162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/140162
>From 0673dc530a91cb2dd1bdd60dd5136d64e4ed48e8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 15 May 2025 16:37:06 -0700
Subject: [PATCH 1/3] Have interderminate events actually broadcast to dap
---
.
JDevlieghere wrote:
@jasonmolenda Yes, my understanding is that the GPRs are 33*8=264 bytes for
riscv64 and 33*4=132 bytes for riscv32. The FPR start at offset 132.
https://github.com/llvm/llvm-project/pull/115408
___
lldb-commits mailing list
lldb-c
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
nico wrote:
lldb/test/lit.site.cfg.py.in, lldb/test/Shell/lit.site.cfg.py.in,
lldb/test/Unit/lit.site.cfg.py.in also use `"@Python3_EXECUTABLE@"`. Do those
need changing too?
https://github.com/llvm/llvm-project/pull/140443
___
lldb-commits mailing l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/140162
>From 0673dc530a91cb2dd1bdd60dd5136d64e4ed48e8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 15 May 2025 16:37:06 -0700
Subject: [PATCH 1/3] Have interderminate events actually broadcast to dap
---
.
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/140150
>From 86ec6c076b9cf8e7afeb7d6bb0e334434f6e0d9e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 15 May 2025 13:57:11 -0700
Subject: [PATCH 01/10] Update ThreadElfCore
---
lldb/include/lldb/Target/UnixSi
@@ -955,6 +955,13 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"""
(dir, base) = os.path.split(file_path)
source_dict = {"name": base, "path": file_path}
+return self.request_setBreakpoints_with_source(source_dict,
lin
@@ -33,13 +35,42 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) {
+void SourceBreakpoint::SetBreak
@@ -452,6 +475,9 @@ struct DAP {
std::mutex m_active_request_mutex;
const protocol::Request *m_active_request;
+
+ llvm::StringMap m_source_breakpoints;
+ llvm::DenseMap m_source_assembly_breakpoints;
eronnen wrote:
I think it should be pretty simplifie
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
ojhunt wrote:
Yes, let me check whether I'm meant to be using Microso
jasonmolenda wrote:
I see the latest update includes the necessary changes to ThreadElfCore, that
looks good.
I'm still curious what this code does when reading x0. The RegisterContext GPR
struct defines 32 elements, pc + x1-x31, and the offset of x0 would be the 33rd
element. But instead o
https://github.com/JDevlieghere approved this pull request.
LGTM, but I'd like @jasonmolenda to sign off as the debugserver maintainer.
https://github.com/llvm/llvm-project/pull/140611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/talkeren updated
https://github.com/llvm/llvm-project/pull/140611
>From c385e9780e980865461f877c76acaa417b4d736c Mon Sep 17 00:00:00 2001
From: Tal Keren
Date: Mon, 19 May 2025 23:15:10 +0300
Subject: [PATCH 1/2] [lldb] Properly cache the result of
MachProcess::GetPlatform #
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h --
lldb/tools/debugserver/source/MacOSX/MachProcess.h
dmpots wrote:
ping @clayborg @JDevlieghere @jimingham. Please take a look when you get a
chance. Thanks!
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/talkeren edited
https://github.com/llvm/llvm-project/pull/140611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/115408
>From b72c1072f581bb6818a3cb7bcd59a1b44d998f52 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 7 Nov 2024 17:18:50 -0800
Subject: [PATCH] [lldb] Support riscv32 ELF corefiles
Support riscv32 EL
https://github.com/talkeren edited
https://github.com/llvm/llvm-project/pull/140611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/talkeren updated
https://github.com/llvm/llvm-project/pull/140611
>From c385e9780e980865461f877c76acaa417b4d736c Mon Sep 17 00:00:00 2001
From: Tal Keren
Date: Mon, 19 May 2025 23:15:10 +0300
Subject: [PATCH] [lldb] Properly cache the result of MachProcess::GetPlatform
#1406
https://github.com/talkeren updated
https://github.com/llvm/llvm-project/pull/140611
>From 7ccef56ba9d82fae7901bc39ef648b7be6bba473 Mon Sep 17 00:00:00 2001
From: Tal Keren
Date: Mon, 19 May 2025 23:15:10 +0300
Subject: [PATCH] [lldb] Properly cache the result of MachProcess::GetPlatform
#1406
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tal Keren (talkeren)
Changes
If `MachProcess::GetProcessPlatformViaDYLDSPI` fails and return 0, we don't
want to call it everytime as it won't change the result. So use
std::optional to cache wether we already calculated the value.
---
Full
https://github.com/talkeren created
https://github.com/llvm/llvm-project/pull/140611
If `MachProcess::GetProcessPlatformViaDYLDSPI` fails and return 0, we don't
want to call it everytime as it won't change the result. So use
std::optional to cache wether we already calculated the value.
>From 7
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
Author: Ely Ronnen
Date: 2025-05-19T22:13:58+02:00
New Revision: 30c990990940c15650ee1a488255a37c7a7af094
URL:
https://github.com/llvm/llvm-project/commit/30c990990940c15650ee1a488255a37c7a7af094
DIFF:
https://github.com/llvm/llvm-project/commit/30c990990940c15650ee1a488255a37c7a7af094.diff
LO
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
igorkudrin wrote:
Ping.
https://github.com/llvm/llvm-project/pull/139196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Thanks for the quick turnaround!
https://github.com/llvm/llvm-project/pull/140603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
if the `cwd` option is empty this means the adapter is created in the home
folder.
Any relative file saved is in the home folder. The files should be relative to
the current workspace folder.
---
Full diff:
@@ -102,6 +111,8 @@ export class DebugSessionTracker
console.error("unexpected module event reason");
break;
}
+
+ this.showModulesTreeView(modules.length > 0);
JDevlieghere wrote:
Does this mean that if all modules get unloaded,
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/140604
if the `cwd` option is empty this means the adapter is created in the home
folder.
Any relative file saved is in the home folder. The files should be relative to
the current workspace folder.
>From 825a1dea8
@@ -77,16 +77,19 @@ ProgressEvent::Create(uint64_t progress_id,
std::optional message,
if (event.GetEventType() == progressStart && event.GetEventName().empty())
return std::nullopt;
- if (prev_event && prev_event->EqualsForIDE(event))
+ if (prev_event && prev_event->
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Fixes #140589
Added logic to dynamically set the `lldb-dap.showModules` context based on the
presence of modules in the debug session.
---
Full diff: https://github.com/llvm/llvm-project/pull/140603.diff
2
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-05-19T15:51:15-04:00
New Revision: 10d198b32cd0b6aaeeaf1a6217611797c01f47f7
URL:
https://github.com/llvm/llvm-project/commit/10d198b32cd0b6aaeeaf1a6217611797c01f47f7
DIFF:
https://github.com/llvm/llvm-project/commit/10d198b32cd0b6aaeeaf1a6217611797c01f47f7.diff
LOG
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/140603
Fixes #140589
Added logic to dynamically set the `lldb-dap.showModules` context based on the
presence of modules in the debug session.
>From 8ca0be7cdd49caa32db43097d9ff9c4060b1d87d Mon Sep 17 00:00:00 2001
Fr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140599.diff
1 Files Affected:
- (modified) lldb/test/Shell/Commands/list-header.test (+1-1)
``diff
diff --git a/lldb/test/Shell/Commands/lis
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140599
None
>From 8bf781af04e046076de1e5d6ebcfcf1f508be211 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 14:26:36 -0400
Subject: [PATCH 1/2] [lldb][nfc]Make test "xfail" on windows
---
lldb/test/Sh
@@ -77,16 +77,19 @@ ProgressEvent::Create(uint64_t progress_id,
std::optional message,
if (event.GetEventType() == progressStart && event.GetEventName().empty())
return std::nullopt;
- if (prev_event && prev_event->EqualsForIDE(event))
+ if (prev_event && prev_event->
oontvoo wrote:
fixing now. thanks!
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,26 +36,22 @@ SourceRequestHandler::Run(const protocol::SourceArguments
&args) const {
return llvm::make_error(
"invalid arguments, expected source.sourceReference to be set");
- lldb::SBProcess process = dap.target.GetProcess();
- // Upper 32 bits is the
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/5542 is broken.
Probably you must use `XFAIL: target-windows` instead of `XFAIL:
system-windows`.
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -0,0 +1,55 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+
+import dap_server
+import shutil
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import line_number
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class Test
@@ -0,0 +1,16 @@
+#include
eronnen wrote:
fixed, for some reason I'm getting a warning `ISO C requires a translation unit
to contain at least one declarationclang(-Wempty-translation-unit)` but I can
ignore
https://github.com/llvm/llvm-project/pull/139969
___
eronnen wrote:
Fixed comments
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/4] [lldb-dap] Migrate disassemble request to structured
handler
1 - 100 of 178 matches
Mail list logo
