================ @@ -452,6 +475,9 @@ struct DAP { std::mutex m_active_request_mutex; const protocol::Request *m_active_request; + + llvm::StringMap<SourceBreakpointMap> m_source_breakpoints; + llvm::DenseMap<int64_t, SourceBreakpointMap> m_source_assembly_breakpoints; ---------------- eronnen wrote:
I think it should be pretty simplified already since the only access to these maps is abstracted by `DAP::SetSourceBreakpoints` It should be possible to use `Source` as a key but I think it might introduce new complications like implementing a hash / ordering for the struct, and there are extra fields in `Source` like `name` and `presentationHint` https://github.com/llvm/llvm-project/pull/139969 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits