https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/137580
>From 9c29520abea852086f8f4c555e2ad1ea7c711800 Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Sun, 27 Apr 2025 22:33:44 -0700
Subject: [PATCH] [clang] Add `__ptrauth_restricted_intptr` qualifier
__ptrauth_rest
github-actions[bot] wrote:
@satyajanga Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bui
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: satyajanga
Date: 2025-05-02T18:36:08-07:00
New Revision: fba68b41190805d1755d24a829d7cdc74e946095
URL:
https://github.com/llvm/llvm-project/commit/fba68b41190805d1755d24a829d7cdc74e946095
DIFF:
https://github.com/llvm/llvm-project/commit/fba68b41190805d1755d24a829d7cdc74e946095.diff
LO
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138169
>From ef04502d17c36044cd5fb96f333c328c8215f354 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 10:11:10 -0700
Subject: [PATCH 1/5] Add new API to expose the expected size in bytes of a
core b
ashgti wrote:
> It is also ignored in the `SetFrame/ThreadFormat` functions. I am not sure if
> we should accept it as it also valid in the command line
Updated to remove the `.empty()` check.
https://github.com/llvm/llvm-project/pull/137911
___
lldb
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/137911
>From a43b90dba56bd411b09257d47e3a3091faa09efd Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 29 Apr 2025 17:36:46 -0700
Subject: [PATCH 1/5] [lldb-dap] Migrate attach to typed RequestHandler.
This upda
@@ -333,6 +333,7 @@ def attach(
exitCommands=None,
attachCommands=None,
coreFile=None,
+stopOnAttach=True,
ashgti wrote:
Sounds good, we can follow up with some other improvements to tests.
https://github.com/llvm/llvm-project/
https://github.com/ashgti approved this pull request.
Yesterday I enabled all the lldb-dap tests that support macOS and I noticed
#138197 where some tests `attach` failed due to attaching to a parallel test
process. I was consistently hitting it on my MBP but I think due to timing not
on my Ma
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/138330
>From aafaaa46cb5c9733451eea93be7d4a69cf88c7ad Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 2 May 2025 12:40:11 -0700
Subject: [PATCH 1/2] Handle step-in over a Darwin "branch island".
---
.../MacOSX
@@ -137,55 +137,69 @@ void AttachRequestHandler::operator()(const
llvm::json::Object &request) const {
dap.SendOutput(OutputType::Console,
llvm::StringRef(attach_msg, attach_msg_len));
}
- if (attachCommands.empty()) {
-// No "attachCommands", jus
@@ -591,6 +591,7 @@ def request_attach(
attachCommands=None,
terminateCommands=None,
coreFile=None,
+stopOnAttach=True,
JDevlieghere wrote:
See my reply to John:
https://github.com/llvm/llvm-project/pull/138219#discussion_r2072
@@ -137,55 +137,69 @@ void AttachRequestHandler::operator()(const
llvm::json::Object &request) const {
dap.SendOutput(OutputType::Console,
llvm::StringRef(attach_msg, attach_msg_len));
}
- if (attachCommands.empty()) {
-// No "attachCommands", jus
@@ -25,9 +25,10 @@ def spawn_and_wait(program, delay):
process.wait()
-@skipIf
class TestDAP_attach(lldbdap_testcase.DAPTestCaseBase):
def set_and_hit_breakpoint(self, continueToExit=True):
+self.dap_server.wait_for_stopped()
kusmour wrote:
@@ -427,6 +430,7 @@ def cleanup():
# Initialize and launch the program
self.dap_server.request_initialize(sourceInitFile)
+self.dap_server.request_configurationDone()
kusmour wrote:
ditto
https://github.com/llvm/llvm-project/pull/1382
@@ -235,7 +235,7 @@ def test_auto_completions(self):
"""
Tests completion requests in "repl-mode=auto"
"""
-self.setup_debugee()
+self.setup_debugee(stopOnEntry=True)
kusmour wrote:
Any reason why we are changing the tes
@@ -591,6 +591,7 @@ def request_attach(
attachCommands=None,
terminateCommands=None,
coreFile=None,
+stopOnAttach=True,
kusmour wrote:
Is there any reason we want to make this true by default?
1) Our current tests don't have sto
@@ -88,8 +88,8 @@ def test_stopOnEntry(self):
"""
program = self.getBuildArtifact("a.out")
self.build_and_launch(program, stopOnEntry=True)
-self.set_function_breakpoints(["main"])
-stopped_events = self.continue_to_next_stop()
+
@@ -357,6 +358,7 @@ def cleanup():
self.addTearDownHook(cleanup)
# Initialize and launch the program
self.dap_server.request_initialize(sourceInitFile)
+self.dap_server.request_configurationDone()
kusmour wrote:
Shouldn't we wai
https://github.com/kusmour requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/138219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/138209
>From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 1 May 2025 14:51:24 -0700
Subject: [PATCH 1/4] [lldb][Formatters] Add --pointer-match-depth option to
"type su
@@ -333,6 +333,7 @@ def attach(
exitCommands=None,
attachCommands=None,
coreFile=None,
+stopOnAttach=True,
JDevlieghere wrote:
The way the tests are currently written, they expect to be stopped after the
launch (presumably beca
@@ -270,10 +270,14 @@ class VectorTypeSyntheticFrontEnd : public
SyntheticChildrenFrontEnd {
}
llvm::Expected GetIndexOfChildWithName(ConstString name) override {
-const char *item_name = name.GetCString();
-uint32_t idx = ExtractIndexFromString(item_name);
-i
@@ -97,18 +97,19 @@ void lldb_private::formatters::AddFilter(
category_sp->AddTypeFilter(type_name, match_type, filter_sp);
}
-size_t lldb_private::formatters::ExtractIndexFromString(const char *item_name)
{
+llvm::Expected
adrian-prantl wrote:
I think her
@@ -591,6 +591,7 @@ def request_attach(
attachCommands=None,
terminateCommands=None,
coreFile=None,
+stopOnAttach=True,
ashgti wrote:
Should we default to `False` for attach requests?
https://github.com/llvm/llvm-project/pull/1
@@ -333,6 +333,7 @@ def attach(
exitCommands=None,
attachCommands=None,
coreFile=None,
+stopOnAttach=True,
ashgti wrote:
Should we default this to `False`?
Or should we have the `DAPTestCaseBase` case `attach` and `launch` help
JDevlieghere wrote:
> > @kusmour Can you please confirm whether or not there's a reason to run the
> > launch or attach commands in asynchronous mode? It looks like the
> > divergence was introduced when the feature was added
> > (https://reviews.llvm.org/D154028) and I'm not sure it's necessa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/include/lldb/API/SBSaveCoreOptions.h
lldb/inc
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138169
>From ef04502d17c36044cd5fb96f333c328c8215f354 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 10:11:10 -0700
Subject: [PATCH 1/5] Add new API to expose the expected size in bytes of a
core b
Jlalond wrote:
@bulbazord as always thanks for your insight Alex. I added a docstring with
your improved comment, almost forgot about that.
https://github.com/llvm/llvm-project/pull/138169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138169
>From ef04502d17c36044cd5fb96f333c328c8215f354 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 10:11:10 -0700
Subject: [PATCH 1/5] Add new API to expose the expected size in bytes of a
core b
Michael137 wrote:
> I like the idea of this PR (big fan of `llvm::Expected`) but the way this is
> implemented contains an anti-pattern IMO. Specifically, all callers consume
> the error from `ExtractIndexFromString` only to then create a similar but
> different error string afterwards. It wou
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This PR changes how we treat the launch sequence in lldb-dap.
- Send the initialized event after we finish handling the initialize
request, rather than after we finish attaching or launching.
-
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/138219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138219
>From e7333489e50b1efe16203e8fd7b6dc7f2dcd4439 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 2 May 2025 09:59:01 -0700
Subject: [PATCH 1/3] [lldb-dap] Change the launch sequence
This PR chang
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/138209
>From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 1 May 2025 14:51:24 -0700
Subject: [PATCH 1/3] [lldb][Formatters] Add --pointer-match-depth option to
"type su
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/138331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138206
>From 91ce0997c03f87ec617ec2a113e7e88f1a88de11 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 14:53:08 -0700
Subject: [PATCH 1/7] Change custom regions to be intersections, add test cases
fo
https://github.com/pkubaj edited
https://github.com/llvm/llvm-project/pull/138331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pkubaj edited
https://github.com/llvm/llvm-project/pull/138331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pkubaj edited
https://github.com/llvm/llvm-project/pull/138331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,c --
lldb/test/API/macosx/branch-islands/foo.c
lldb/tes
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/macosx/branch-islands/TestBranchIslands.py
``
Vie
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Piotr Kubaj (pkubaj)
Changes
Fix for:
`Assertion failed: (false && "Architecture or OS not supported"),
function CreateRegisterContextForFrame, file
/usr/src/contrib/llvm-project/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp,
lin
https://github.com/pkubaj created
https://github.com/llvm/llvm-project/pull/138331
Fix for:
Assertion failed: (false && "Architecture or OS not supported"), function
CreateRegisterContextForFrame, file
/usr/src/contrib/llvm-project/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp,
line
https://github.com/pkubaj edited
https://github.com/llvm/llvm-project/pull/138331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138330.diff
7 Files Affected:
- (modified)
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp (+20-7)
- (added) lldb/test/API/macosx/
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/138330
None
>From aafaaa46cb5c9733451eea93be7d4a69cf88c7ad Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 2 May 2025 12:40:11 -0700
Subject: [PATCH] Handle step-in over a Darwin "branch island".
---
.../MacO
https://github.com/bulbazord approved this pull request.
Thanks for adding tests. Please let others take a look before merging.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/bulbazord commented:
I like the idea of this PR (big fan of `llvm::Expected`) but the way this is
implemented contains an anti-pattern IMO. Specifically, all callers consume the
error from `ExtractIndexFromString` only to then create a similar but different
error string afte
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138020
>From 6a100fa2a13c5e8e10981746ea45c7345d3c46c9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 28 Apr 2025 10:28:03 -0700
Subject: [PATCH] [lldb][cmake] Error out when building debugserver with
@@ -154,6 +154,19 @@ endif()
add_definitions(-DLLDB_USE_OS_LOG)
+if(CMAKE_OSX_SYSROOT)
+ set(${MIG_SYSROOT} CMAKE_OSX_SYSROOT)
chelcassanova wrote:
Good catch, this doesn't work as-is. I'll update to correct this.
https://github.com/llvm/llvm-project/pull/
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -154,6 +154,19 @@ endif()
add_definitions(-DLLDB_USE_OS_LOG)
+if(CMAKE_OSX_SYSROOT)
+ set(${MIG_SYSROOT} CMAKE_OSX_SYSROOT)
bulbazord wrote:
Shouldn't this be `set(MIG_SYSROOT ${CMAKE_OSX_SYSROOT})`? Does this work as-is?
https://github.com/llvm/llvm-pr
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops,
static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP));
if (!S) {
const SCEV **O = SCEVAllocator.Allocate(Ops.size());
-std::uninitialized_copy(Ops.begin(), Ops.end(), O);
+llvm::uninitial
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) {
}
void Checksum::SetMD5(llvm::MD5::MD5Result md5) {
- const constexpr size_t md5_length = 16;
- std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin());
+ static_assert(sizeof(md5) ==
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From 46542ce5b946735c2c0a8f65e185761ebbf77073 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
https://github.com/bulbazord approved this pull request.
Ignoring whitespace, this is a pretty tiny change that makes sense.
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
kusmour wrote:
> @kusmour Can you please confirm whether or not there's a reason to run the
> launch or attach commands in asynchronous mode? It looks like the divergence
> was introduced when the feature was added (https://reviews.llvm.org/D154028)
> and I'm not sure it's necessary. My local
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) {
}
void Checksum::SetMD5(llvm::MD5::MD5Result md5) {
- const constexpr size_t md5_length = 16;
- std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin());
+ static_assert(sizeof(md5) ==
@@ -96,6 +97,8 @@ class FormattersMatchCandidate {
bool DidStripTypedef() const { return m_flags.stripped_typedef; }
+ uint32_t GetPtrStrippedDepth() const { return m_ptr_stripped_depth; }
ZequanWu wrote:
I meant this `FormattersMatchCandidate` has been s
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/138209
>From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 1 May 2025 14:51:24 -0700
Subject: [PATCH 1/2] [lldb][Formatters] Add --pointer-match-depth option to
"type su
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/138216
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2025-05-02T11:51:21-07:00
New Revision: 0ddcd209ddc8956eb52d642937a4397c6b08449c
URL:
https://github.com/llvm/llvm-project/commit/0ddcd209ddc8956eb52d642937a4397c6b08449c
DIFF:
https://github.com/llvm/llvm-project/commit/0ddcd209ddc8956eb52d642937a4397c6b08449c.diff
LOG
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/138216
>From 656fe559f84526fd3edc91b1c0d12fd56d838085 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 1 May 2025 16:27:37 -0700
Subject: [PATCH 1/2] Don't hold the Target's ModuleListLock over running
LoadScrip
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
https://github.com/satyajanga edited
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/satyajanga edited
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From c51a312cd3901a1e51d9e210b3efdc89389f0e10 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -938,15 +954,30 @@ llvm::Error DAP::Loop() {
StopEventHandlers();
});
- while (!disconnecting || !m_queue.empty()) {
+ while (true) {
std::unique_lock lock(m_queue_mutex);
-m_queue_cv.wait(lock, [&] { return disconnecting || !m_queue.empty(); });
+m_que
@@ -417,8 +424,11 @@ struct DAP {
lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); }
private:
- std::mutex m_queue_mutex;
+ /// Queue for all incoming messages.
std::deque m_queue;
+ /// Dedicated queue for launching and attaching.
+ std::deque m_launc
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@satyajanga
Please update your summary about where you removed the conditional, and the
description. Otherwise LGTM.
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/138321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (satyajanga)
Changes
Minor code change for removing the unneeded conditional.
we already check for `platform_sp` not null in the next line.
### TEST PLAN
manual test
```
satyajanga@devvm21837:toolchain $ ./bin/lldb
LLDB logging ini
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/satyajanga created
https://github.com/llvm/llvm-project/pull/138321
Minor code change for removing the unneeded conditional.
we already check for `platform_sp` not null in the next line.
### TEST PLAN
manual test
```
satyajanga@devvm21837:toolchain $ ./bin/lldb
LLDB loggi
@@ -22,8 +22,8 @@ Checksum &Checksum::operator=(const Checksum &checksum) {
}
void Checksum::SetMD5(llvm::MD5::MD5Result md5) {
- const constexpr size_t md5_length = 16;
- std::uninitialized_copy_n(md5.begin(), md5_length, m_checksum.begin());
+ static_assert(sizeof(md5) ==
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops,
static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP));
if (!S) {
const SCEV **O = SCEVAllocator.Allocate(Ops.size());
-std::uninitialized_copy(Ops.begin(), Ops.end(), O);
+llvm::uninitial
@@ -2038,6 +2038,11 @@ template auto mismatch(R1
&&Range1, R2 &&Range2) {
adl_end(Range2));
}
+template
+auto uninitialized_copy(R1 &&Src, IterTy Dst) {
jurahul wrote:
Thanks, fixed.
https://github.com/llvm/llvm-project/pull/138174
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From 7c67ef6748f8813b7aaa91f8e6b463d9fde57d94 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
teresajohnson wrote:
@dyung thanks for catching this, I haven't been able to watch closely and
didn't realize no one approved.
@anjenner No worries, misunderstandings happen. I do think we need to revert
this, however. See PR138203 - it sounds like this is causing issues with
lifetimes and I'
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
-// We launch and attach in synchronous mode then the first stop
-// event will not be delivere
JDevlieghere wrote:
@kusmour Can you please confirm whether or not there's a reason to run the
launch or attach commands in asynchronous mode? It looks like the divergence
was introduced when the feature was added (https://reviews.llvm.org/D154028)
and I'm not sure it's necessary. My local tes
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/138219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -417,8 +424,11 @@ struct DAP {
lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); }
private:
- std::mutex m_queue_mutex;
+ /// Queue for all incoming messages.
std::deque m_queue;
+ /// Dedicated queue for launching and attaching.
+ std::deque m_launc
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
-// We launch and attach in synchronous mode then the first stop
-// event will not be delivere
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/138219
>From e7333489e50b1efe16203e8fd7b6dc7f2dcd4439 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 2 May 2025 09:59:01 -0700
Subject: [PATCH] [lldb-dap] Change the launch sequence
This PR changes h
@@ -2038,6 +2038,11 @@ template auto mismatch(R1
&&Range1, R2 &&Range2) {
adl_end(Range2));
}
+template
+auto uninitialized_copy(R1 &&Src, IterTy Dst) {
s-barannikov wrote:
```suggestion
template
auto uninitialized_copy(R &&Src, Ite
jurahul wrote:
> This looks right, but I'd like someone else to go through to make sure it is
> right everywhere.
>
> Also, the md5 change looks... odd and counts a lot on the internal
> representation of md5, so I'm not sure about that one, but at least it is
> right NOW (Since MD5 inherits
DavidSpickett wrote:
I once again attempt to parse your PR description, armed with this
understanding.
> Currently we're creating inheritable (~FD_CLOEXEC) file descriptors in the
> (few) cases where we need to pass an FD to a subprocess. The problem with
> these is that, in a multithreaded a
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/138174
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2981,7 +2981,7 @@ ScalarEvolution::getOrCreateAddExpr(ArrayRef Ops,
static_cast(UniqueSCEVs.FindNodeOrInsertPos(ID, IP));
if (!S) {
const SCEV **O = SCEVAllocator.Allocate(Ops.size());
-std::uninitialized_copy(Ops.begin(), Ops.end(), O);
+llvm::uninitial
1 - 100 of 170 matches
Mail list logo