jurahul wrote: > This looks right, but I'd like someone else to go through to make sure it is > right everywhere. > > Also, the md5 change looks... odd and counts a lot on the internal > representation of md5, so I'm not sure about that one, but at least it is > right NOW (Since MD5 inherits from std::array).
For reference, this change is in lldb/source/Utility/Checksum.cpp in the PR. Right, if something changes there the static_assert that I added will fail, so in that sense it won't go unnoticed and cause subtle runtime issues. https://github.com/llvm/llvm-project/pull/138174 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
