[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath requested changes to this pull request. After reading https://github.com/llvm/llvm-project/issues/129543#issuecomment-2828385373 I get the feeling this is just speculative. So yea, there is a reason to not add InstructionARM64 -- it's not needed/used. https://github.

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread Pavel Labath via lldb-commits
labath wrote: Will this actually result in a popup window as https://github.com/llvm/llvm-project/pull/137002#issue-3014399288 implies? I'm worried that some of these messages might end up too annoying if the user has explicitly acknowledge each of them. https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

2025-04-24 Thread Pavel Labath via lldb-commits
labath wrote: What's the motivation? The instruction emulation plugins are used to implement software single-stepping on architectures without (reliably present) hardware support. AFAIK aarch64 is not one of those. https://github.com/llvm/llvm-project/pull/137267 __

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-24 Thread Pavel Labath via lldb-commits
labath wrote: Probably because windows uses a different (in-proces) implementation. https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5717c5f - [lldb] Re-enable TestDAP_stackTrace on Windows

2025-04-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-24T21:45:52-07:00 New Revision: 5717c5f385d3b8f5b395c3013aaba9929a618aa3 URL: https://github.com/llvm/llvm-project/commit/5717c5f385d3b8f5b395c3013aaba9929a618aa3 DIFF: https://github.com/llvm/llvm-project/commit/5717c5f385d3b8f5b395c3013aaba9929a618aa3.d

[Lldb-commits] [lldb] [lldb] Fix crash after second run when set a previous watchpoint. (PR #136682)

2025-04-24 Thread via lldb-commits
hapee wrote: > This patch may be all that's necessary, I haven't reproduced the failure > myself. We'd really like to have a test for this to ensure it doesn't > regress, I recently added a watchpoint API test to the testsuite as > `lldb/test/API/functionalities/watchpoint/consecutive-watc

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
@@ -612,7 +612,16 @@ def request_attach( if gdbRemoteHostname is not None: args_dict["gdb-remote-hostname"] = gdbRemoteHostname command_dict = {"command": "attach", "type": "request", "arguments": args_dict} -return self.send_recv(command_di

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
@@ -612,7 +612,16 @@ def request_attach( if gdbRemoteHostname is not None: args_dict["gdb-remote-hostname"] = gdbRemoteHostname command_dict = {"command": "attach", "type": "request", "arguments": args_dict} -return self.send_recv(command_di

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137280 >From c2eab3f2f09fd771cbd8c18f141de1fa7664af49 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 24 Apr 2025 17:59:29 -0700 Subject: [PATCH 1/2] [lldb] Emit diagnostics as "important" output Hand

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/2] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
@@ -672,21 +670,17 @@ DAP::CreateTargetFromArguments(const llvm::json::Object &arguments, // enough information to determine correct arch and platform (or ELF can be // omitted at all), so it is good to leave the user an apportunity to specify // those. Any of those thre

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/2] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/135008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fb01f19 - [lldb][lldb-dap] fix repeating commands in repl mode (#135008)

2025-04-24 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-04-25T02:32:52+01:00 New Revision: fb01f19f3cf6b3317983b06a7dbf5ed143072990 URL: https://github.com/llvm/llvm-project/commit/fb01f19f3cf6b3317983b06a7dbf5ed143072990 DIFF: https://github.com/llvm/llvm-project/commit/fb01f19f3cf6b3317983b06a7dbf5ed143072990.diff L

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py lldb

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes This patch makes the `request_attach` wait for events `process` and `initialized` just like `request_launch`. This ensure the DAP session can move forward somewhat correctly. Recently `TestDap_attach.test_terminate

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
@@ -159,6 +159,9 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments); /// Take ownership of the stored error. llvm::Error ToError(const lldb::SBError &error); +/// Provides the string value if this data structure is a string type. +std::string GetStringValue(c

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137280 >From c2eab3f2f09fd771cbd8c18f141de1fa7664af49 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 24 Apr 2025 17:59:29 -0700 Subject: [PATCH] [lldb] Emit diagnostics as "important" output Handle d

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Handle diagnostics events from the debugger (i.e. asynchronous errors and warnings) in the lldb-dap event handler and emit them as "important" output. --- Full diff: https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137280 Handle diagnostics events from the debugger (i.e. asynchronous errors and warnings) in the lldb-dap event handler and emit them as "important" output. >From f426ab064fff05cbda63dacc006a763e14fd1afd Mon Sep

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/137278 This patch makes the `request_attach` wait for events `process` and `initialized` just like `request_launch`. This ensure the DAP session can move forward somewhat correctly. Recently `TestDap_attach.test_term

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread John Harrison via lldb-commits
@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread John Harrison via lldb-commits
@@ -9,127 +9,69 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" +#include "llvm/Support/Error.h" #include "llvm/Support/FileSystem.h" +using namespace llvm; +using namespace lldb_dap::pr

[Lldb-commits] [lldb] [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (PR #136795)

2025-04-24 Thread via lldb-commits
royitaqi wrote: Checked `bin/llvm-lit -sv ../llvm-project/lldb/test/API/commands/statistics/basic/TestStats.py` again on both macOS and Linux after merging with `main`. https://github.com/llvm/llvm-project/pull/136795 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread John Harrison via lldb-commits
@@ -9,127 +9,69 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" +#include "llvm/Support/Error.h" #include "llvm/Support/FileSystem.h" +using namespace llvm; +using namespace lldb_dap::pr

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-24 Thread John Harrison via lldb-commits
@@ -672,21 +670,17 @@ DAP::CreateTargetFromArguments(const llvm::json::Object &arguments, // enough information to determine correct arch and platform (or ELF can be // omitted at all), so it is good to leave the user an apportunity to specify // those. Any of those thre

[Lldb-commits] [lldb] [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (PR #136795)

2025-04-24 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/136795 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 967434a - [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (#136795)

2025-04-24 Thread via lldb-commits
Author: royitaqi Date: 2025-04-24T17:23:41-07:00 New Revision: 967434aa3275842637937e9ac17614a10f81bae7 URL: https://github.com/llvm/llvm-project/commit/967434aa3275842637937e9ac17614a10f81bae7 DIFF: https://github.com/llvm/llvm-project/commit/967434aa3275842637937e9ac17614a10f81bae7.diff LOG:

[Lldb-commits] [lldb] [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (PR #136795)

2025-04-24 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136795 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 01/10] [lldb] Do not parse symtab during statistics dump Summary: Te

[Lldb-commits] [lldb] [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (PR #136795)

2025-04-24 Thread via lldb-commits
royitaqi wrote: Ran `ninja check-lldb` on both macOS and Linux and compared test counts before/after this patch. No regression observed. Merging. https://github.com/llvm/llvm-project/pull/136795 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
kastiglione wrote: I'll do that too (for what it's worth that name doesn't matter to the test system). https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 262158b - [lldb-dap] Support StackFrameFormat (#137113)

2025-04-24 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-24T16:25:31-07:00 New Revision: 262158b8aa12634c17f4b37cba62564e5c9baab4 URL: https://github.com/llvm/llvm-project/commit/262158b8aa12634c17f4b37cba62564e5c9baab4 DIFF: https://github.com/llvm/llvm-project/commit/262158b8aa12634c17f4b37cba62564e5c9baab4.d

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/137267.diff 2 Files Affected: - (modified) lldb/tools/lldb-server/CMakeLists.txt (+1) - (modified) lldb/tools/lldb-server/SystemInitializerLLGS

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

2025-04-24 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/137267 None >From e14614a7ded95fbe9988739ed9d35260f0541e86 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 25 Apr 2025 02:30:03 +0400 Subject: [PATCH] [lldb] Add InstructionARM64 to lldb-server --- lldb/t

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Shouldn't you change the name of the Python class as well? https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
kastiglione wrote: cc @rocallahan (for some reason I can't add you as a reviewer) https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/137262.diff 1 Files Affected: - (renamed) lldb/test/API/commands/process/reverse-continue/TestReverseContinueCommandNotSupported.py ()

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137262 None >From 83d011739ba3a03058474922428c341b9333056f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 24 Apr 2025 15:53:00 -0700 Subject: [PATCH] [lldb] Rename reverse-continue/TestReverseContinueNotSuppo

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-04-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/137041 >From 94248d8526064859c2f3eda0ac82d61f299100b2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 22 Apr 2025 16:35:00 -0700 Subject: [PATCH 1/2] Create proc status reader --- .../Plugins/Process/Utility/

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/136761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 05d605e3add0461b12ddfbb24349e20be4259060 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/8] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,76 @@ +//===-- RegisterInfoPOSIX_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
da-viper wrote: LGTM https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,8 @@ +#include da-viper wrote: don't need the header ```suggestion ``` https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/6] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I redid this PR to just add the Clang resource dir to the CMake file for the LLDB shell tests so that lit can pick it up since it's not necessary that the variable be in the CMake cache, just the scope that the lit config exists in. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb] Remerge #136236 (Avoid force loading symbols in statistics collection (PR #136795)

2025-04-24 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Looks good. Watch the buildbot, and please run your tests on both macOS and linux prior to merging to ensure we don't fail. I am a bit worried about system runtime plug-ins causing symbols to be loaded on some configs. https://github.com/

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/136761 >From d5760f9eb92ef65c853148f8fd39a2ed5d052fdf Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 22 Apr 2025 13:28:04 -0700 Subject: [PATCH] [lldb][cmake] Add clang resource dir to LLDB shell tes

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Adrian Prantl via lldb-commits
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString name) { } } } - return UINT32_MAX; + return llvm::createStringError( + "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'", adrian-prantl wro

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Adrian Prantl via lldb-commits
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString name) { } } } - return UINT32_MAX; + return llvm::createStringError( + "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'", adrian-prantl wro

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
eronnen wrote: @da-viper Fixed your comments, also now that the `stop-disassembly-dispaly` setting is not cached I merged the tests to one test and verified that the assembly changes mid-run according to the settings https://github.com/llvm/llvm-project/pull/136494

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,10 @@ +#include +#include eronnen wrote: :100: https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 05d605e3add0461b12ddfbb24349e20be4259060 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/7] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Adrian Prantl via lldb-commits
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args &path, bool leaf_is_command, return cur_as_multi; } +CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const { + if (auto frame_sp = GetExecutionContext().GetFrameSP()) { +auto frame

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -217,3 +216,30 @@ def test_functionNameWithArgs(self): self.continue_to_next_stop() frame = self.get_stackFrames()[0] self.assertEqual(frame["name"], "recurse(x=1)") + +@skipIfWindows da-viper wrote: LGTM But I could not see why

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -102,3 +103,23 @@ def test_stackTrace(self): self.assertGreaterEqual( totalFrames, i, "total frames should include a pagination offset" ) + +@skipIfWindows da-viper wrote: should skip linux https://github.com/ll

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/24] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/126935 >From ac748d0911fb1ccf7bb70955da2d70d7f9d9117e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Sun, 20 Oct 2024 02:55:02 +0200 Subject: [PATCH] [lldb/Host] Enable inheriting "non-inheritable" FDs Currently we'

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-04-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/137041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -172,8 +175,16 @@ bool lldb_private::formatters::BlockPointerSummaryProvider( static const ConstString s_FuncPtr_name("__FuncPtr"); - lldb::ValueObjectSP child_sp = synthetic_children->GetChildAtIndex( - synthetic_children->GetIndexOfChildWithName(s_FuncPtr_name));

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-24 Thread Petr Hosek via lldb-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/136843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/115408 >From fc24e6cfed5f93f700a92618459365f2e320f2b1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 7 Nov 2024 17:18:50 -0800 Subject: [PATCH] [lldb] Support riscv32 corefiles --- .../Plugins/Proce

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/5] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7a276c8 - [lldb] Fix logic error in AppleObjCTypeEncodingParser (#137067)

2025-04-24 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-24T10:09:05-07:00 New Revision: 7a276c8acfc3977de8c3ceb0af67fcf603834946 URL: https://github.com/llvm/llvm-project/commit/7a276c8acfc3977de8c3ceb0af67fcf603834946 DIFF: https://github.com/llvm/llvm-project/commit/7a276c8acfc3977de8c3ceb0af67fcf603834946.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137113 >From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 23 Apr 2025 20:05:19 -0700 Subject: [PATCH 1/4] [lldb-dap] Support StackFrameFormat The debug adap

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -180,44 +184,53 @@ void StackTraceRequestHandler::operator()( llvm::json::Object body; lldb::SBFormat frame_format = dap.frame_format; + bool include_all = false; ashgti wrote: Should this default to `dap.configuration.displayExtendedBacktrace` and th

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Add a function `IsValidDereferenceType` to TypeSystem. TypeSystemClang now allows arrays to be dereferenced. --- Full diff: https://github.com/llvm/llvm-project/pull/135843.diff 7 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/135843 >From 08834d47602b0df46e43678c08b3902d45145871 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Wed, 16 Apr 2025 00:30:51 +0500 Subject: [PATCH 1/3] [lldb][TypeSystemClang] Add a function `IsValidDereferenceType

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137113 >From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 23 Apr 2025 20:05:19 -0700 Subject: [PATCH 1/3] [lldb-dap] Support StackFrameFormat The debug adap

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd ready_for_review https://github.com/llvm/llvm-project/pull/135843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/packa

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()( llvm::json::Array stack_frames; llvm::json::Object body; + lldb::SBFormat frame_format = dap.frame_format; + + if (const auto *format = arguments->getObject("format")) { +const bool parameters = GetBool

  1   2   >